Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
MIME-Version: 1.0
References: <20230823-strncpy-drivers-accel-habanalabs-common-habanalabs_drv-v1-1-147656947586@google.com>
 <20230825091856.GB3748525@linux.intel.com>
In-Reply-To: <20230825091856.GB3748525@linux.intel.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Mon, 18 Sep 2023 10:52:01 +0300
Message-ID: <CAFCwf11afiokfGubENdOggb6VvmWAyakeAqJAR-JQN66QHOpAA@mail.gmail.com>
Subject: Re: [PATCH] accel/habanalabs: refactor deprecated strncpy
To:     Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Cc:     Justin Stitt <justinstitt@google.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Aug 25, 2023 at 12:19=E2=80=AFPM Stanislaw Gruszka
<stanislaw.gruszka@linux.intel.com> wrote:
>
> On Wed, Aug 23, 2023 at 12:23:08AM +0000, Justin Stitt wrote:
> > `strncpy` is deprecated for use on NUL-terminated destination strings [=
1].
> >
> > A suitable replacement is `strscpy` [2] due to the fact that it
> > guarantees NUL-termination on its destination buffer argument which is
> > _not_ the case for `strncpy`!
> >
> > There is likely no bug happening in this case since HL_STR_MAX is
> > strictly larger than all source strings. Nonetheless, prefer a safer an=
d
> > more robust interface.
> >
> > It should also be noted that `strscpy` will not pad like `strncpy`. If
> > this NUL-padding behavior is _required_ we should use `strscpy_pad`
> > instead of `strscpy`.
> >
> > Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on=
-nul-terminated-strings[1]
> > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en=
.html [2]
> > Link: https://github.com/KSPP/linux/issues/90
> > Cc: linux-hardening@vger.kernel.org
> > Signed-off-by: Justin Stitt <justinstitt@google.com>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
>
Applied to -next
Thanks,
Oded