Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH v2 0/3] HID: nvidia-shield: Fix the error handling path of shield_probe()
Date:   Sun, 17 Sep 2023 21:13:42 -0700
Message-Id: <20230918041345.59859-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wAGTqfiyxtR8wE/Fco6atWEXg9WGNoirAfp380ml3AZnxKh1Pmr5Rp7002Aq?=
 =?us-ascii?Q?UAmuZbbPeqFT2vORcd+3dc7e5UbPwhnJgtFTvRGH9t8sivaNdhTxY+HXqLCJ?=
 =?us-ascii?Q?VkTvLr9HoUou+OIYe47/cddFfaC4FCnTBXVDFquc9n3Raxw3Ef2v//CuRYwV?=
 =?us-ascii?Q?AJdG4TzBBdc0/VVCugBdprvec16vQ5KhM6rOkIbcagFC2t0k0JUKG1oR7sPG?=
 =?us-ascii?Q?Dl7yHbcnyMWjz6+N4LD/UNDlI/3qDC0xwgtoHYVIDIn/GvdnKXHR8/lXjQAv?=
 =?us-ascii?Q?B9cZz6+QOWFLmX1Ytq20CY0DOO5FF0oDk2NMmpmFXLCTe+nrYpFuezDSa2Ea?=
 =?us-ascii?Q?BTieUyo5t3w3TzelXGkXT5WAGfKpHDDVAlzq+Pzi/DQIUwKI1yFA5/mqaZnV?=
 =?us-ascii?Q?wD1nDHqTYNb4x8VDv8qesfg+l4+TvTT5tEWpgIijFdHjrv2AwcCSpLZFNpAp?=
 =?us-ascii?Q?2GIYpTjaDZrfcr5YbKcsSN99PjKBAL9rIBp0KCdvMUy0Z9UYb4VYwMw3GH34?=
 =?us-ascii?Q?yTwMdgXT4dyd89C2FCnjZxEuSXzV8NCJo+xppF7dOgavKE7WRvNLLdecqzBp?=
 =?us-ascii?Q?CPlqNAEcdBqsGl8oh33wIFBCd4aFQLiTn/T9x/dohxZf8ges8GZotgXqkib8?=
 =?us-ascii?Q?fWGhc2vKf5cho7jGkJjsBC90QJol8zEp9ttyMhrxAF4H4/uMcWxdhFn60Ltl?=
 =?us-ascii?Q?VFi8Pu3Nzoq7MdZuZymbT++TQg0lI+460niNbPtwQWEhtMJ68TiGcsr82TsP?=
 =?us-ascii?Q?176woJjzM47ykxmeZEffeV++YaS1YBlqnvNsL1vLWWN1Y5H/iHu0cn3bSh84?=
 =?us-ascii?Q?cVu6+GbfcgGw++YuLvfK4QHBrIW1tn6iu6GPs1D9byxRDa3lsUR3FsQuz5uo?=
 =?us-ascii?Q?+1qEi2v7WRF1mGyCbTpt9YXFl61SwmjIvyUbcnTzc/AvgXOqBCPPCGPQ4P5E?=
 =?us-ascii?Q?B/hO48AB52Gk8zFJooOgsckWoQjtStKxaFT6T6HHJK4e9out2PCjGwMAYDEO?=
 =?us-ascii?Q?yo2Ab6V3A1p0ekgFzTtC/y/ySjrW5/32Nftf6dM0NMKTkJdgqab0QR56w/Ga?=
 =?us-ascii?Q?qDqIZHLPuZ5M7wV2dBcE9nqeQSqQEwOaaxcwqOrVrSPz+U8+c2vvyX+r118B?=
 =?us-ascii?Q?Xc2LP1V+DO+7YiiXALxmhCPfvx8xy6rb+/kjij3qaO1ndc/+r6wQrJ1pC6j3?=
 =?us-ascii?Q?oZPNWO9u/6hSJpw2fv6/jtq6IdM7rQ3JkEcx7F2jQGSDT2v3X+sVVXpxZT+6?=
 =?us-ascii?Q?lxgPJ5iG1WGwXoUT+QHqY1cio3koO5/5Ldv4Cbqb5CIOSPP87hQpeZyDV6q2?=
 =?us-ascii?Q?INTAG+HwmaqZ2aE0wnZCi2mCMciLSUYV4hyTUMn6o7oMT6+6+G37WOBbZAPi?=
 =?us-ascii?Q?ENDeKbRVpYy5lAlx4g3qtE+w7XGOmJEkkTthN6YLGjTcSFMntlZkj8nyHcWU?=
 =?us-ascii?Q?kGQHU7aadGOpAlbMHOyxrVzUurIOH6EWrVZsL27h+wI1/wHHNK01n2gKjxj5?=
 =?us-ascii?Q?Q0mtNX3Cy/DokncCBkBk1Z47A0ZAdG2Ely2o4W8jI6HukM4WE+R7i1ozdJRe?=
 =?us-ascii?Q?yZYPPqcjxCrMRLcqFqCwbl6KTfVHDg/YaY9dJssB?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e68870b-da94-4813-4aa2-08dbb7fdbead
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 04:14:25.7596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2vau0mWrvIc70UvdDV7wY1F7tNGuH9bQXOJlieO2POZOhjaNDwjJntrKr5MwMaU4qa+xnNwegLIY9UXYCj/fBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5658
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 17 Sep 2023 21:15:48 -0700 (PDT)

This series fixes some missing clean-up function calls in the error handling of
the probe.

Patch 1 and 2 fix some similar issues introduced in 2 different commits (hence 2
patches)

Patch 3 is an enhancement that creates a common function for cleaning up
thunderstrike instances.

Changes:

  v1->v2:
    - Add the LED_RETAIN_AT_SHUTDOWN flag to prevent
      led_classdev_unregister from trying to set the LED to off before a
      successful call to hid_hw_start.
    - Rename err_haptics label to err_ts_create to make the label name more
      accurate.
    - Re-order operations in thunderstrike_destroy to be in LIFO order with
      regards to the operations in thunderstrike_create.

Link: https://lore.kernel.org/linux-input/cover.1693070958.git.christophe.jaillet@wanadoo.fr/

Notes from Rahul:
  - Thank you so much Christophe for these patches.

Christophe JAILLET (3):
  HID: nvidia-shield: Fix a missing led_classdev_unregister() in the
    probe error handling path
  HID: nvidia-shield: Fix some missing function calls() in the probe
    error handling path
  HID: nvidia-shield: Introduce thunderstrike_destroy()

 drivers/hid/hid-nvidia-shield.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

-- 
2.40.1