Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp6066084rdb; Mon, 18 Sep 2023 03:09:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKZIeoWAre9PvHP0/GoJlqKwNWgNp09QFtEqAWEWc3uHKx6+6X0Ea0XHvhuRyKDD0pbiQI X-Received: by 2002:a05:6830:4d6:b0:6b8:7584:3aa4 with SMTP id s22-20020a05683004d600b006b875843aa4mr8581434otd.4.1695031769743; Mon, 18 Sep 2023 03:09:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695031769; cv=none; d=google.com; s=arc-20160816; b=noN2Ei02M4J4lB8WQEgPljr5LKjnqdRGX4vKp68EZUbVJ9KXvO8KKIqPDLzYkhIPsg StK9Q/30gVg1QN0c6qsJNWfNv4+pz8zN8tt/LQXr9wqvUEUXyQcmcQGC62id1ENpA1Oa eBmOVmoZnkSvUt20IE0v6TORcvJizOXuQX9QisgzRoKvtMdQtTo3DueWUcs+l3x5V/hS uOCgpdGCBV2JjduNV7/wf4YG7fTNVJnUUGXulK6A5W9HtApjVWsjlXhthF++DFNykDqu GcUNlRAJ9HYM7JqQu0OFiWzdcc3DPs8vu6IGn2MFspdvN+jVRqKH1n7fuB/wCpQ5+/Pm lJwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=iXp5b086KsbLYq4QM46EPb55r1P1rRq9/nXasxpVGxk=; fh=++/kzdIj5Jd+Tcyt/msE9lKyvyLqpR4ceCQR4WpvB/U=; b=TuAndsrQ28IC/YD97nyzKBG32Z/DoIwKm7/A+OvCkjtyVsOWuwiAqAJMzm/IGFkMrk tCLCGjfMNANdjx7BVq0Ju9bm3oM9lfrfCSREOG13oKkh3CniZRsoWB9rxnHjYOC4fEOo FBw91kTbeP5YtvoUK4CLx/HuSIFL1VBUdWHBFh6OoZgJ1o7TJBWeD+rGzGmVYTFhnbXe k8ub1WG8Ba3kKKSu6LQD1aRpPBzs0dBIAHDp5R2B0tawq+xmA8GVpxeSB0g4vbMtnefz 9UgdVK42d02k3rWK61kMUOpozBgItUFE+RsYpRmV/JXHE3Db9znaawBVtIxHOY742HHC Kn/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id b66-20020a636745000000b005774635c69dsi7757492pgc.66.2023.09.18.03.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 03:09:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 567A4805BC9E; Mon, 18 Sep 2023 02:55:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241001AbjIRJyb (ORCPT + 99 others); Mon, 18 Sep 2023 05:54:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241129AbjIRJyP (ORCPT ); Mon, 18 Sep 2023 05:54:15 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 45094F1; Mon, 18 Sep 2023 02:54:09 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E70581FB; Mon, 18 Sep 2023 02:54:45 -0700 (PDT) Received: from [10.57.64.210] (unknown [10.57.64.210]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4383F3F67D; Mon, 18 Sep 2023 02:54:05 -0700 (PDT) Message-ID: Date: Mon, 18 Sep 2023 10:54:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v5 3/6] drm/panfrost: Add fdinfo support for memory stats Content-Language: en-GB To: =?UTF-8?Q?Adri=c3=a1n_Larumbe?= , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, robh@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, healych@amazon.com, kernel@collabora.com, Boris Brezillon References: <20230914223928.2374933-1-adrian.larumbe@collabora.com> <20230914223928.2374933-4-adrian.larumbe@collabora.com> From: Steven Price In-Reply-To: <20230914223928.2374933-4-adrian.larumbe@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 02:55:03 -0700 (PDT) On 14/09/2023 23:38, Adrián Larumbe wrote: > A new DRM GEM object function is added so that drm_show_memory_stats can > provide more accurate memory usage numbers. > > Ideally, in panfrost_gem_status, the BO's purgeable flag would be checked > after locking the driver's shrinker mutex, but drm_show_memory_stats takes > over the drm file's object handle database spinlock, so there's potential > for a race condition here. > > Signed-off-by: Adrián Larumbe > Reviewed-by: Boris Brezillon Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 ++ > drivers/gpu/drm/panfrost/panfrost_gem.c | 14 ++++++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index a8d02273afab..ef6563cf5f7e 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -567,6 +567,8 @@ static void panfrost_show_fdinfo(struct drm_printer *p, struct drm_file *file) > struct panfrost_device *pfdev = dev->dev_private; > > panfrost_gpu_show_fdinfo(pfdev, file->driver_priv, p); > + > + drm_show_memory_stats(p, file); > } > > static const struct file_operations panfrost_drm_driver_fops = { > diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/panfrost/panfrost_gem.c > index 3c812fbd126f..7d8f83d20539 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gem.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c > @@ -195,6 +195,19 @@ static int panfrost_gem_pin(struct drm_gem_object *obj) > return drm_gem_shmem_pin(&bo->base); > } > > +static enum drm_gem_object_status panfrost_gem_status(struct drm_gem_object *obj) > +{ > + struct panfrost_gem_object *bo = to_panfrost_bo(obj); > + enum drm_gem_object_status res = 0; > + > + res |= (bo->base.madv == PANFROST_MADV_DONTNEED) ? > + DRM_GEM_OBJECT_PURGEABLE : 0; > + > + res |= (bo->base.pages) ? DRM_GEM_OBJECT_RESIDENT : 0; > + > + return res; > +} > + > static const struct drm_gem_object_funcs panfrost_gem_funcs = { > .free = panfrost_gem_free_object, > .open = panfrost_gem_open, > @@ -206,6 +219,7 @@ static const struct drm_gem_object_funcs panfrost_gem_funcs = { > .vmap = drm_gem_shmem_object_vmap, > .vunmap = drm_gem_shmem_object_vunmap, > .mmap = drm_gem_shmem_object_mmap, > + .status = panfrost_gem_status, > .vm_ops = &drm_gem_shmem_vm_ops, > }; >