Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 18 Sep 2023 11:03:57 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
Cc:     Prashant Malani <pmalani@chromium.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "chrome-platform@lists.linux.dev" <chrome-platform@lists.linux.dev>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "bleung@chromium.org" <bleung@chromium.org>
Subject: Re: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport
 Alternatemode 2.1 Support
Message-ID: <ZQgEbXDNZ+Ap/HiV@kuha.fi.intel.com>
References: <20230912005752.1532888-1-utkarsh.h.patel@intel.com>
 <20230912005752.1532888-4-utkarsh.h.patel@intel.com>
 <CACeCKacmH19niA7gWTZCj89ZmFth0LWvkMYasYwUvVHrmFKCZw@mail.gmail.com>
 <MWHPR11MB0048848CD12DC750417E7264A9F6A@MWHPR11MB0048.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR11MB0048848CD12DC750417E7264A9F6A@MWHPR11MB0048.namprd11.prod.outlook.com>
Precedence: bulk

On Fri, Sep 15, 2023 at 04:01:44PM +0000, Patel, Utkarsh H wrote:

> > > b057250704e8..3a747938cdab 100644
> > > --- a/include/linux/usb/pd_vdo.h
> > > +++ b/include/linux/usb/pd_vdo.h
> > > @@ -376,6 +376,7 @@
> > >          | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) & 0x3) << 5   \
> > >          | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7))
> > >
> > > +#define VDO_TYPEC_CABLE_SPEED(vdo)     ((vdo) & 0x7)
> > 
> > I would suggest putting this header modification in a separate patch; if for
> > some reason we have to revert the Chrome part of the change, then we won't
> > rip this part out too (some other driver down the road may use the macro and
> > would break if it were to be removed). But I'll leave it to Heikki to determine
> > whether that is preferred.
> > 
> Heikki,  What's your preference here?

I think separate patch for this like Prashant said.

thanks,

-- 
heikki