Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp6069350rdb; Mon, 18 Sep 2023 03:16:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFf63M14W5zd/u+OnPDX0kj9z5vcViZ2o5rIlQH3TFJEzBgRyMK1URgFGiurpQmeRCJImEa X-Received: by 2002:a17:902:ec81:b0:1c3:6d97:e89e with SMTP id x1-20020a170902ec8100b001c36d97e89emr11317921plg.58.1695032170825; Mon, 18 Sep 2023 03:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695032170; cv=none; d=google.com; s=arc-20160816; b=nLR1O6I5IrFywOkmmS6EYh/lUuW+VPPlf4HcObrc4DW01ZQLzZb7MxdUZm1O2REcLu hBCtHM0iZoky4jkjKSVX5imp+oqEsiOGHiInBvffJU7PgeNRvxUW8XnkyZeptNb75vdO hGgtTPDaaE6Jj2Jdac4BLnNdWKATLkrh3TGyUhJ2RPfbHM3tPA9yKQUWvD+0a/hi9aFD ypoANS3cYEwFZLIHEmd45/MPGmuKhgpOa03sJgfmr6Tp0ogevc6Y+DxWRD28xxCojo4G kHMdLRgiSDZkbfVQq5ODN5DTAeQOVnllfOqKH/Uj9bm36Zttf/KqN3XAT7YKod3GziwW W1Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=VIUnJJO9kl5fwJoMX+OP6gF1uaqyPK4Bv+f+ICiFN1A=; fh=Bp0+jhj4+eOzvkf2KMiejGYDFsV+Syt+p+AivnBT/qM=; b=vNYJPj2qF2CEnjlaIjR//VA9DmT155coQfYNpta3huO3LXJ6Hz+sk7MbOSH8qlOBRY 4EowumLHKlXtfoxXUpCofaWVJ1vxak62CeVkpbf0LfzON+9ayYRXVsVyu6l7wDA72vTz 2xhfge3hZ7uWJShRHR4ACeX7jnr9Eq+L1R/F0MPAykPsOq6vHAWqChTMvhpKpeLcckJS 4Zbj6SmHPvsC0+Y7pKyzeHgq4yavzcmslr6JYaO4OKKdCErSBGAD/cca+4iq69sF1v9Y HmX/agpcdPsFI7R29cQ6AHTN2jnJ3JaRf4ZRs13KPsVVFwV4av7MO/XUV8cKq/n5GAf+ Rbqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id r10-20020a170902be0a00b001bf20c80685si7605429pls.125.2023.09.18.03.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 03:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 5369080CFD66; Mon, 18 Sep 2023 03:04:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232988AbjIRKEO (ORCPT + 99 others); Mon, 18 Sep 2023 06:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241109AbjIRKD5 (ORCPT ); Mon, 18 Sep 2023 06:03:57 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 68B6F187; Mon, 18 Sep 2023 03:03:19 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 589551FB; Mon, 18 Sep 2023 03:03:56 -0700 (PDT) Received: from [10.57.64.210] (unknown [10.57.64.210]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 70ADB3F67D; Mon, 18 Sep 2023 03:03:15 -0700 (PDT) Message-ID: <3785093c-0237-05fa-3c96-2239ce2417b3@arm.com> Date: Mon, 18 Sep 2023 11:03:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v5 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats Content-Language: en-GB To: =?UTF-8?Q?Adri=c3=a1n_Larumbe?= , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, robh@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, healych@amazon.com, kernel@collabora.com References: <20230914223928.2374933-1-adrian.larumbe@collabora.com> <20230914223928.2374933-7-adrian.larumbe@collabora.com> From: Steven Price In-Reply-To: <20230914223928.2374933-7-adrian.larumbe@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 18 Sep 2023 03:04:48 -0700 (PDT) On 14/09/2023 23:38, Adrián Larumbe wrote: > The current implementation will try to pick the highest available size > display unit as soon as the BO size exceeds that of the previous > multiplier. That can lead to loss of precision in contexts of low memory > usage. > > The new selection criteria try to preserve precision, whilst also > increasing the display unit selection threshold to render more accurate > values. > > Signed-off-by: Adrián Larumbe I have to admit I find it odd to be "pretty printing" this value in the first place. But this is clearly an improvement. Reviewed-by: Steven Price > --- > drivers/gpu/drm/drm_file.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c > index 762965e3d503..34cfa128ffe5 100644 > --- a/drivers/gpu/drm/drm_file.c > +++ b/drivers/gpu/drm/drm_file.c > @@ -872,6 +872,8 @@ void drm_send_event(struct drm_device *dev, struct drm_pending_event *e) > } > EXPORT_SYMBOL(drm_send_event); > > +#define UPPER_UNIT_THRESHOLD 100 > + > static void print_size(struct drm_printer *p, const char *stat, > const char *region, u64 sz) > { > @@ -879,7 +881,8 @@ static void print_size(struct drm_printer *p, const char *stat, > unsigned u; > > for (u = 0; u < ARRAY_SIZE(units) - 1; u++) { > - if (sz < SZ_1K) > + if ((sz & (SZ_1K - 1)) && > + sz < UPPER_UNIT_THRESHOLD * SZ_1K) > break; > sz = div_u64(sz, SZ_1K); > }