Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Mon, 18 Sep 2023 16:07:11 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Jonathan Corbet <corbet@lwn.net>,
        Charles Han <hanchunchao@inspur.com>, djwong@kernel.org,
        dchinner@redhat.com, allison.henderson@oracle.com,
        bhelgaas@google.com
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Documentation: xfs: Remove duplicate 'the' in
 transaction sequence process
Message-ID: <ZQgTP8uQUNAnBmX9@debian.me>
References: <20230918074054.313204-1-hanchunchao@inspur.com>
 <ZQgEYU71YE6Jv38D@debian.me>
 <87ttrrc2yl.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="NHywu6YAwHJz5eyG"
Content-Disposition: inline
In-Reply-To: <87ttrrc2yl.fsf@meer.lwn.net>
Precedence: bulk


--NHywu6YAwHJz5eyG
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 18, 2023 at 02:14:58AM -0600, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>=20
> > On Mon, Sep 18, 2023 at 03:40:54PM +0800, Charles Han wrote:
> >> Remove the repeated word "the" in comments.
> >
> > Patch title looks OK but in this case, the patch description should als=
o match.
> > Hint: there is no code comments in the doc below.
> >
> >>=20
> >> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> >> ---
> >>  Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>=20
> >> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Do=
cumentation/filesystems/xfs-online-fsck-design.rst
> >> index 1625d1131093..a0678101a7d0 100644
> >> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> >> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> >> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
> >>  2. The second transaction contains a physical update to the free spac=
e btrees
> >>     of AG 3 to release the former BMBT block and a second physical upd=
ate to the
> >>     free space btrees of AG 7 to release the unmapped file space.
> >> -   Observe that the the physical updates are resequenced in the corre=
ct order
> >> +   Observe that the physical updates are resequenced in the correct o=
rder
> >>     when possible.
> >>     Attached to the transaction is a an extent free done (EFD) log ite=
m.
> >>     The EFD contains a pointer to the EFI logged in transaction #1 so =
that log
> >
> > Regardless, wait for one or few days before rerolling this patch with
> > reviews addressed. It allows other reviewers to catch up and review. Yo=
u can
> > also Cc: me if you'd like.
>=20
> Bagas, this is a patch removing an extra "the".  We do not need to make
> life this hard for such a simple fix.
>=20
> Charles, the patch is good enough, no need for a third version.
>=20
> (Next time, though, do wait before resubmitting a patch.  When you do,
> put a description of what changed below the "---" line.)

Thanks for the reminder!

--=20
An old man doll... just what I always wanted! - Clara

--NHywu6YAwHJz5eyG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZQgTOwAKCRD2uYlJVVFO
o08bAQC2F1Tpy3iLd+nzrRF2ezl8Dbw9/8MjQPtYgX3ScNL6KQEAkTgm+MZcDGw3
8kzg6fqFKRwmDo9X0ehrtoNjtaMthAk=
=YlNw
-----END PGP SIGNATURE-----

--NHywu6YAwHJz5eyG--