Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp6100488rdb; Mon, 18 Sep 2023 04:26:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4Rw90DDaShK+h7N4VT6qnpS7OMya6w2kkfR6pQj0ZgXEjYuXXDlpS4RQrmnjBWQWXz62I X-Received: by 2002:a05:6a00:a1f:b0:68f:e810:e87e with SMTP id p31-20020a056a000a1f00b0068fe810e87emr9428162pfh.31.1695036380372; Mon, 18 Sep 2023 04:26:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695036380; cv=none; d=google.com; s=arc-20160816; b=pmcxd7X7FH/DsedkJVv79/B3hptwf2MkHj5syByUvzXp1/ECZQRfFILIek+V5zIPcQ fGSXcq3ScKBhjHb47F9ePRKy+Er6IagRWVFVvA21jPn75r8FJPXMO2zuAQ/Ov+ma7qpy dRuI5OVBowkZ5Y8eUQWXv5D0YzOmRKmPEjF9emty0TC9tQQ5GcnLIjYnQ5rIuJw9+L11 iLrp4iFzQ0RGyOvmWTSfCbT29S6TH0Zka4tmicPcCflWCGC+15yosqPKeK70LCbqHH8F LYtYt/0X6XAnFI/ipiGhx0gvm7A9MMxM8nXySdyavyKjwsXzyZ7TqXvsUepdVx5fI7y6 +adg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3CIzAQBDBRAbXi6odnAuwsq+At6oBbxMnuT61WOfur8=; fh=uvPFHZ6O+6vK+/STcKNFYkvqfYxU2P30cfste/3wpWA=; b=gmDYxfDJuwoGUFRwar6AhAYtQhu9APCregV0DBeAg+UasbRQETYWLtfFpHNizFs+Z4 vHnTPHze+7/3k6ewimLebKhphOK9r0BBILqUhSMy5cst3qFCVTSiuGTY5//mwiETHYsj u93BU+r5kgXb0/selziZIkPk1g6uqTs5IgnPswF8A1nQfek95s0dP4PIJbODJF1ii9Bl GtFmU2CI3ILO25eI9A6gPR/Wd5TzpdwRZowA46YirVaZm60j3Qpk5OGfCAnQQKARuHhK ZbWGtptnzV+XwOve5N2a41H3IWdS1X47PWp84WwL78pWRJJp/8HRD+MZNHkNAKDM+gwM jmIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b="Gh/Ts+Ax"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id z2-20020a656642000000b00573ff14b9e0si7853132pgv.763.2023.09.18.04.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 04:26:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b="Gh/Ts+Ax"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E6166801BCB1; Mon, 18 Sep 2023 03:08:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235542AbjIRKHi (ORCPT + 99 others); Mon, 18 Sep 2023 06:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241243AbjIRKH3 (ORCPT ); Mon, 18 Sep 2023 06:07:29 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 381CD123 for ; Mon, 18 Sep 2023 03:07:20 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-530ab2d9e89so2758220a12.2 for ; Mon, 18 Sep 2023 03:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695031638; x=1695636438; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3CIzAQBDBRAbXi6odnAuwsq+At6oBbxMnuT61WOfur8=; b=Gh/Ts+Axe0ftgk653P1e2h0uLTcgF41Q6cvPbxwrQVAXECl1OtdliVPm86cmvNo30z y0sOHaMQ1TDUfyIRT0uhLxeCif5Ew1F1UCoOGqaynDc01KicnMXvBmDKl/XSOi4hJ6CX X+b9MXfSF+uxFVN2yP3uG1oLQgdW6t5yjH4wbWWMMeYSt6i2g+8Gzx09sNtkwQcWoVYr KFbYeztQfyMfU/k8oV4OzQ5hVr1ps4bPDf7ALOp8S02oG+sQcqP30s2zwT98EogeneSl mowzI3hrpgaZgg/qUA3MccDGpx+BNfeZ9ycKI5LpSoPMBwgxvEI92mr5swVqnu8DNj8L CY6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695031638; x=1695636438; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3CIzAQBDBRAbXi6odnAuwsq+At6oBbxMnuT61WOfur8=; b=jIpzPCuGgP9CcS7Y5Qpo1xVLwJX1NnLaBJPyJszDJfwFSzwMIdV/P8uJGUHqpRVZD2 cIaq/UBSNAqY8F+TVgYN2nqAhHsOFiGftSycj1vnnrZdCmCUSA+ldkRIY90TjccVc5YJ 30DWVdxIHLMvShmwMbD5Pv/e42N9qMpdp1DSGH4Xhtd3eewsrM5iFNThWfIDMUWjEiDh IQ+oDqIRtEyrYLuRVWn+eO8oid5pd6KQpOMrv1ZbBqAuY7p24LtEDPdTs6ZTZDd9aKm7 upYJCqeaRLX1EAE4pTKjnJIkMwNxiqAH0iViv3yWv4cSbU3bPv7Uj0fxDrns/bB8ovXj RuMQ== X-Gm-Message-State: AOJu0YxbqiXSmI49EdKDSwGgAMgaIm0pM+0+A6mqy6+4X/9fjQnvu4Vi 80Crcayz7D2wiqej32TrPi6yvQ== X-Received: by 2002:a05:6402:3494:b0:531:28fd:ad10 with SMTP id v20-20020a056402349400b0053128fdad10mr1459070edc.38.1695031638376; Mon, 18 Sep 2023 03:07:18 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a246:8222:872:4a5b:b69c:1318]) by smtp.gmail.com with ESMTPSA id p21-20020aa7d315000000b00522828d438csm5824096edq.7.2023.09.18.03.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 03:07:17 -0700 (PDT) From: Markus Schneider-Pargmann To: Daniel Lezcano , "Rafael J . Wysocki" , Amit Kucheria , Zhang Rui , Matthias Brugger Cc: AngeloGioacchino Del Regno , Frank Wunderlich , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Markus Schneider-Pargmann , Frank Wunderlich Subject: [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2 Date: Mon, 18 Sep 2023 12:07:06 +0200 Message-Id: <20230918100706.1229239-1-msp@baylibre.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 03:08:22 -0700 (PDT) Fix the probe function to call mtk_thermal_release_periodic_ts for everything != MTK_THERMAL_V1. This was accidentally changed from V1 to V2 in the original patch. Reported-by: Frank Wunderlich Closes: https://lore.kernel.org/lkml/B0B3775B-B8D1-4284-814F-4F41EC22F532@public-files.de/ Reported-by: Daniel Lezcano Closes: https://lore.kernel.org/lkml/07a569b9-e691-64ea-dd65-3b49842af33d@linaro.org/ Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks") Signed-off-by: Markus Schneider-Pargmann --- drivers/thermal/mediatek/auxadc_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c index 843214d30bd8..8b0edb204844 100644 --- a/drivers/thermal/mediatek/auxadc_thermal.c +++ b/drivers/thermal/mediatek/auxadc_thermal.c @@ -1267,7 +1267,7 @@ static int mtk_thermal_probe(struct platform_device *pdev) mtk_thermal_turn_on_buffer(mt, apmixed_base); - if (mt->conf->version != MTK_THERMAL_V2) + if (mt->conf->version != MTK_THERMAL_V1) mtk_thermal_release_periodic_ts(mt, auxadc_base); if (mt->conf->version == MTK_THERMAL_V1) -- 2.40.1