Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp6111997rdb; Mon, 18 Sep 2023 04:49:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGHupOtjM5CVSpISYNgIJkZpxd4iN5MRIkbmWm+8Buo/7scJXvomzdl5b7SPu+6Zrr9Np0U X-Received: by 2002:a17:90a:d507:b0:269:55a2:952c with SMTP id t7-20020a17090ad50700b0026955a2952cmr5379774pju.40.1695037780044; Mon, 18 Sep 2023 04:49:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695037780; cv=none; d=google.com; s=arc-20160816; b=aT2LnUrMrWsX2nY71vyS8/IobHAZeIvAhr3vdiZ8h8JGph7H1ERxBJM/tXmSY5YKQK ONkudh8Y7182Wse+G23dpwIEJ4L/yE1Hc9FQswqIwHxmAuAVd6s3XCR7DV2/y559skKv ++QAZAr01bg1p//6ktWQtoZLNbKaW+EbqHsNZkxAtc+qxPpXzcWXsqAHFrQBbbUIbae9 EwiZsgQ/rGMh8zgyvBQNuUzGY/rqQbVrwzNsGS78OnvphxDQsRKgQfeH5GfMENfS5DH9 tVeDhlsZrGSLzxGki2WgtLxiW/cJQaQ6v3Pi/t/LK5EQ5/Rv3oqvw9tCBG9GoQ0RqRrG SWYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7jgBL4e0vUwRgBITYfpFeDeeleU3YaP+AbAvYzGxGI0=; fh=npjj6LvSnx8RCdCH2bNM1FezVsLhHrOV/2DsYd3hvK4=; b=hO8mkNexsy+Ia2Hh8W5azy7ej1W5M3DXqF3uNNI14bSh1TE9GXsrzwOwyskpaRojVV upDTCVd3xtpUP7ij8FqFqac4jTCHLeVhxc8GJtjnz96DLBh3kQItwcZBg/EdYxXY3WNI +Z9rbcV7Plnr6DmFK2uegYgnVdwS2fRGEvG5knjb4M37HBeldv6ug1aQcY0s9eC2ubMG 4hqFmxw3w5mRF9IFVaUmv62jDDvNs7EG8jYU9vTmIELv6zMWVRENWw0DyGfOLmkMQ9eJ 6CuwmShU0f7lVKWuOT9+LSK4rPZwyeqmlBIPv3aAJbpQHkjIbdWuIkNaZnrsYZe6ke0b c8WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Aq8BDUPT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id h184-20020a636cc1000000b00565dd108fd4si7569058pgc.115.2023.09.18.04.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 04:49:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Aq8BDUPT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 89E5A80BB9BA; Mon, 18 Sep 2023 04:42:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241637AbjIRLlz (ORCPT + 99 others); Mon, 18 Sep 2023 07:41:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241701AbjIRLlj (ORCPT ); Mon, 18 Sep 2023 07:41:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C80DFB3; Mon, 18 Sep 2023 04:41:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3F2FC433C7; Mon, 18 Sep 2023 11:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695037293; bh=k5whRDb703pFSoW6vBuZiC/uLzAA5qCrmwIb0niMTaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Aq8BDUPTeZUbSi6r80BUN/6MwH1BAmiHYY4SHfZ7onFlzdMGfEKZJql8eJgFd8kcU VSUGCximU6yLeulyz9sCP0KhTKpgfeEuARR1qg4bJb/2c3E2+Aaq/FI7E9KE3mXGPA mMkzDccqY/MfireMOZxTAFoqx04P3/eEENahXkm++IxXno8NknhrffAlyV8usX4nkg fRFkfnnveLguRIcv9+LTO4c7dt1uE+rem3E3BlUrXtrNJpo5JMLyLk57Bw4w+y0H+Q CpPUMugfzFQ2rqTkkxwCEL03tDYtT39/xBNsmqTbEmsL2yuFfD5IL+86z+BlChrW+f YsxfJTuf+MXoQ== Date: Mon, 18 Sep 2023 14:41:29 +0300 From: Leon Romanovsky To: Christoph Hellwig Cc: Christian Brauner , Al Viro , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Fenghua Yu , Reinette Chatre , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Dennis Dalessandro , Tejun Heo , Trond Myklebust , Anna Schumaker , Kees Cook , Damien Le Moal , Naohiro Aota , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org, linux-hardening@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 06/19] qibfs: use simple_release_fs Message-ID: <20230918114129.GA103601@unreal> References: <20230913111013.77623-1-hch@lst.de> <20230913111013.77623-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913111013.77623-7-hch@lst.de> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 18 Sep 2023 04:42:34 -0700 (PDT) On Wed, Sep 13, 2023 at 08:10:00AM -0300, Christoph Hellwig wrote: > qibfs currently has convoluted code to allow registering HCAs while qibfs > is not mounted and vice versa. Switch to using simple_release_fs every > time an entry is added to pin the fs instance and remove all the boiler > plate code. > > Signed-off-by: Christoph Hellwig > --- > drivers/infiniband/hw/qib/qib.h | 4 +- > drivers/infiniband/hw/qib/qib_fs.c | 105 ++++++--------------------- > drivers/infiniband/hw/qib/qib_init.c | 32 +++----- > 3 files changed, 36 insertions(+), 105 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky