Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Mon, 18 Sep 2023 13:38:11 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Jinjie Ruan <ruanjinjie@huawei.com>
CC:     <sj@kernel.org>, <akpm@linux-foundation.org>,
        <brendan.higgins@linux.dev>, <damon@lists.linux.dev>,
        <linux-mm@kvack.org>, <kunit-dev@googlegroups.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND 2/2] mm/damon/core-test: Fix memory leak in
 damon_new_ctx()
Message-ID: <ZQfiQ/xGy4396N9A@feng-clx>
References: <20230918051044.3814018-1-ruanjinjie@huawei.com>
 <20230918051044.3814018-3-ruanjinjie@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230918051044.3814018-3-ruanjinjie@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gd4Il06anZ/g1SSXtqgIFVGTh/q7YRygGZo41kijfAWzX8RxdrDMNLTquu7e?=
 =?us-ascii?Q?4y4Og9Vn+1kKyaXPPZYuozJbA3lwhWRowWxnuxqhXzSDX5pAwTvUnyH7tpf1?=
 =?us-ascii?Q?WSarj/MFOnVNbpvXVq+2KN85bJg8uulm6PI9YBpzpkt0paArCv/gu6VY/TJT?=
 =?us-ascii?Q?PNaU3X6dALiwGzRzg2h7UmjLjiuaox8mbT+FHdLkchpFnMOUI1F8f26LP98V?=
 =?us-ascii?Q?YMVabAlgLjHwG65zrnVy5VlisRhL7Ue5Wa2SWu0xA7aZafjaboofYCSfRGNa?=
 =?us-ascii?Q?cJj8jkT1qeeiZ3EyHCDOR0xYYOz+JIHQZLkNHY/72GfZAYMKryrc/R7tVgwE?=
 =?us-ascii?Q?sTNiqSl+Nkdx1H/Dc9VUNaitbSP7Ns6rgX2Y8i0LgKCWXb4QDZ/LpUF3/2Zj?=
 =?us-ascii?Q?/+DlB9O6rrLn6E4Q+KIBLc6UfT0ZQ4HIT6wXGteVtpsUtB+vbzh3F+KKnciz?=
 =?us-ascii?Q?88tsxLGJl6Fy9b8D/tMIrI6cmCssOHCVAZRzIR9PjzR9zRZrdvZ0BXXbEaSM?=
 =?us-ascii?Q?YLB7WOZ2Tb9Ohmyh7jc7CVhViIQo02vI6xcFWT1S87uHFcCKhVOC4fI2JcZh?=
 =?us-ascii?Q?ynQKBLMhONlok0x1r3m6SMg29Uz0FCbaRj0MIItjxAisUqT2LPdKtB62r7iq?=
 =?us-ascii?Q?fQliVfBoXHlPRP8SP2fFlYNABDL/4BQ3OtAD2yy8uBOwRL2MQfPWSuKUA2Rz?=
 =?us-ascii?Q?MJj5qZqEHLQrnsFOIUf+niyMFHpYbysOTpLy61PBtnfLVLW2bS0VpextfV1X?=
 =?us-ascii?Q?QMn6WeRTpjnnsmrgpszmHKqBNOhysBvMXigv7nUvzL1TN0qcKMjHJL1INAgc?=
 =?us-ascii?Q?eXl+KyAQ6rzlQr5vJ7ycFg0rdvUiM7C9CghqCPfI/bkDs/DEpyStlfi4/78j?=
 =?us-ascii?Q?ja3Pds6FDM44IGHA3ZA2ztorcDc4PnAOYmcAQfc8JjVx07Hxtv/ClFqiHV4Z?=
 =?us-ascii?Q?ymcIjzqJk66IROsy8ErtgTjnHxGutOxRInsb6cpagRlUT3VIOfpLnrfsMWo+?=
 =?us-ascii?Q?jESmzgsNzp1zGnuH3E1VnZ1J6uoiO77FSculUX6fBb9JuXcqqGvQpQpEkra5?=
 =?us-ascii?Q?parGE5uoDSS4GDNQwsu2LNZGnLew4E1oLx8BzpPaqRr42in7rE/tr+X4RCRl?=
 =?us-ascii?Q?pNG4/YYi2ugXCigWTus2TKDVbIv7Pq9nefvHcdrG+egpKRJrBfyuvhPkjm/0?=
 =?us-ascii?Q?r21++JKN6WXny3bDv/GBheComLHY3AhREio4pHBCuE2YJrRsF+WYEr+wIPo3?=
 =?us-ascii?Q?rt0/egOS7gP7EajvTFjzUxiAKsMa2tM5rUueLWSxU0wt1bnkn+iTWt0nq4nh?=
 =?us-ascii?Q?nVBjZ84EYyheXjG3tEBLBaB7U1yhKfXPxYNtuwwa+BG0hkmsrUS4rYdpF2iD?=
 =?us-ascii?Q?9wSRW5RutuJ24rhRJ/eKtWMJdMm+htqXU7JwXFst5/XHTeqXhVIwYbaPJ1GL?=
 =?us-ascii?Q?v1y9VmncXhvNxpKv9MtOrJ1hm40Me/EC6CCnklQ5WOfbyBj7G6zPJVgRHSzx?=
 =?us-ascii?Q?FgiKpC5qfeiL1kAIH4uTuSTvte4xYISbKgWtusbZR0Hx9+lYIse4naE3cq5e?=
 =?us-ascii?Q?X3XsdkrUZDUsf+VYnJ0yltBbIH+bIK+dHaLai1vh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11c32f8f-3113-4b16-ee74-08dbb80ac448
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 05:47:39.4220
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r+Ejd9vyctEiKCy7DI0VySZ2qUXLubpnGFFP1uYcJNUh2x7Sj6+Swjh7tCBslSqRvgnunaBXRtrJ5gDfiGTyWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6999
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 17 Sep 2023 22:50:55 -0700 (PDT)

On Mon, Sep 18, 2023 at 01:10:44PM +0800, Jinjie Ruan wrote:
> The damon_ctx which is allocated by kzalloc() in damon_new_ctx() in
> damon_test_ops_registration() and damon_test_set_attrs() are not freed and
> it causes below memory leak. So use damon_destroy_ctx() to free it.
> 
> unreferenced object 0xffff2b49c6968800 (size 512):
>   comm "kunit_try_catch", pid 350, jiffies 4294895294 (age 557.028s)
>   hex dump (first 32 bytes):
>     88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00  ................
>     00 87 93 03 00 00 00 00 0a 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368
>     [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290
>     [<00000000b5f89cef>] kmalloc_trace+0x40/0x164
>     [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4
>     [<00000000daf6227b>] damon_test_ops_registration+0x34/0x328
>     [<00000000559c4801>] kunit_try_run_case+0x50/0xac
>     [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c
>     [<000000003c3e9211>] kthread+0x124/0x130
>     [<0000000028f85bdd>] ret_from_fork+0x10/0x20
> unreferenced object 0xffff2b49c1a9cc00 (size 512):
>   comm "kunit_try_catch", pid 356, jiffies 4294895306 (age 557.000s)
>   hex dump (first 32 bytes):
>     88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368
>     [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290
>     [<00000000b5f89cef>] kmalloc_trace+0x40/0x164
>     [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4
>     [<00000000058495c4>] damon_test_set_attrs+0x30/0x1a8
>     [<00000000559c4801>] kunit_try_run_case+0x50/0xac
>     [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c
>     [<000000003c3e9211>] kthread+0x124/0x130
>     [<0000000028f85bdd>] ret_from_fork+0x10/0x20
> 
> Fixes: d1836a3b2a9a ("mm/damon/core-test: initialise context before test in damon_test_set_attrs()")

Thanks for the fix!

Reviewed-by: Feng Tang <feng.tang@intel.com>

> Fixes: 4f540f5ab4f2 ("mm/damon/core-test: add a kunit test case for ops registration")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>  mm/damon/core-test.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h
> index 255f8c925c00..ce86ed30fb47 100644
> --- a/mm/damon/core-test.h
> +++ b/mm/damon/core-test.h
> @@ -266,6 +266,8 @@ static void damon_test_ops_registration(struct kunit *test)
>  
>  	/* Check double-registration failure again */
>  	KUNIT_EXPECT_EQ(test, damon_register_ops(&ops), -EINVAL);
> +
> +	damon_destroy_ctx(c);
>  }
>  
>  static void damon_test_set_regions(struct kunit *test)
> @@ -342,6 +344,8 @@ static void damon_test_set_attrs(struct kunit *test)
>  	invalid_attrs = valid_attrs;
>  	invalid_attrs.aggr_interval = 4999;
>  	KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL);
> +
> +	damon_destroy_ctx(c);
>  }
>  
>  static void damos_test_new_filter(struct kunit *test)
> -- 
> 2.34.1
>