Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <f803a588-f9a5-99fb-7c6f-b375d6ec7460@redhat.com>
Date:   Mon, 18 Sep 2023 13:28:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1 4/4] mm/ksm: document pages_skipped sysfs knob
Content-Language: en-US
To:     Stefan Roesch <shr@devkernel.io>, kernel-team@fb.com
Cc:     akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <20230912175228.952039-1-shr@devkernel.io>
 <20230912175228.952039-5-shr@devkernel.io>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230912175228.952039-5-shr@devkernel.io>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12.09.23 19:52, Stefan Roesch wrote:
> This adds documentation for the new metric pages_skipped.
> 
> Signed-off-by: Stefan Roesch <shr@devkernel.io>
> ---
>   Documentation/admin-guide/mm/ksm.rst | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
> index 1762219baf51..27d949250b67 100644
> --- a/Documentation/admin-guide/mm/ksm.rst
> +++ b/Documentation/admin-guide/mm/ksm.rst
> @@ -178,6 +178,8 @@ pages_unshared
>           how many pages unique but repeatedly checked for merging
>   pages_volatile
>           how many pages changing too fast to be placed in a tree
> +pages_skipped
> +        how many pages did the "smart" page scanning algorithm skip
>   full_scans
>           how many times all mergeable areas have been scanned
>   stable_node_chains

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb