Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp6142984rdb; Mon, 18 Sep 2023 05:37:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGj/O6RFufntdf+2+I8R1dp6QI6l8BVVM5nxY0zlv80HfctsKfsb+40SrLSXkBzMKbyHLUH X-Received: by 2002:a05:6a20:6a20:b0:15a:290:d82e with SMTP id p32-20020a056a206a2000b0015a0290d82emr8843365pzk.52.1695040635770; Mon, 18 Sep 2023 05:37:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695040635; cv=none; d=google.com; s=arc-20160816; b=S4p3VG1/CVgJ9xybwaRG4la6QPK5Ev5/wX0Vufgcq+X4eKT5jRazEbOZydAgSq0zAM 10s05YtCkMNQdVFUJh8VWDjgkZXPTJFn5eDm50BI0d3HCOuny5/6SVKvlTQnbIwv37g3 UnrTbPDIWXmQQ2cA6uuKjL/fM/2ICnmfGu/kxuNA/cY5BBSBagoX9DpN0+pt4sWimGM9 fT6xIVSPLv9VzsPw99GXtXHMmjb7lkfsqrIm6X5xvrbsXzNeJHuCYhHek0JXklN+3vj2 ihNmG/ybJeETTA4rVG3LjasaRS7r3gYadfKzTMwj4pHn+O1G/q/gddR4ApLA6KIfmn5m w1gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=A8oW/LuF1hUY3LGSfcPptaQqpzk2mJwUOL6iBz7fW1s=; fh=sWH11FnHMfCkHSU9kXlYjtdyZVAjuuR7mMUGHavtm3Q=; b=eQzEo6tLzUQx7uPQ8laQavsj7086spvQ+5M2qqKtkh4IFqVSSfNI+BEyarWiG2eUcI RrEGCT/Ci+fNBwWB+B9Af2Zd6Cmcd/HbgE+U4uPxJH2RrLmb/nNwdvFCUV8IkAnx8iGL sBz/QJbdTRin6/+SWB0KI/pMcRYqWgmU3QzctuHhrcgMlDxQ7uy25bqICmSh4So2iql5 Vmu95sYRQKgvZgWiQVQpZwS8nifRhM92hsQcW+8ssiIaoA7sWSUfWGlDiBqhO+jMsKgp ZcSR+s/63FtKaFuVzL8SDQvrmPctXmC2FhZvZgSFIMMG5GBsJn+TTePN90qXRfaSjlYQ VEYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id x63-20020a636342000000b00565f4166f4bsi7980276pgb.284.2023.09.18.05.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 05:37:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id E2F3681ADCC6; Mon, 18 Sep 2023 05:25:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241947AbjIRMYt (ORCPT + 99 others); Mon, 18 Sep 2023 08:24:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241986AbjIRMYc (ORCPT ); Mon, 18 Sep 2023 08:24:32 -0400 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 063239F; Mon, 18 Sep 2023 05:24:21 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,156,1688396400"; d="scan'208";a="176397777" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 18 Sep 2023 21:24:21 +0900 Received: from localhost.localdomain (unknown [10.226.92.107]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 96B8141F6ACF; Mon, 18 Sep 2023 21:24:18 +0900 (JST) From: Biju Das To: Thomas Gleixner , Marc Zyngier Cc: Biju Das , Lad Prabhakar , Claudiu Beznea , Geert Uytterhoeven , Biju Das , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH 1/3] irqchip: renesas-rzg2l: Fix logic to clear TINT interrupt source Date: Mon, 18 Sep 2023 13:24:09 +0100 Message-Id: <20230918122411.237635-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230918122411.237635-1-biju.das.jz@bp.renesas.com> References: <20230918122411.237635-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 18 Sep 2023 05:25:22 -0700 (PDT) The logic to clear the TINT interrupt source in rzg2l_irqc_irq_disable() is wrong as the mask is correct only for LSB on the TSSR register. This issue is found when testing with two TINT interrupt sources. So fix the logic for all TINTs by using the macro TSSEL_SHIFT() to multiply tssr_offset with 8. Fixes: 3fed09559cd8 ("irqchip: Add RZ/G2L IA55 Interrupt Controller driver") Signed-off-by: Biju Das Tested-by: Claudiu Beznea --- drivers/irqchip/irq-renesas-rzg2l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c index 4bbfa2b0a4df..2cee5477be6b 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -118,7 +118,7 @@ static void rzg2l_irqc_irq_disable(struct irq_data *d) raw_spin_lock(&priv->lock); reg = readl_relaxed(priv->base + TSSR(tssr_index)); - reg &= ~(TSSEL_MASK << tssr_offset); + reg &= ~(TSSEL_MASK << TSSEL_SHIFT(tssr_offset)); writel_relaxed(reg, priv->base + TSSR(tssr_index)); raw_spin_unlock(&priv->lock); } -- 2.25.1