Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp6150854rdb; Mon, 18 Sep 2023 05:52:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQO5G6yT37KXetbqirz2xiT2Mnwqo8WX4qbiPNmJoAsRFLiM5GNMxlSzLdFjc1MzskYc1j X-Received: by 2002:a05:6808:193:b0:3a7:94d3:43fe with SMTP id w19-20020a056808019300b003a794d343femr10489927oic.30.1695041520190; Mon, 18 Sep 2023 05:52:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695041520; cv=none; d=google.com; s=arc-20160816; b=yvPuqRMLIr5mAuVpjXA4qEmV9La1MQGcVfYP1VNscrPOZDhb3FFr7ZduhldctZ4Lxl PRkIQ+3GDP/Ao+eRr5AVrvuYcbzeHV6Dw2F1otK3zJe2rcG94u+Wu/D2g0MnFPdABV+/ gMBmexuTNFIuv1aCNjIN8XKad2G33Pr0vRnttvYVkpEIxZjdjnS+D4zenYHK2x1OP5ri hEjyUArtGsvlasN596f9apo/vgElkfR1G9e9yy+et8lf0oayrDl6JiOsB1duXC+wW9SW albsAc9SvdMVJqiBmgOCtJlSB8xgm5EYxVYZmqJQM/2fRs5tfzZChPGhLkZe+iOOTAEg KpZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DbysLQZwnNazA0BrL/i+qSYFjrcNMe0RpmPtljzV13s=; fh=oXM0czg5SoYo10QBFe6o6qkfMZH0o1pTeg/E2Uw/9D8=; b=QFHdC50MfCP7Cw7UYxpTp9bE6++a+z5ZsN+JEQFPxXFuSbY9JDynvhv5x5PL+8428L ZzNBaNvbFVpNDmESrlxXsstHyUn2tOFgiRgSwwTz87zhh4bYzyFbs/eldZ/IvjtADzCw xnzxHeAxOOX+CotFKY+0Tm+zTWRFII7UI+3HjVE/njegVrIVfVRN7YtdqeV8Rv96ed5n dLlJqod/6kyXxmxyyCZ8K6ABJkvwzzipKLw3OEgA1mb0/jBIDThtUv3QNj+611345z6a +ziEPB1+iNaM+XC75Q1TMSBSZL6fZmSa8nPdWv1LfYinEg0YpbvwIX05RNFbumX1GEy3 N+YA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id 32-20020a630d60000000b0056b83e0ae92si7805638pgn.465.2023.09.18.05.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 05:52:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 9F37B807F4DB; Mon, 18 Sep 2023 05:35:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241468AbjIRMe5 (ORCPT + 99 others); Mon, 18 Sep 2023 08:34:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241517AbjIRMep (ORCPT ); Mon, 18 Sep 2023 08:34:45 -0400 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D5272E4C; Mon, 18 Sep 2023 05:34:06 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,156,1688396400"; d="scan'208";a="176398360" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 18 Sep 2023 21:34:06 +0900 Received: from localhost.localdomain (unknown [10.226.92.107]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id E14174005E22; Mon, 18 Sep 2023 21:34:02 +0900 (JST) From: Biju Das To: Linus Walleij Cc: Biju Das , Geert Uytterhoeven , Claudiu Beznea , Lad Prabhakar , Marc Zyngier , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, Biju Das Subject: [PATCH 1/2] pinctrl: renesas: rzg2l: Make reverse order of enable() for disable() Date: Mon, 18 Sep 2023 13:33:54 +0100 Message-Id: <20230918123355.262115-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230918123355.262115-1-biju.das.jz@bp.renesas.com> References: <20230918123355.262115-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 18 Sep 2023 05:35:36 -0700 (PDT) We usually do reverse order of enable() for disable(). Currently, the ordering of irq_chip_disable_parent() is not correct in rzg2l_gpio_irq_disable(). Fix the incorrect order. Fixes: db2e5f21a48e ("pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO interrupt") Signed-off-by: Biju Das Tested-by: Claudiu Beznea --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index 37cdfe4b04f9..2ea6ef99cc70 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -1175,6 +1175,8 @@ static void rzg2l_gpio_irq_disable(struct irq_data *d) u32 port; u8 bit; + irq_chip_disable_parent(d); + port = RZG2L_PIN_ID_TO_PORT(hwirq); bit = RZG2L_PIN_ID_TO_PIN(hwirq); @@ -1189,7 +1191,6 @@ static void rzg2l_gpio_irq_disable(struct irq_data *d) spin_unlock_irqrestore(&pctrl->lock, flags); gpiochip_disable_irq(gc, hwirq); - irq_chip_disable_parent(d); } static void rzg2l_gpio_irq_enable(struct irq_data *d) -- 2.25.1