Received: by 2002:ac8:7144:0:b0:40f:fb00:664b with SMTP id h4csp1886489qtp; Mon, 18 Sep 2023 07:04:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGh1SBQor50mWcDeQl+LvFZ7wnHj9X0FsTzdO9KzjurdiwC9s8RR4Y2/BIoTNe618c9Ksjd X-Received: by 2002:a05:6a20:1007:b0:158:2031:9a0a with SMTP id gs7-20020a056a20100700b0015820319a0amr7360498pzc.32.1695045893734; Mon, 18 Sep 2023 07:04:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695045893; cv=none; d=google.com; s=arc-20160816; b=sz5bjTPaKR0ZIIZPhSSSivlvr1Hc/SrKj2uAe++nxd2eMNPU6+dsny63kTuFoWeZRH VgTDhtEWcFI3GZJhP1Lf3Q98tf2BnGDqc3qopuwx3jhRHtD8COu/4OuukV7Fstz/ULf1 jYrGXEBWNuTra6fG5LWNZ2eRH+Q/WF8+tVOHs1ACJevGmBpcuPfq/vwdSWXF5nSEj0Gz fqhSX//aodDS1AGMSUUPFd0ALAcybayY91io+upIwmrIB7NwUbVOhobqL4d+ZsUDEyln /rxUhSX/sXFi3X6OE+m7wscs3ljH7LJLIlQ9j07kY7+z5ackz7nUDdTwpUFIcwyokX2b cu0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=fE9zhEHg7Ff1TIIzy8crm7OARMfmzExyLqxHdSZc9JU=; fh=TTnV3erw10hqRsdQyo8FPCil6ndQrD3hEQgdZMfz9fs=; b=GmSHzsRTJqYPDROthqJM3DjVwwgyS41ZJbMYHH1tXeVxJzJv9edLdli2Y65m6sZCGm VKQSRZC+A8YTpNZxlJWRTHqT7AV8N+/GhyxSqSIs3Nb8cNZSWE5G93wRzHdxsvEeKRV2 F15iZkwwAc5iROMJledBslC9npsmqIxZEPqYi2UxK4LAAfAv/MvoXkMKEaSLvz1GFHwM 0WukEA4yZ5xMRqE9FqeApfE4x3FziAudUuonYFKCx2DJJge4wo8+5WVkwZygEZsIOSAp rZWlN4hfMyGjIMuuchyEZStF3Ej2lJgY/WprzEYyHyAszZj6QcJea3LMmSpy5O1sE6g0 9s+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=F+7HQI2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id ct25-20020a056a000f9900b0065b4e2b52c5si7866627pfb.196.2023.09.18.07.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 07:04:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=F+7HQI2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 39763810AF7B; Sun, 17 Sep 2023 14:15:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231953AbjIQVOv (ORCPT + 99 others); Sun, 17 Sep 2023 17:14:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231951AbjIQVO0 (ORCPT ); Sun, 17 Sep 2023 17:14:26 -0400 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1219012A for ; Sun, 17 Sep 2023 14:14:21 -0700 (PDT) Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-d7b91422da8so3643547276.2 for ; Sun, 17 Sep 2023 14:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694985260; x=1695590060; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fE9zhEHg7Ff1TIIzy8crm7OARMfmzExyLqxHdSZc9JU=; b=F+7HQI2hYDV4Uocc9TJgAWRbogODOqjZrPwJ0+O0RovAEZ3xleVkmaFiaU4FHPshzs M/WZMA0vCIB1518QE6iH2ohZMq5Hv4c176DVv/VI2kEnLH3X5zdIW/k18Y+/S6If0nCP Lsi3P1ErEfPFzqiUpAfP9FxUumbeFwARDltI0rbb/412rwwTRijt3Uy0N3kJnwWAoS8w Bc7uLm3yQXH16Tjrvpj9g6HAMi+LIBgD6Ms7DRhhwlWFB7b+HazJsvHAdejj997HyhLN 9UyS76lbgm3F4PZt+mUmPGvzUWZ6250Mg+Uc+0PxAfsIbLwt/L51JHsmXT7DYuX100ys 20Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694985260; x=1695590060; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fE9zhEHg7Ff1TIIzy8crm7OARMfmzExyLqxHdSZc9JU=; b=JPaJYHuuRluiw+4xwvog5R/9R8PKaeSE6sdVmqbO87Ds2avmGq5VHABu3lBg6+6Xel FCcflsTCz3tD3zQZm3J+8LuEP0clBAQuuzyqo2MvU9mVAruw7aSjcZV09827BlQouIyM 1UOUY6uZw8CTqzdl4K3ELWLHabmQrSZO2MM6PQyaopWyceuB4qnpyywCHDgtxmf19Dsg v3ON5ezSlPKsduAo2MsvIvbrrMw3flwlnzBHHur4tEufUbcEm3gm16a7lBvVae3zLzcM wbwj5xFdgGttoP1qGqmKw65vOELWHTDWjveez3hSUV9z8pXzNtvMu0T5LFZ7/4TvYG67 tuTw== X-Gm-Message-State: AOJu0Ywtm8/hxO2iuth7letgneTf9mWVVW3cA38rWzguIEh3TR14YJPF rS3G+gMDgnqKZC5+wr+R+gjgxDo76nS2cn93gnXoyw== X-Received: by 2002:a25:dc8a:0:b0:d0e:b5c8:6359 with SMTP id y132-20020a25dc8a000000b00d0eb5c86359mr6726072ybe.55.1694985260079; Sun, 17 Sep 2023 14:14:20 -0700 (PDT) MIME-Version: 1.0 References: <20230915172818.761-1-shiju.jose@huawei.com> In-Reply-To: <20230915172818.761-1-shiju.jose@huawei.com> From: Jiaqi Yan Date: Sun, 17 Sep 2023 14:14:06 -0700 Message-ID: Subject: Re: [RFC PATCH 0/9] ACPI:RASF: Add support for ACPI RASF, ACPI RAS2 and configure scrubbers To: shiju.jose@huawei.com Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, tony.luck@intel.com, james.morse@arm.com, dave.hansen@linux.intel.com, david@redhat.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, rientjes@google.com, duenwen@google.com, Vilas.Sridharan@amd.com, mike.malvestuto@intel.com, gthelen@google.com, linuxarm@huawei.com, jonathan.cameron@huawei.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 17 Sep 2023 14:15:48 -0700 (PDT) On Fri, Sep 15, 2023 at 10:29=E2=80=AFAM wrote: > > From: Shiju Jose > > This series add, > 1. support for ACPI RASF(RAS feature table) PCC interfaces > to communicate with the HW patrol scrubber in the platform, > as per ACPI 5.1 & upwards revision. Section 5.2.20. > > 2. support for ACPI RAS2(RAS2 feature table), as per > ACPI 6.5 & upwards revision. Section 5.2.21. > > 3. scrub driver supports configuring parameters of the memory > scrubbers in the system. This driver has been implemented > based on the hwmon subsystem. > > The features have tested with RASF and RAS2 emulation in the QEMU. I am very curious how the test is done. Does the hw patrol scrubber on host actually been driven by the driver to scrub memory DIMMs (doesn't seem so to me, but do correct me)? Or it is like to a VM scrubbing is simulated and no real op to DIMMs? > > Previous references to the memory scub and RASF topics. > https://lore.kernel.org/all/20221103155029.2451105-1-jiaqiyan@google.com/ > https://patchwork.kernel.org/project/linux-arm-kernel/patch/CS1PR84MB0038= 718F49DBC0FF03919E1184390@CS1PR84MB0038.NAMPRD84.PROD.OUTLOOK.COM/ > > A Somasundaram (2): > ACPI:RASF: Add extract RASF table to register RASF platform devices > ACPI:RASF: Add common library for RASF and RAS2 PCC interfaces > > Shiju Jose (7): > memory: scrub: Add scrub driver supports configuring memory scrubbers > in the system > memory: scrub: sysfs: Add Documentation entries for set of scrub > attributes > Documentation/scrub-configure.rst: Add documentation for scrub driver > memory: RASF: Add memory RASF driver > ACPICA: ACPI 6.5: Add support for RAS2 table > ACPI:RAS2: Add driver for ACPI RAS2 feature table (RAS2) > memory: RAS2: Add memory RAS2 driver > > .../ABI/testing/sysfs-class-scrub-configure | 82 ++++ > Documentation/scrub-configure.rst | 55 +++ > drivers/acpi/Kconfig | 15 + > drivers/acpi/Makefile | 1 + > drivers/acpi/ras2_acpi.c | 97 ++++ > drivers/acpi/rasf_acpi.c | 71 +++ > drivers/acpi/rasf_acpi_common.c | 272 +++++++++++ > drivers/memory/Kconfig | 15 + > drivers/memory/Makefile | 3 + > drivers/memory/ras2.c | 334 +++++++++++++ > drivers/memory/rasf.c | 335 +++++++++++++ > drivers/memory/rasf_common.c | 251 ++++++++++ > drivers/memory/scrub/Kconfig | 11 + > drivers/memory/scrub/Makefile | 6 + > drivers/memory/scrub/memory-scrub.c | 452 ++++++++++++++++++ > include/acpi/actbl2.h | 55 +++ > include/acpi/rasf_acpi.h | 59 +++ > include/memory/memory-scrub.h | 85 ++++ > include/memory/rasf.h | 82 ++++ > 19 files changed, 2281 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-class-scrub-configure > create mode 100644 Documentation/scrub-configure.rst > create mode 100755 drivers/acpi/ras2_acpi.c > create mode 100755 drivers/acpi/rasf_acpi.c > create mode 100755 drivers/acpi/rasf_acpi_common.c > create mode 100644 drivers/memory/ras2.c > create mode 100644 drivers/memory/rasf.c > create mode 100644 drivers/memory/rasf_common.c > create mode 100644 drivers/memory/scrub/Kconfig > create mode 100644 drivers/memory/scrub/Makefile > create mode 100755 drivers/memory/scrub/memory-scrub.c > create mode 100755 include/acpi/rasf_acpi.h > create mode 100755 include/memory/memory-scrub.h > create mode 100755 include/memory/rasf.h > > -- > 2.34.1 >