Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <ed222918-68ca-cb57-15b8-57f45cdb5a5b@linaro.org>
Date:   Mon, 18 Sep 2023 14:11:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Add Richtek rtq9128 audio
 amplifier
Content-Language: en-US
To:     cy_huang@richtek.com, Mark Brown <broonie@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Allen Lin <allen_lin@richtek.com>, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1695030341-20711-1-git-send-email-cy_huang@richtek.com>
 <1695030341-20711-2-git-send-email-cy_huang@richtek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <1695030341-20711-2-git-send-email-cy_huang@richtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/09/2023 11:45, cy_huang@richtek.com wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
> 
> Create richtek,rtq9128.yaml for rtq9128 amplifier.
> 
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
>  .../bindings/sound/richtek,rtq9128.yaml       | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml b/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml
> new file mode 100644
> index 000000000000..a79694c2b169
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license is needed. Just like checkpatch is asking for.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/richtek,rtq9128.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Richtek RTQ9128 Automative Audio Power Amplifier
> +
> +maintainers:
> +  - ChiYuan Huang <cy_huang@richtek.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The RTQ9128 is a ultra-low output noise, high-efficiency, four-channel
> +  class-D audio power amplifier and delivering 4x75W into 4OHm at 10%
> +  THD+N from a 25V supply in automotive applications.
> +

Missing ref to dai common.

> +properties:
> +  compatible:
> +    enum:
> +      - richtek,rtq9128
> +
> +  reg:
> +    maxItems: 1
> +
> +  enable-gpios:
> +    maxItems: 1
> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#sound-dai-cells'
> +
> +unevaluatedProperties: false

This goes with mentioned $ref. Alone would not be correct.


Best regards,
Krzysztof