Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Mon, 18 Sep 2023 15:03:45 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Charles Han <hanchunchao@inspur.com>, <corbet@lwn.net>,
        <djwong@kernel.org>, <dchinner@redhat.com>,
        <allison.henderson@oracle.com>, <bhelgaas@google.com>
Cc:     <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] Documentation: xfs: Remove duplicate 'the' in
 transaction sequence process
Message-ID: <ZQgEYU71YE6Jv38D@debian.me>
References: <20230918074054.313204-1-hanchunchao@inspur.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cwMqc1Pn7DQDXQN0"
Content-Disposition: inline
In-Reply-To: <20230918074054.313204-1-hanchunchao@inspur.com>
Precedence: bulk


--cwMqc1Pn7DQDXQN0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 18, 2023 at 03:40:54PM +0800, Charles Han wrote:
> Remove the repeated word "the" in comments.

Patch title looks OK but in this case, the patch description should also ma=
tch.
Hint: there is no code comments in the doc below.

>=20
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
>  Documentation/filesystems/xfs-online-fsck-design.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Docum=
entation/filesystems/xfs-online-fsck-design.rst
> index 1625d1131093..a0678101a7d0 100644
> --- a/Documentation/filesystems/xfs-online-fsck-design.rst
> +++ b/Documentation/filesystems/xfs-online-fsck-design.rst
> @@ -1585,7 +1585,7 @@ The transaction sequence looks like this:
>  2. The second transaction contains a physical update to the free space b=
trees
>     of AG 3 to release the former BMBT block and a second physical update=
 to the
>     free space btrees of AG 7 to release the unmapped file space.
> -   Observe that the the physical updates are resequenced in the correct =
order
> +   Observe that the physical updates are resequenced in the correct order
>     when possible.
>     Attached to the transaction is a an extent free done (EFD) log item.
>     The EFD contains a pointer to the EFI logged in transaction #1 so tha=
t log

Regardless, wait for one or few days before rerolling this patch with
reviews addressed. It allows other reviewers to catch up and review. You can
also Cc: me if you'd like.

See you in v3!

--=20
An old man doll... just what I always wanted! - Clara

--cwMqc1Pn7DQDXQN0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZQgEYQAKCRD2uYlJVVFO
o6vTAQDsti7y+n/hNMzhITP6F/5YrQQAP/ozJb9QCW5P3p5UFQD+NILb5c69nOGo
bm2NhOTRMNGup0xBvPJeGt57WaCLzAY=
=HhT0
-----END PGP SIGNATURE-----

--cwMqc1Pn7DQDXQN0--