Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp125931rdb; Mon, 18 Sep 2023 09:57:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1lYmeC5QPE3aZ9sy4fngCi5R3J7qDtebwX3dZ8GcuJv9w+BQKGVnIcYDzPeMk8bOm7mgu X-Received: by 2002:a17:90b:1e10:b0:269:5b17:24b6 with SMTP id pg16-20020a17090b1e1000b002695b1724b6mr7089382pjb.9.1695056258761; Mon, 18 Sep 2023 09:57:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695056258; cv=none; d=google.com; s=arc-20160816; b=YyEDlwM3QAeBWmD8ph6Ue0GeebHSygXC3bpqIT/R0TRllNBFqh0/HF2sAItsI2dJ4y h6ePSMXiyIBGBGhFWwSkG19V9CxoNhnTWKqqg8xnOZqGOwar7fH8fILWlzDexlRtx6y9 Ue67QeGoGjg7kL1Mz5e8DfrMTkM7gDT4DpqglSxUtWKxALaES6inzhirxj6UoGBqCPAq pBEu1SrumEcSqJafG5ge3Ja1H9eGZhSA3ABQODv/WF1Q2G7Rfunckr6VZa+NE/F/r5PB /CBEHbHXw7oqGPdxiaXiEGqZrBy4cIzcVpijyWdhn0km8B8rWf+MTt3bLdRqQLfbJ/n2 SAog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=YijRwwaTOXls+uoPCh4WdLFGXo6KhUSNg1fL6tUyKEM=; fh=jVc1z13O+UJEKaefJgoxyuMVWe59p5pCQbqtFbyZTW4=; b=DoisU6LRPjvuZ8r79SBwNPGFn0YOYC9ukHlHWIzfDYachsx5YYw9jNIvhCqUo8jmnn zpwDuPtHcDcxhAwglB3N4GH+QicC4Pnk/+1Mq9BGZ1NCzFNnurIbMmH9f2NdtEcxIOn4 wEGR8YbkGptVjRq/aww0GBIWSQ7WcKai2/vez3ouZNKxAkshLOM0DNexRMbNohuVSQkZ c894D7Pzi2Jao90mlpFifFGVAaVkHFiLyqNyUcwibiYwoRJp7SNth/ObLy4efchZUHBH +6a+rsn/rHWtNQoqasSbies31M6WQ3DFtDdk7nWdUDgIqWXGbTtbPNW/sq0b50Nu0kWZ 0dOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z7kNBKDa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id qe15-20020a17090b4f8f00b0026b7d81b779si4034100pjb.152.2023.09.18.09.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 09:57:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z7kNBKDa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id D34BC80774B9; Mon, 18 Sep 2023 09:26:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbjIRQZp (ORCPT + 99 others); Mon, 18 Sep 2023 12:25:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbjIRQZf (ORCPT ); Mon, 18 Sep 2023 12:25:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C15882547D; Mon, 18 Sep 2023 09:22:40 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DDFEC3278F; Mon, 18 Sep 2023 14:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695048960; bh=5g74zms0pxYMdecZQ6PAg8uOblUWneJINnwTnBCL5rc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Z7kNBKDa8YOfxRdV2WlXnpbGMI7XWjSdQF38l1v7ARdt8lxcnz2FySG3T//N7fGhq nis7qDZLH7hL6/MnhuDP06S7yZwEiukQYjrmZd2p/SjUIu/821QUts4SjxVY1jinVS CKGoZITkcDvyW6aa4uzhlP9ud0VOpc0kjs33P5DUobPEhAS2Y0x/0FjFNgUpFFwCrq EsDawe56B6E9dKqegayeheJdTmcPCwC/VzIgmclTlxyJeLUnjkb+oQpjoaYwNnwnsq BbeHk4LA+FeUamNPmlpW25Y4HodFs4DkpCDyPUc2Pv9pU3xrgOEa9POh8XjnOVGSYn Fq6UllRskbcyw== Date: Mon, 18 Sep 2023 16:55:56 +0200 (CEST) From: Jiri Kosina To: Randy Dunlap cc: linux-kernel@vger.kernel.org, Rahul Rameshbabu , Benjamin Tissoires , linux-input@vger.kernel.org Subject: Re: [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency In-Reply-To: <20230914000517.16252-1-rdunlap@infradead.org> Message-ID: References: <20230914000517.16252-1-rdunlap@infradead.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 18 Sep 2023 09:26:03 -0700 (PDT) On Wed, 13 Sep 2023, Randy Dunlap wrote: > The hid-nvidia-shield driver uses functions that are built > only when LEDS_CLASS is set, so make the driver depend on that > symbol to prevent build errors. > > riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L11': > hid-nvidia-shield.c:(.text+0x192): undefined reference to `led_classdev_unregister' > riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L113': > hid-nvidia-shield.c:(.text+0xfa4): undefined reference to `led_classdev_register_ext' > > Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support") > Signed-off-by: Randy Dunlap > Cc: Rahul Rameshbabu > Cc: Jiri Kosina > Cc: Benjamin Tissoires > Cc: linux-input@vger.kernel.org > --- > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/hid/Kconfig b/drivers/hid/Kconfig > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -799,6 +799,7 @@ config HID_NVIDIA_SHIELD > tristate "NVIDIA SHIELD devices" > depends on USB_HID > depends on BT_HIDP > + depends on LEDS_CLASS Aplied, thanks. -- Jiri Kosina SUSE Labs