Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp158739rdb; Mon, 18 Sep 2023 10:56:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHEQDvYjdnyEN5WaTY6ke2wR1L2xnJ2ZNo709OKlcU9LqXrMZdijQSMZgcmIBqh/3kWxqb9 X-Received: by 2002:a05:6a00:1590:b0:690:2ecd:a599 with SMTP id u16-20020a056a00159000b006902ecda599mr9438714pfk.21.1695059785821; Mon, 18 Sep 2023 10:56:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695059785; cv=none; d=google.com; s=arc-20160816; b=IPjSXeKB0/bGn75wg6R3Kwb0RxZKLiW2+++5Z53CqPuYmV+aXb0ntbmFHLk1xgmMQ9 3ck3YPPEN2+rmpFQK2WkY4VwaWgYZs+ClOmUw7Fh7dnGFydXpJGW3c71lTvXK5lUwkKf 5SE/OIRQiaZcOL7DBP3msF3f3/+i58SjSK3zXUrAf1W6j0TnKrsOhYwgcpuqdRPFEs9D tCsCHYOIYbuF5gcr4r2a+S6Oyg9+k+tOUrNIu5TuId72hh83f9ewgNVggumrLFVTlRNr vAEn8VjGvXJxXeGXruhZwj9c5wo9yUyfU3dzD8QH932o88ysHuBoppNg9dvpIQWgWtJa asLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:references:in-reply-to:user-agent:subject:cc:to:from :date:dkim-signature; bh=XYZRHs0p/FMaKDD4jecbFxZVy3DXCvr3GOvUaH+nvWE=; fh=QN9Y8MvMTqlhrtFILeA4gMANgsfYHZ16DBUh+L6IBl0=; b=DIA8xfVS7UQiqARomlHOVKcgRyJOg/ClqRYNWpWSy5uxAjJRtgw2xDK2ACGz4II33j UecU7EPLFImENQw0/qPTM2Euzwm6mUz9QxgmTAB9F24dL3wKmRAcsnk+RjuLds/3NgQ9 BBp+pQqs2AokijuiTRk1E+onKXpWn9d96mnN7TQcEjUcCT5G4qwodflBuLvPBJWociCX XhiMqUo21P1BmTeldJzadA0LJ20BVILukoPbLXXbq1iYIugdRrer8OxE48ZdlWv7MR/B VXTMwlsxtijNldL7eKE3Ri9+aKBrW4Hgk0+IPvZY4wVDen5k1C64Ev2kl1E545i6J0NB cIsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=SnOACfvH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z6-20020aa78886000000b0068fbac77dd0si8408242pfe.226.2023.09.18.10.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 10:56:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=SnOACfvH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 8002480725D8; Mon, 18 Sep 2023 08:40:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229470AbjIRPks (ORCPT + 99 others); Mon, 18 Sep 2023 11:40:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjIRPko (ORCPT ); Mon, 18 Sep 2023 11:40:44 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11CADFC; Mon, 18 Sep 2023 08:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:References:In-Reply-To:Subject:CC:To:From:Date:Sender :Reply-To:Content-ID:Content-Description; bh=XYZRHs0p/FMaKDD4jecbFxZVy3DXCvr3GOvUaH+nvWE=; b=SnOACfvHrRzPMC4goTXMpBR5cm saYnBnGyRHJ2rvvxeS84D4/j9ufP1KrZResbTQ6pLykCWbCBZlAfsFhmWa1NCduEtGm4lyeeaChrE IY0NDCLoSX9JF6i/kbqYbAYGFsDRPWBnh3lzq/Ci4ylddEa1rjNCBm8+J9weqsbLcQXrx5JoDsxrf FghbzcLgUxBCW5JCFpXEpdYzhaUIGo603ZHhN4//Yv5XcP/kIT6NzfFFH7k52qrw3dHyUoUHuiRd4 IKlccJ1iYDF4xb2w1LZFK53XBBGDszwIWUbDN5WjUw8Fqqwx+EVDrpwPuhcsABDunlDeB8lLspvIG eF8T+IqA==; Received: from [2a00:23ee:2830:116e:a875:a49a:29fd:de50] (helo=[IPv6:::1]) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qiEsk-00BPSw-5o; Mon, 18 Sep 2023 14:05:51 +0000 Date: Mon, 18 Sep 2023 15:05:39 +0100 From: David Woodhouse To: paul@xen.org, Paul Durrant , kvm@vger.kernel.org, linux-kernel@vger.kernel.org CC: Paul Durrant , Sean Christopherson , Paolo Bonzini Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_11/12=5D_KVM=3A_selftests_/_xen=3A?= =?US-ASCII?Q?_don=27t_explicitly_set_the_vcpu=5Finfo_address?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20230918112148.28855-1-paul@xen.org> <20230918112148.28855-12-paul@xen.org> <56dad458-8816-2de5-544e-a5e50c5ad2a2@xen.org> Message-ID: <425F7A5D-58D1-4D94-A88C-E7B1EAEAD084@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 18 Sep 2023 08:40:51 -0700 (PDT) On 18 September 2023 14:41:08 BST, Paul Durrant wr= ote: >Well, if the VMM is using the default then it can't unmap it=2E But setti= ng a vcpu_info *after* enabling any event channels would be a very odd thin= g for a guest to do and IMO it gets to keep the pieces if it does so=2E Hm, I suppose I'm OK with that approach=2E The fact that both VMM implemen= tations using this KVM/Xen support let the guest keep precisely those piece= s is a testament to that :) But now we're hard-coding the behaviour in the kernel and declaring that n= o VMM will be *able* to "fix" that case even if it does want to=2E So perha= ps it wants a modicum more thought and at least some explicit documentation= to that effect? And a hand-wavy plan at least for what we'd do if we suddenly did find a r= eason to care?