Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp174609rdb; Mon, 18 Sep 2023 11:23:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqYOO1uq4O57FBKx5yGd3VCzjA2p1233AU8OjsyN0Puj/3u2DmwG0gxISop9iCW26QKg2k X-Received: by 2002:a05:6a00:2d0c:b0:690:41a1:9b67 with SMTP id fa12-20020a056a002d0c00b0069041a19b67mr10121777pfb.9.1695061382515; Mon, 18 Sep 2023 11:23:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695061382; cv=none; d=google.com; s=arc-20160816; b=tuHoPw8mZTOz+/lIkf3NVtwmXONuHJXRed8Xt5Cx0FHEVhlGXh0sH8FLMJZ+b+MaQu dHYwv8l8PD4brQrv0x2DS2nSr79jnJaKFWzwTfXKt5bBLiudFIlcOOsjGadJPX7gMBmM tCzsLBEquhrU2NdBx5llkA1TDwOoqePuINq42bMSGmqP7hwOS4HqbLqJFnGhgZy+0Ee6 3uIZ2KlUsUqmAPWKajD9D17BuxBfJvCdsZRmLRJeRvC9YdoONA/gZhg0TkzaniabgC3b aD68kWFUczZzaD1iVdIpjKRDlJTt3F02h6uMwktDKWOkRLA0NpYtzjXj34TLEcj9ZgkJ mQ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=DIel7i6bipM2sP6rCjr8oGrbNeg7x71wLbcIkTLilLM=; fh=Hkl/UeBdity30ZKyREHWmKGbaHn8OOQvgKy6vuWq6O8=; b=gtVj6VuXhLe8yNmrPmI7NYCJ/oZqv85UmrOiJKztMK/R5hRs48bVb/amC9aUoP/wtz zVfBYI+U99tgO8y6zreP3OW6XA3GG3BpGXQjzTag+jiV2x+INzT4PvmG8hql0+oTC2QB ZQhDgLVGnH7iNLAgS8VZu4oPLMpcueiKn0WErKJ7I62IXmLHy8/yxAvELusuY0lmXY2u 5XtR3WUnZjYe8WeS+CEdWTUpcHxZE/pyy33OoLHlxTq4L2RTl3KJTUxjIFMDEReNGiOe X0W1on8hTn1sgfhXV1jChWrzn1fei/5sN3oAWxOwPl5LEZRhchtClmAFA3tO5eacedl+ l0FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ep7ZUJjK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id y15-20020a056a00180f00b0068a65b26fc6si8691253pfa.43.2023.09.18.11.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 11:23:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ep7ZUJjK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id CAD3980947D7; Mon, 18 Sep 2023 09:58:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231259AbjIRQ6B (ORCPT + 99 others); Mon, 18 Sep 2023 12:58:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231232AbjIRQ5u (ORCPT ); Mon, 18 Sep 2023 12:57:50 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FDEBF for ; Mon, 18 Sep 2023 09:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695056265; x=1726592265; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LoHrUz4HloF7i91ZOnTnIldDYZxmI+ChqmUmJcHbdYg=; b=ep7ZUJjKOEQvAW12vi5Jex6SOn3iV6rmk/7j+vi+JZ2W//aWDL4JJJBg pHXflm+aA7yrHyWn85vOiBVOpL7OMR50zVoyi4l+HEHzkzoosZ9qe924g JFCoKqnTaORocLB27u2hxAlTPSLiTgo5DfnlWlQVR5ZmLEaGT6c/DUfMm 7bww27MeFWjg8rk2ZFw9dr4mzn3W7aQ+ClXjg9n7sgZ07DjQY66JG6myJ PsEYb8rM3KePXFubKI5JAL6Qdi6mKKkP3sfqjOawTLK4nw55Nyu4s97Fm bzXn8JHBIKLODaSqCaox/OPdid6xNqIcFnUxdVBCx9E687d41kiPl0YF5 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="359131616" X-IronPort-AV: E=Sophos;i="6.02,157,1688454000"; d="scan'208";a="359131616" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 09:57:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="836113094" X-IronPort-AV: E=Sophos;i="6.02,157,1688454000"; d="scan'208";a="836113094" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 09:57:43 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qiHZ7-0000000FQOZ-1dy3; Mon, 18 Sep 2023 19:57:41 +0300 Date: Mon, 18 Sep 2023 19:57:41 +0300 From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Luis Chamberlain Subject: Re: [PATCH v1 1/6] params: Use sysfs_emit() to instead of scnprintf() Message-ID: References: <20230912150551.401537-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230912150551.401537-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 18 Sep 2023 09:58:02 -0700 (PDT) On Tue, Sep 12, 2023 at 06:05:46PM +0300, Andy Shevchenko wrote: > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. Any comments? -- With Best Regards, Andy Shevchenko