Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH v3 0/3] HID: nvidia-shield: Fix the error handling path of shield_probe()
Date:   Mon, 18 Sep 2023 04:54:29 -0700
Message-Id: <20230918115432.30076-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Apsu6kkoSyCUX5jrM8MJt8ugg4KcKBBI66cVz3g4x/Gs88xaqRh74OPNPLxF?=
 =?us-ascii?Q?iJ4ITkXauW4ZCYF3rgiqcDTUTXUYHKR9iRzUDlNCKUpwgNHo0fBkPsvz9LxY?=
 =?us-ascii?Q?Uk1XP0GuTmcwuyxRJBV5mQ0QvCIg+GDS1Yg7szaEUrL6HH+nQ4N93dKsL2Rw?=
 =?us-ascii?Q?6xn1pUPvs0ryzVS9FfKjKSFYjxGExH5FVr2FE1IccopGTkhUPIaG8K+qxVjY?=
 =?us-ascii?Q?uctHVhbsLNEzYgay3ZXE1H/9GMFFYuT3GbJN8XeYwroUmqdd5d0v+qBhx3x/?=
 =?us-ascii?Q?V2xlDOoI7Xbwp9qo+MQ7hgukrFatMaRSkxtU/mmsXBIPAu/zk5cs7Lte3W/T?=
 =?us-ascii?Q?fb2Mk2yDv7J/bS2S0qWQqu7YkiQmmqSLr0kH34hQxtA5S7s/GZ6tDY+lqVR0?=
 =?us-ascii?Q?oIN80miwutfGXgZOCUfyEkwhf6v7CkP5Cpp4DNMY+HAYdW91ey7LEWyA3ZI2?=
 =?us-ascii?Q?DkXE3KKZnh2+gbY8jj1c8hXmqMwbA49LCCdQZUzz7IfGbwWbMG62/1fcb3zo?=
 =?us-ascii?Q?wgHUtv8igRdQ3ktskjafF8HOxLvIWqLngMuNxoVWEFdSLBKCyz7AKJJnklkL?=
 =?us-ascii?Q?oHeJiMRgcKzkKA/OwLcl0kvP9jJvKcFgPCLqfDs47n/A16sG2VnS6+H4bJn3?=
 =?us-ascii?Q?oaKYLX6NEwQmWnVAXn50zRifMBbT2UPEYKDGJB78RlcIBRxWE5gIIp5b1vvz?=
 =?us-ascii?Q?xAr9t2b7BEs6iz3oyVhyBjHVzJgBuLf8O45Mqxwt9BH6nwtiqidMxrr5VXk4?=
 =?us-ascii?Q?/ajoxAm/lRtlvDeHKwp5xCQxxsmg7uBO9+AxTaEcwE9tqW1rtidgkq+BASTW?=
 =?us-ascii?Q?OUISZ+WUUMVGO1+1zI7GqgpUlhCELr7lUwwM45gBOt4NS23dCnVV7bfhJmxX?=
 =?us-ascii?Q?oCxjOw5GkcyWDAJ4Pf8ZqSJvjXoSTJs+UioyzQguBd5yGUqgqgpl0AYDXHSz?=
 =?us-ascii?Q?0uau5xUffkBIqnn5xaXHYS54lxAYs4MASR3p9tLpgW54xrHVSCqhp8XH3llK?=
 =?us-ascii?Q?s/yOYTLw8zQB7Sxoa35LFw3OQZfS7t7XHWg73FK04w9NptBlFpJtb/uCxOda?=
 =?us-ascii?Q?pQbDwQ80Fz3y4C8hpyvnL1v41rmX7NJx2gtwhSw3M/ZY/iAGKgQLOaIy35zl?=
 =?us-ascii?Q?DO1wMevHFams0uiYCduf2lLTYYPVOKHpCrz3N5vN0CKEzwA3Ucc7RyBY4a/w?=
 =?us-ascii?Q?hzn2NIMaTqO0PzN7lVQsyIepwPqITfLYn+x14fT6Qp9zZCpyw+53dS2ovSH/?=
 =?us-ascii?Q?19+TNjGBcrMWob4WP5LeRxBG1z1qYIKlyauyVckeOFbpAHW/P0HLRMQQcVFq?=
 =?us-ascii?Q?rElfABRch2io8dqnE3h5KE0cwkZx8kPoGGiU5j5/JRbRQ+3b4RBr4D5BzNId?=
 =?us-ascii?Q?nF3XC8wKar4Jt0WPqX0YHBkAkbEtPUraEKJKMAEw/ypGjHcaTKNw0WDMTTlG?=
 =?us-ascii?Q?C+TExaktU+DW7AuUyVSU/lW5dtX61ogx6XF4zR0bLi/tJzh3DSwVvVxpxrIF?=
 =?us-ascii?Q?5atmDhMWiIc4F+vYe8WUnEEO0Z2Vu2z4SnP13ZBFx3bke6HI70jwCE6Hf+KQ?=
 =?us-ascii?Q?LaiEPhlH/fGcEpptlDlPLjTrgEx9DeBLAUjhJ4YB?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10e85b63-5415-4fbc-6677-08dbb83e0d47
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 11:54:45.4499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o7sKrrQRgpYReFEEP5xNNIgoYRtbvxcl66IUsE1b4rrqmxZCAJi7ZDoyDh9YntkIVsAl71RMbdLx+7pJnRefTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7872
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 04:59:08 -0700 (PDT)

This series fixes some missing clean-up function calls in the error handling of
the probe.

Patch 1 and 2 fix some similar issues introduced in 2 different commits (hence 2
patches)

Patch 3 is an enhancement that creates a common function for cleaning up
thunderstrike instances.

Changes:

  v1->v2:
    - Add the LED_RETAIN_AT_SHUTDOWN flag to prevent
      led_classdev_unregister from trying to set the LED to off before a
      successful call to hid_hw_start.
    - Rename err_haptics label to err_ts_create to make the label name more
      accurate.
    - Re-order operations in thunderstrike_destroy to be in LIFO order with
      regards to the operations in thunderstrike_create.
  v2->v3:
    - Refactor thunderstrike_destroy to take a thunderstrike instance
      pointer as a parameter and prevent a variable from being unused
      in shield_probe.

Link: https://lore.kernel.org/linux-input/cover.1693070958.git.christophe.jaillet@wanadoo.fr/
Link: https://lore.kernel.org/linux-input/20230918041345.59859-1-rrameshbabu@nvidia.com/

Notes from Rahul:
  - Thank you so much Christophe for these patches.
  - Sent v2 without accounting for the fact that thunderstrike_destroy in v1
    makes the thunderstrike instance in shield_probe unused. Tested v3 with W=1.

Christophe JAILLET (3):
  HID: nvidia-shield: Fix a missing led_classdev_unregister() in the
    probe error handling path
  HID: nvidia-shield: Fix some missing function calls() in the probe
    error handling path
  HID: nvidia-shield: Introduce thunderstrike_destroy()

 drivers/hid/hid-nvidia-shield.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

-- 
2.40.1