Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 18 Sep 2023 12:09:15 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Alexander Usyskin <alexander.usyskin@intel.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lucas De Marchi <lucas.demarchi@intel.com>,
        Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
        <linux-kernel@vger.kernel.org>,
        "Tomas Winkler" <tomas.winkler@intel.com>,
        <intel-xe@lists.freedesktop.org>
Subject: Re: [Intel-xe] [PATCH v2 2/4] drm/xe/gsc: add has_heci_gscfi
 indication to device
Message-ID: <ZQh2K506qQ+hGSld@intel.com>
References: <20230914080138.4178295-1-alexander.usyskin@intel.com>
 <20230914080138.4178295-3-alexander.usyskin@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230914080138.4178295-3-alexander.usyskin@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6bpL9Au7XWly1o2RQvf0QtGaZfK3kvGruIe3n3IVYdQiils0pL4SkUp5aXh+?=
 =?us-ascii?Q?Yvzus8eLz94R9Zu6VgcaekrPC6kL4phgb3thh2dopWO4KqIeWjvTu2ldumdA?=
 =?us-ascii?Q?V9dlowGOUtWW/jS2FbIHpIjuf1xsvGrRwtNhuk9PDn4ajNL7UgpkBnJqaVqx?=
 =?us-ascii?Q?IDiMME+rHdrGq+y+/5TtVrCBraZjjMw4CUszQ+BuWlfqmOPsmsyLbgXYGZmE?=
 =?us-ascii?Q?r7UEB0nPo8uPFOLlQex3CAyJ7ZY42DD1QqOSHwHvYO11vQTsdv/736Fd5XVI?=
 =?us-ascii?Q?pfbbdC9+2zzmXslIy9KJoc9gUcMOcdl1GLFaImjvCs+/ShA1GQ8N1bXMW2nt?=
 =?us-ascii?Q?luIZFuiP4CqLr4xLVnLleEdUITQ4JBCZCNu6LWmYR1fTmo+kZauUd6Kk1k/t?=
 =?us-ascii?Q?8RHZysVUY4pI3cn6lybczMEDVDFqR+ifQ/ykzgL+NAtaTTok9+UKk0/bgvQq?=
 =?us-ascii?Q?YMhM+jjS/hqvnvMbWHL3MXrU2LD07uF7+UBdqZUi1o3qrz+fjYKMlCIznHHy?=
 =?us-ascii?Q?F4LhZqEvBbSDPp1BToLchnrexQCbzRz5fHyEXaItvJTI3p8R9ceb+gqb3bfL?=
 =?us-ascii?Q?P4xVtjMkr9QnDb0EcRTMZLqmYMjhnOKAUmvHaCmQgrZeucn6Y2Cn+7i6b+C4?=
 =?us-ascii?Q?RwVXeJDxFgl/xIay/ueBvgaoKZblRErQrG+pTqwXBedy6A1lp9DEmlD5UUol?=
 =?us-ascii?Q?THzt6j3J5/Hzpqj0dK95m5v7zuzhn9dD/kdc3sJ9/psHUSeIwlHYcTRCHBtD?=
 =?us-ascii?Q?G7R9La59fhi7yNwNL9r6wkOYGflwihRrsxDs/0cdNN70nq8cbRRNFIx49emi?=
 =?us-ascii?Q?co9bRWdM7IwPnzzVPshscmCq1bTrl2VUcLDAoy0OKSH06OE0iLOTTmieK1Q0?=
 =?us-ascii?Q?ITdrcqE4SGJktRHOPx6RtI62s9WRfw6U/WESo91zcP+bcUdgPyUaUTy1EQbc?=
 =?us-ascii?Q?J3Y5Y2RvWQI9DQErCU8YhBhhIE7mJw/WhvjZ37IZPxCKDfmoqJKkJ7F2zkDk?=
 =?us-ascii?Q?Zga4bMkdPwzJ25OOPI19LHfRMNSuf65HfyrRY8XyvSSFJyvW+UVi3ZWPpA5Y?=
 =?us-ascii?Q?6Dsu8tFzokzioRkXKQNDej5jttRs6+bl9Uj8vN0EkSS9HI6/eHizZXk8TTb7?=
 =?us-ascii?Q?NmgEGkgSZrydg4yHyNWxTDOTjBw/ncFwgmWhQcu3oYxvmobefo4czao5THMj?=
 =?us-ascii?Q?VZSz0GiFIRwSvPCrXVVxIDaSDmOqeTrRZUtRsASsoNOljkCrDp4G7VsL2baw?=
 =?us-ascii?Q?zphFTwEye8StR+p4Yyur4ho5g7bYBV1gTv4etHvnOgPOdLq8YKL8eiEn1B1J?=
 =?us-ascii?Q?O2BmUDXS8uPwQEQmdxmBG9SPw4aqz2QQ2s/YKIXm8cTN9QKbQLkK4qV5sfSb?=
 =?us-ascii?Q?b8sPZBGqD+5xtzY7u/Q/nGwn1UVeVmmCeuww9x30xFhpCwAv/CUdWAvoegWc?=
 =?us-ascii?Q?WSnVljX0h8SzIryWkCHoJlBUgpvN4jdqWBkv/0wlsQgz4NafDFNAcFT2nMKQ?=
 =?us-ascii?Q?S77PCtCFRKYzAg+ncofTTY8ZcwekbHi8kooLXubnSxohMnNWJrlhrxOv4J/A?=
 =?us-ascii?Q?Kh1OOUlDQLhNHyBQ5Hhhju8mdQIUrdoxgnxl7pPj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ae19541b-a63a-4909-78d2-08dbb8619e6d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 16:09:21.4861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: awbQDkl6veVmNzN+DmJ5d06PuKmRdWjFzlZgXJcYIGGbg/X/R4IthjEa4uugTRVHQcw0v7P6qMjPzTCMOirjug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4639
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 18 Sep 2023 09:20:02 -0700 (PDT)

On Thu, Sep 14, 2023 at 11:01:36AM +0300, Alexander Usyskin wrote:
> From: Vitaly Lubart <vitaly.lubart@intel.com>
> 
> Mark support of MEI-GSC interaction per device.
> Add has_heci_gscfi indication to xe_device and xe_pci structures.
> Mark DG1 and DG2 devices as supported.
> 
> Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device_types.h | 3 +++
>  drivers/gpu/drm/xe/xe_pci.c          | 9 +++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 750e1f0d3339..1d1fe53fc30d 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -32,6 +32,7 @@ struct xe_ggtt;
>  #define GRAPHICS_VERx100(xe) ((xe)->info.graphics_verx100)
>  #define MEDIA_VERx100(xe) ((xe)->info.media_verx100)
>  #define IS_DGFX(xe) ((xe)->info.is_dgfx)
> +#define HAS_HECI_GSCFI(xe) ((xe)->info.has_heci_gscfi)
>  
>  #define XE_VRAM_FLAGS_NEED64K		BIT(0)
>  
> @@ -237,6 +238,8 @@ struct xe_device {
>  		u8 has_link_copy_engine:1;
>  		/** @enable_display: display enabled */
>  		u8 enable_display:1;
> +		/** @has_heci_gscfi: device has heci gscfi */
> +		u8 has_heci_gscfi:1;
>  
>  #if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
>  		const struct intel_display_device_info *display;
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index dc233a1226bd..145eaa430d74 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -57,6 +57,7 @@ struct xe_device_desc {
>  	u8 require_force_probe:1;
>  	u8 is_dgfx:1;
>  	u8 has_display:1;
> +	u8 has_heci_gscfi:1;
>  
>  	u8 has_llc:1;
>  };
> @@ -265,6 +266,7 @@ static const struct xe_device_desc dg1_desc = {
>  	PLATFORM(XE_DG1),
>  	.has_display = true,
>  	.require_force_probe = true,
> +	.has_heci_gscfi = 1,
>  };
>  
>  static const u16 dg2_g10_ids[] = { XE_DG2_G10_IDS(NOP), XE_ATS_M150_IDS(NOP), 0 };
> @@ -274,6 +276,7 @@ static const u16 dg2_g12_ids[] = { XE_DG2_G12_IDS(NOP), 0 };
>  #define DG2_FEATURES \
>  	DGFX_FEATURES, \
>  	PLATFORM(XE_DG2), \
> +	.has_heci_gscfi = 1, \
>  	.subplatforms = (const struct xe_subplatform_desc[]) { \
>  		{ XE_SUBPLATFORM_DG2_G10, "G10", dg2_g10_ids }, \
>  		{ XE_SUBPLATFORM_DG2_G11, "G11", dg2_g11_ids }, \
> @@ -562,6 +565,7 @@ static int xe_info_init(struct xe_device *xe,
>  		return -ENODEV;
>  
>  	xe->info.is_dgfx = desc->is_dgfx;
> +	xe->info.has_heci_gscfi = desc->has_heci_gscfi;
>  	xe->info.graphics_name = graphics_desc->name;
>  	xe->info.media_name = media_desc ? media_desc->name : "none";
>  	xe->info.has_llc = desc->has_llc;
> @@ -703,7 +707,7 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  
>  	xe_display_info_init(xe);
>  
> -	drm_dbg(&xe->drm, "%s %s %04x:%04x dgfx:%d gfx:%s (%d.%02d) media:%s (%d.%02d) display:%s dma_m_s:%d tc:%d",
> +	drm_dbg(&xe->drm, "%s %s %04x:%04x dgfx:%d gfx:%s (%d.%02d) media:%s (%d.%02d) display:%s dma_m_s:%d tc:%d gscfi:%d",
>  		desc->platform_name,
>  		subplatform_desc ? subplatform_desc->name : "",
>  		xe->info.devid, xe->info.revid,
> @@ -715,7 +719,8 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		xe->info.media_verx100 / 100,
>  		xe->info.media_verx100 % 100,
>  		str_yes_no(xe->info.enable_display),
> -		xe->info.dma_mask_size, xe->info.tile_count);
> +		xe->info.dma_mask_size, xe->info.tile_count,
> +		xe->info.has_heci_gscfi);
>  
>  	drm_dbg(&xe->drm, "Stepping = (G:%s, M:%s, D:%s, B:%s)\n",
>  		xe_step_name(xe->info.step.graphics),
> -- 
> 2.34.1
>