Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp186862rdb; Mon, 18 Sep 2023 11:49:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEh4gqhWGs7df4WOF8aRH30/WduDuBenKIOMY8W9aUkiOz8+5VvpM8ZCYNeNgm5/JS0TM2V X-Received: by 2002:a17:902:f801:b0:1c3:749f:6a4f with SMTP id ix1-20020a170902f80100b001c3749f6a4fmr7407556plb.54.1695062942695; Mon, 18 Sep 2023 11:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695062942; cv=none; d=google.com; s=arc-20160816; b=poYNGbf1wocML741u4bkzQh417s9RmPxy7E8fl9IttqzE9ixU5mI5b8ngWI9dwqYsF jdnYFX2OnjVGmGVH0BqHMweHjlkYy4p1LgVnPPiz60uO9A/Z26n0UgNDtAZRm4HM2gIW CIT56yLDL6yLEZekO8WgFDo1CMKkWP63va6PTaEj6n/IErltiJLBH0zdfiSC9kAXtyT8 +T+H4xj8Gb8y36AwioSS0Bl+Y75AGR3jJRwthQ1kyxvBLsZQUxsfJbvfcRprxBCKnWOa JGcs1jBMkwkpVu2V/W5rdOfrVsNl1xIp5Mzkv3aYuzts8PfJWkvhwz+YfiSdvMmWIF2f xK7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=3lFpWEQNX0RgOS+vwuIIC94hCwP0MrQhLUc3uHKyySs=; fh=8G8DDOWeXTrynpwGxRU6+UU65RCHDEs7NE1+CluhaKI=; b=isB0yQi/UgXev7f+5t1PkXisFkwMVlTK3dQC15ZnnPOTgHs0xKM8gaZkh8et9r9fB1 SE8KAp/yzQs0v1q9jxgUM54jf1SQVDEwlorgArmswAYADKSQxTyD5Dll5LozClkqiNQd 3d3EzXzb1UWHe/DgFLdRPVRvtgHGwAoGcF1oQsZAQ9maVqZr+hv4YYNlPOKTDU2AbEGd qkec4CI0c4e1kKmT7MlxkOEJgqbE2WJn1c4KKVvME9UIkaQbac3ZbNkm4uuGDfPemPGZ 7w+4jfim5IU0IFRioi2Y1lwN7EyeLXUWYtxDArCpk3thdBiKXejSoWQ+kTkcTTLLDRNp 2Eqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@szeredi.hu header.s=google header.b=M2TS0f7F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=szeredi.hu Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id cp1-20020a170902e78100b001bdd35033efsi8269319plb.374.2023.09.18.11.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 11:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@szeredi.hu header.s=google header.b=M2TS0f7F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=szeredi.hu Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C95B5809B0BF; Mon, 18 Sep 2023 09:51:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbjIRQvE (ORCPT + 99 others); Mon, 18 Sep 2023 12:51:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbjIRQvB (ORCPT ); Mon, 18 Sep 2023 12:51:01 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 370C8F4 for ; Mon, 18 Sep 2023 09:50:55 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-401ec23be82so50805065e9.0 for ; Mon, 18 Sep 2023 09:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1695055853; x=1695660653; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3lFpWEQNX0RgOS+vwuIIC94hCwP0MrQhLUc3uHKyySs=; b=M2TS0f7FH4VhfmUPOpE9TcSnZm5WZcZ8TmKzE8iVoIcPWs+f1+26GrQckzgHctpAMD BsTR/gEd6Sed24EU2TQrOEd1hohKrRZS01uekZLodN7mQG7hsbj7NdG7Ld8qwTUDCHSK GOgCdjdP8+NIaRWo90AKLNdxNk10w4vSeRtLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695055853; x=1695660653; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3lFpWEQNX0RgOS+vwuIIC94hCwP0MrQhLUc3uHKyySs=; b=aR+xvJh4LIRM3NViHEmMI7nIJB77K4rI2W8IiZNQlc7lPGLZOZRawd7l5gjnsLp3hz dj53tTt91NJS0/8MbPfsL+HFvEiIhk0At5fVcLMSL6XY3QIsioChRBuWjflgqLyipj+B 519ky5Yj39lXxnSCHxqprEV6ZdP2jRJVTn6R6uUWOyNnmBaqitVfZBkrjqYYfSUmJYa3 77frrYe+SKP0eaDQU1Ms386noZemP+NLwcjdFNwNkDdVVhmJk3yIYUgy7wfY1sAI/+et 81y4yFmSBBCTtyhrtUsriXhXEQVO9OnCMzd5C6h+fGJLgrH5pQQXBJnU4wYpeq5WQwhW dbDg== X-Gm-Message-State: AOJu0YygfCUOyUjLTHptdsW5qa4k1DYxQXxYkMpkBxk1Bl4H79fY9lsn 2QnL64H72+KQePGOXphRdtQiZGcjLuTVyMxPsSVpfz9NugJn5Gso X-Received: by 2002:adf:a3c4:0:b0:31f:f664:d87 with SMTP id m4-20020adfa3c4000000b0031ff6640d87mr7329776wrb.20.1695048675110; Mon, 18 Sep 2023 07:51:15 -0700 (PDT) MIME-Version: 1.0 References: <20230913152238.905247-1-mszeredi@redhat.com> <20230913152238.905247-3-mszeredi@redhat.com> <20230914-salzig-manifest-f6c3adb1b7b4@brauner> <20230914-lockmittel-verknallen-d1a18d76ba44@brauner> <20230918-grafik-zutreffen-995b321017ae@brauner> <20230918-hierbei-erhielten-ba5ef74a5b52@brauner> <20230918-stuhl-spannend-9904d4addc93@brauner> In-Reply-To: <20230918-stuhl-spannend-9904d4addc93@brauner> From: Miklos Szeredi Date: Mon, 18 Sep 2023 16:51:03 +0200 Message-ID: Subject: Re: [RFC PATCH 2/3] add statmnt(2) syscall To: Christian Brauner Cc: Miklos Szeredi , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-man@vger.kernel.org, linux-security-module@vger.kernel.org, Karel Zak , Ian Kent , David Howells , Al Viro , Christian Brauner , Amir Goldstein Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 18 Sep 2023 09:51:19 -0700 (PDT) On Mon, 18 Sept 2023 at 16:40, Christian Brauner wrote: > What we're talking about here is a nicely typed struct which returns two > paths @mnt_root and @mnt_point which can both be represented as u64 > pointers with length parameters like we do in other binary structs such > as bpf and clone3 and a few others. That is a compromise I can live > with. I'm really trying to find as much common ground here as we can. So to be clear about your proposal: .mnt_root and .mountpoint are initialized by the caller to buffers that the kernel can copy paths into? If there's an overflow (one of the buffers was too small) the syscall returns -EOVERFLOW? Thanks, Miklos