Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Huan Yang <link@vivo.com>
To:     SeongJae Park <sj@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        damon@lists.linux.dev (open list:DATA ACCESS MONITOR),
        linux-mm@kvack.org (open list:DATA ACCESS MONITOR),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Huan Yang <link@vivo.com>
Subject: [PATCH] mm/damon/core: remove unnecessary si_meminfo invoke.
Date:   Mon, 18 Sep 2023 17:49:34 +0800
Message-Id: <20230918094934.18123-1-link@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U8DZ8QS9srUlEmmNB40yF5K18BnAhZ2xhLPw09yzom6tEyX4goO/q/zr0aGA?=
 =?us-ascii?Q?AlX1UX8nipr5WPJO1vbDv7vm9t1TMaPVQheu31DC0Na1IPDgZf4erBjSWQNc?=
 =?us-ascii?Q?Xmbwe8CPH5BF1qA87TkODffJTloahiwMBt5a2LaIsblKfSl0BJB7WVmYDFAU?=
 =?us-ascii?Q?Cfug8yWnR29B0C9SSIj9hYfN5d+RDTB1XEfObkWCTAHOv0D6RPZCfeRu2rcg?=
 =?us-ascii?Q?q+xfbrmDr5kxbUfB/PeE4VLOFdsA02mcnmT8eLbKtt7As2X18m2S/oMLqbpF?=
 =?us-ascii?Q?Sc9aPN85D8vwOKoTDL7ixoI7jXdYCEoszgPfsz5/f8mfJxNQSPYrterv0bae?=
 =?us-ascii?Q?HQpqxXPpcA2R7BduYo/oG3edgZ5EprrANrR3ftqIXpqcc5ybqeBb4JDOMH/N?=
 =?us-ascii?Q?/K2LxvMsWEb+N9p19VLEQlrUQ/RCFUIdvcjkbgcaUHPPGCPUPINaH5FPwfnz?=
 =?us-ascii?Q?Tfhc++yrQ6oEZdc9pPro3jX75RaFVjxvT3KYgMPCI1oedFdPEOGIJcRCMRnp?=
 =?us-ascii?Q?XPtQ96IeaKisknuuC+o7N9YPNwNYMxKvIvU1l2Sxads2M38d/6gc8oy79kky?=
 =?us-ascii?Q?jClou+rpdD1jTP0zo9+rrmmBPGj8cBHLnFqSVO2xYzTSkItDO8CC9Z8QQIZB?=
 =?us-ascii?Q?Uqof22tcYAYSrRhqkSwuEtJCUEFlnsG4b3Gqss4haMt8XnqcfAQWvR+cjHFP?=
 =?us-ascii?Q?nxDfMmcgktPwctSEpkDStSs6IP0zLeyN+Sv6BuTqj0uJJmEnEVKhJR0t5UTs?=
 =?us-ascii?Q?DLviCZlsqvHcmv8+BrxFu5RweW2Y05J4iAX2YI28/p5jP4g3Z9vT2BdgdWLV?=
 =?us-ascii?Q?p0R2btMRav+FRZCWeCuWMdD8C+MPWCepo9O17a9xL6WHcXtxJhiHNJTINRVm?=
 =?us-ascii?Q?mAfJ0n6Ope10VTr8U14T1wodZyyocIUS97FUc2HGlG9TLyKJ2y6mF2HZPf6R?=
 =?us-ascii?Q?1iIihxGfpAKkkvTpbtRby1IJzKb4FluKa22PDRm4NX9IOCc4CCqIjifNKcbX?=
 =?us-ascii?Q?kLfTx/KY2Vq7xMg162+9I0AkwETjSqzQWbumOIpsBPNAVa+mZE5X5iv4DQdK?=
 =?us-ascii?Q?GMXHvZUPVdLU9xfchpxTiWO9htbBl6kQheHMuyQ2y3mX0YEVntJzViHQJ+m4?=
 =?us-ascii?Q?K4oov5+gay3IKv6dsl6QBKWmeH7bPS3tiizPQggA619HE1Audzl4rJgp0X6L?=
 =?us-ascii?Q?+f3TFLWxuP22fjfaZchkdPRPpPpEwAeu6s+/4hNGYm6WsoktDWx0S3vOrB7Y?=
 =?us-ascii?Q?Rzsu0FdaDwfQHSph0yiE1HiATAHRIU33Z6ux9l0URIbImrNn2NZP82Bde56r?=
 =?us-ascii?Q?RJP4y8yCAHA1d2ng5x7viLyzpCPf2UPDf05iIl9GQMnFNi+xllJwZN5Zb32B?=
 =?us-ascii?Q?Hj9iqjZwuWOeXf9LySaduCmtDPXpSim0mBqa6SGgeyfKB9plDJrXwD2Q8l4O?=
 =?us-ascii?Q?TuUuokxh453Ut6ChRZc4xX2vDZnN+u8eY0M4RJoqK3gz9y2iFgOeqpKBxMLB?=
 =?us-ascii?Q?wr00zH2v1E25yxkK0LxW9Mx2ved4AqitrOQatQN/EXBWHmxeYMNzd2Hsq8Tq?=
 =?us-ascii?Q?yQS23nbnklRcYutbP+MNGMf7GoPIfg1ZdB5+CTY5?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2335658-a519-4067-9a96-08dbb82c9ba9
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 09:49:53.6145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZGyshqNxMDdh15yX0DsV2EPjqLcVKDi4PTx4fQq3Pq8nZkNGVdDERGl787hcHF2Iz5p8pv9nhnYg3nfoApeQXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB6266
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 18 Sep 2023 02:50:49 -0700 (PDT)

si_meminfo() will read and assign more info not just free/ram pages.
For just DAMOS_WMARK_FREE_MEM_RATE use, only get free and ram pages
is ok to save cpu.

Signed-off-by: Huan Yang <link@vivo.com>
---
 mm/damon/core.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index bcd2bd9d6c10..1cddee9ae73b 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1278,14 +1278,16 @@ static bool kdamond_need_stop(struct damon_ctx *ctx)
 	return true;
 }
 
-static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric)
+static unsigned long __damons_get_wmark_free_mem_rate(void)
 {
-	struct sysinfo i;
+	return global_zone_page_state(NR_FREE_PAGES) * 1000 / totalram_pages();
+}
 
+static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric)
+{
 	switch (metric) {
 	case DAMOS_WMARK_FREE_MEM_RATE:
-		si_meminfo(&i);
-		return i.freeram * 1000 / i.totalram;
+		return __damons_get_wmark_free_mem_rate();
 	default:
 		break;
 	}
-- 
2.34.1