Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <aee51f0c-8cf1-d893-c111-e3aa93de2af9@redhat.com>
Date:   Mon, 18 Sep 2023 13:28:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1 3/4] mm/ksm: document smart scan mode
Content-Language: en-US
To:     Stefan Roesch <shr@devkernel.io>, kernel-team@fb.com
Cc:     akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <20230912175228.952039-1-shr@devkernel.io>
 <20230912175228.952039-4-shr@devkernel.io>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230912175228.952039-4-shr@devkernel.io>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12.09.23 19:52, Stefan Roesch wrote:
> This adds documentation for the smart scan mode of KSM.
> 
> Signed-off-by: Stefan Roesch <shr@devkernel.io>
> ---
>   Documentation/admin-guide/mm/ksm.rst | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
> index 776f244bdae4..1762219baf51 100644
> --- a/Documentation/admin-guide/mm/ksm.rst
> +++ b/Documentation/admin-guide/mm/ksm.rst
> @@ -155,6 +155,15 @@ stable_node_chains_prune_millisecs
>           scan. It's a noop if not a single KSM page hit the
>           ``max_page_sharing`` yet.
>   
> +smart_scan
> +        By default KSM checks every candidate page for each scan. It does
> +        not take into account historic information. When smart scan is
> +        enabled, pages that have previously not been de-duplicated get
> +        skipped. How often these pages are skipped depends on how often
> +        de-duplication has already been tried and failed. By default this
> +        optimization is disabled. The ``pages_skipped`` metric shows how
> +        effetive the setting is.
> +
>   The effectiveness of KSM and MADV_MERGEABLE is shown in ``/sys/kernel/mm/ksm/``:
>   
>   general_profit

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb