Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Mon, 18 Sep 2023 17:39:56 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Mark Pearson <mpearson-lenovo@squebb.ca>, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: think-lmi: Add bulk save feature
Message-ID: <ZQhhPJsQapKkY39v@smile.fi.intel.com>
References: <mpearson-lenovo@squebb.ca>
 <20230906121328.50437-1-mpearson-lenovo@squebb.ca>
 <ZQhXZkBHviGOEl-x@smile.fi.intel.com>
 <878da778-e183-6ef5-61ce-3a3d059f1a1e@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878da778-e183-6ef5-61ce-3a3d059f1a1e@redhat.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Sep 18, 2023 at 04:07:53PM +0200, Hans de Goede wrote:
> On 9/18/23 15:57, Andy Shevchenko wrote:
> > On Wed, Sep 06, 2023 at 08:13:14AM -0400, Mark Pearson wrote:

...

> >> +static const char * const save_mode_strings[] = {
> >> +	[TLMI_SAVE_SINGLE] = "single",
> >> +	[TLMI_SAVE_BULK] = "bulk",
> >> +	[TLMI_SAVE_SAVE] = "save"
> > 
> > Missing comma.
> 
> Fixing this retro-actively is not really useful, if we
> ever need an extra entry we can deal with the churn then.

I agree, but this is to give a comprehensive review as long as I went through
the entire change.

> >> +};

-- 
With Best Regards,
Andy Shevchenko