Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <fa4730c3-6993-906a-1ebe-1b4faeda830e@intel.com>
Date:   Mon, 18 Sep 2023 09:53:33 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 00/10] IFS support for GNR and SRF
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>, <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <rostedt@goodmis.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <pengfei.xu@intel.com>
References: <20230913183348.1349409-1-jithu.joseph@intel.com>
 <ec68c553-1a12-6e33-b732-fd51d89cd439@redhat.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <ec68c553-1a12-6e33-b732-fd51d89cd439@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnZUOWkveHdzL09najNST0tNSlMvcXZ4eUpxY2l1OHNKKzhRR2hiYzVCWjU5?=
 =?utf-8?B?Q0dQdlB2TE90Zm5KdjBIZHNSYS96NGpxOXB2QTdUU01TQlJpOUVkaWJxbTBv?=
 =?utf-8?B?WEJFanc1U3pRdXRZRzdveTNEMnV2LzFmV0lwVE1nSTFnVjNIb2FNZmJmenJ3?=
 =?utf-8?B?YnZ4blFBbW5OdHJOWFJIUWJSVWJFV2tuR3ZycG43R2tpeDNwdnRaVUM4Qi82?=
 =?utf-8?B?NkxGMGdlTDZvNjNSQ2NjbHJIZHU5OVlYWUVMNDFXUDBYSklJSFhLd3FZb3Ra?=
 =?utf-8?B?SS95RjM2SHRVRFQ0VkQ2ME9OV1NJZW1rcnYyMU0vYXlJS3N6NHMxUW9kck93?=
 =?utf-8?B?d254cFJ0M3J6cldCYkN1bHRBeGE5SjhTK2s0WTNhcUNKQ3B1VkN6Z3RXWVNl?=
 =?utf-8?B?eS9DVE9LU3lCQW5KS2I2WXY0OWM2aUZOZUltTExIenVlWTBIdUJmMTJiMC9G?=
 =?utf-8?B?TWU3NEowM2tmYzgrK3QvNmJqOHpnMFN2ZGhpVkRhQnZNRTU2RS9tSmhLWi9z?=
 =?utf-8?B?Y2o4Sk10ZllpUUhib1IyTFFWN09CSE5vSUFCQjhISmpqUEJPc1dYeHBKdkVy?=
 =?utf-8?B?QTBjbC9aT2hwa3kyK2hZU3I4TDdUemJiaCtVaWxpbG11cDFqU3lseDdYVmdq?=
 =?utf-8?B?Q3VvVlZYSUlOc2lBMlo3VnRGeFU4UTNNQjY0THJoRTN5RlN1QnhjYkZvekl5?=
 =?utf-8?B?K2ZnU0F1eTBZV0JJL1BZeDVmWitjZTNBdk84UjlCQTVveUxSQzkxbmZCemdZ?=
 =?utf-8?B?Y1QveGhXTGtiWGJydkE2UjE2TUk5K2tBd1NVUFY3eDJsQ3J0TVI2TlhjbTFT?=
 =?utf-8?B?TVhSRGFaOG04cldTb2ZjWEIwMU1WTUpkS0haKzFkbjQzblRlM3VINE1VcEZU?=
 =?utf-8?B?YkpydEFFNW5OOWROcEhoNWVZUmI4QlE0a0V2anBHdUhubUZ4dUpma1pqUjVD?=
 =?utf-8?B?MU5ObTc1dGU0TmVvVm0rNFF3YTZsNit5RVFqaGRCMHJYNGRVQkxFRSt5VytJ?=
 =?utf-8?B?UG5TWVV3cFNsS2RxemsweTBPbVVxWndCQTRPRUhLd3hEeGRpT0Q1WkhOZjMw?=
 =?utf-8?B?R2xqQys4NStBMHU0OEFIOFpEZHd1bFJlajJiOVNtYUdrUExua3dHUlJZNUR5?=
 =?utf-8?B?b2dDQzlUdzRLMU81enRBWVl3Nklvc1dtWXNMdG42R2FJY04yb1JOZlhETlph?=
 =?utf-8?B?ZmlJVUxpREpiRTZTWWwzWlc5N1hKWVE2RzRUaFRHblVBemdVQ2RjMUgyQkFV?=
 =?utf-8?B?cmJvVUNyYUc5SDBJMG1ac3NpQ3VSRm1meERkdWcvTGtkN3BrWStGNENYSklB?=
 =?utf-8?B?azhRQmdNN2hwcUxKUHd5cGFSYWNreDZGa3d0YWljNUtiVkdFeUNtSjZ3bXho?=
 =?utf-8?B?S05DT0FJOVRCeFZoQ2dMOThDUVc1cWZIWlJIaE9TUmNKYWFHclRMTTJjQ3Iy?=
 =?utf-8?B?QXpIUXRLL25EZE1PUDNTL3lSSVo4T3E1U290L3N5c3dnVmFvTURGdHV1YkdG?=
 =?utf-8?B?cGxXT3dIbXFBWldKTnhoQ2F6c3hJd2FiWFU2c2RSMVBoUkdQNUJBRE9YanBk?=
 =?utf-8?B?dDRoSGZON0V3MnpzZmQwRG8xaWxIbUJabzRKOUoyTTBhOUh2VDMrYWltVFpU?=
 =?utf-8?B?clpGZEw0ZC8vYjJKdC9MZ25oeWF5TmMzMXN3SWdCMW5ZQkFMRnBYWWlaMVp6?=
 =?utf-8?B?aGxjc2N4Rml3VzBhUWZSRFBWQmYwTVAxMVpsOHhXbnRtMkY4c0tHb1NxNEJW?=
 =?utf-8?B?ZnliV2pFNXdpVm5CdlFWRDJ0WHA3TjVVVzVDblhHR3QvZzVHSFNVanN4UDRT?=
 =?utf-8?B?TUxvU3pyRkg1QVZHek8rZTB1eTVvY1dra0o0K0VTUHNUVXRhK0ZNL0orTUd0?=
 =?utf-8?B?M2RUNUpNa3ZQdm5UUkg2ZnF0ZHlpSjJaaHdiY2RGUHR1L3FRWllJazdubm8r?=
 =?utf-8?B?VXl1QlFFUUZZa2ZKQUVPT3pNNVpDOWNoMWtsQm40RHVTTmp6ZGoya2RvRXM0?=
 =?utf-8?B?Y0Q2dGgzSGVUaG5GWnUzRzkxeFJWOGt4UlRTM2UxRE1PdWJLaWxwK0Z2REdT?=
 =?utf-8?B?Qk45bzJRWnRyaUZwUFVUZSthNFpoT3h1eiswMytKTFFsNTBhQld6V041OHV2?=
 =?utf-8?B?enBIcURPU1dadGNQRm9JWFU0aFhRV0NqbGdtbjBzRjROcjBnMlZmcE1mamhP?=
 =?utf-8?B?OVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 69c254fb-e73b-4166-3253-08dbb867cda6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 16:53:37.5689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BVNUkFMxGjjmnF0Q5WDcQMtp9ebjdFOgXhQ6y4IFZHlh393aXxrH4vy4fhsmYcraTUOGfXS750uT27jku7Scww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7306
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 18 Sep 2023 09:53:48 -0700 (PDT)


On 9/18/2023 5:32 AM, Hans de Goede wrote:
> Hi Jithu,
> 
> On 9/13/23 20:33, Jithu Joseph wrote:
>> This series adds IFS support for newer CPUs like Granite Rapids(GNR)
>> and Sierra Forest(SRF).
>>
>> There are changes in the IFS image loading and test flow to support
>> these new CPUs.
>>
>> Note to reviewers:
>>  - patch 01/10 adds a bit definition to arch/x86/.../msr-index.h,
>>   hence x86 maintainers are cc-d.
>>  - patch 05/10 modifies an existing tracepoint, cc Steven Rostedt
>>  - Rest are localized to IFS driver
>>
>> Jithu Joseph (10):
>>   platform/x86/intel/ifs: Store IFS generation number
>>   platform/x86/intel/ifs: Refactor image loading code
>>   platform/x86/intel/ifs: Image loading for new generations
>>   platform/x86/intel/ifs: Scan test for new generations
>>   trace: platform/x86/intel/ifs: Modify scan trace
>>   platform/x86/intel/ifs: Validate image size
>>   platform/x86/intel/ifs: Metadata validation for start_chunk
>>   platform/x86/intel/ifs: Add new CPU support
>>   platform/x86/intel/ifs: Add new error code
>>   platform/x86/intel/ifs: ARRAY BIST for Sierra Forest
>>
>>  arch/x86/include/asm/msr-index.h         |   2 +
>>  drivers/platform/x86/intel/ifs/ifs.h     |  47 +++++++
>>  include/trace/events/intel_ifs.h         |  16 +--
>>  drivers/platform/x86/intel/ifs/core.c    |  14 +-
>>  drivers/platform/x86/intel/ifs/load.c    | 159 +++++++++++++++++++++--
>>  drivers/platform/x86/intel/ifs/runtest.c |  68 +++++++++-
>>  6 files changed, 273 insertions(+), 33 deletions(-)
>>
>>
>> base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
> 
> Thank you for the patch series, please submit a new version addressing
> the various review-remarks.
> 

Will do ... Thanks

Jithu