Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp255893rdb; Mon, 18 Sep 2023 14:12:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRup+g0nvg2QFm0PQ0+nXALg1wA524FD3B/r8BAdnm+figf88Fp4vtCk3V4De/WbmLjuf1 X-Received: by 2002:a17:902:c94b:b0:1c3:ea60:73e2 with SMTP id i11-20020a170902c94b00b001c3ea6073e2mr10691932pla.27.1695071546478; Mon, 18 Sep 2023 14:12:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695071546; cv=none; d=google.com; s=arc-20160816; b=L263F71s+0/qlfxatQr+cMAoPoiTEv5+tS2EAVjXOf6MFyDFJ3pUQELtDnouUhwsl5 8sl2ZvIcQJSMTd8FqNEBjV+EoBiuCu/fDcGpOZWCF1N0lTE7QimS6G+DBNBdghQD/YMP 3Tqy1piyx7pA6Ek1ZzuLfEYV5tI4ITajFZxOGsQCbEKeidB+rQRr9di+LWyfx5zLM8FJ UIp0GTmdPq+a7H2ll0NF/yUHS4L+tqBS5uIUmt3xgTwfQwY9Y9fnwHzTFHDIX0NpUsWC TgLgLYsR4MjepTS+JWWXL3/PGICMUBOmSkSMy89MwJxYIGZq0L403IvbUwbkJm3xyPfU TyHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=xKtlW0iyTzRebdFC/O1vZSnlLpFo/qjfaLoHHexTksE=; fh=iPJpMkufr45eNU+JF4Tq7E4bNI7FpZdLBKkTp7jebGI=; b=YptPRw1ohA5CR774kIIvj2gm39xeZ5TH1ej3XLvuNbeewRMtC+XsUJYyE0I3waNM+s c2p6X4TbbQsLG51VCJYYyQWNstpNox/jXjIVUuExwdgoHCYNBMge1L6ugigAMDcknhu/ 4go4Lragu7rE+nUDOuuGmHtthPl9G9g/xwmH+nfSuJAm+l3ZknzdgqBRleLblCO9Yiac 2n39JS02173X+dn6x78Wg3bmaHTUgB8jI6HpoECURqR4TiVrPOP57mHOXLRyKi/9Rw3z txgDDICZRTF8GqOAlRMwAmAOMWTPlEwN4+lsVPylx9zMXqnSMsOlhFXqqMy7Onxs5YMX hLSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fHsmKqPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id ij30-20020a170902ab5e00b001c446f12975si5387852plb.447.2023.09.18.14.12.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 14:12:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fHsmKqPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B8301805F677; Mon, 18 Sep 2023 08:40:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbjIRPkh (ORCPT + 99 others); Mon, 18 Sep 2023 11:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjIRPkb (ORCPT ); Mon, 18 Sep 2023 11:40:31 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60AF5272A; Mon, 18 Sep 2023 08:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695051627; x=1726587627; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UJy+Gr8DwxN6Yt79AOixDnkfqZv5y9oXSAuQ2/xs+a4=; b=fHsmKqPjcf6ZIhdHGgLkY5QxY12iXb/ZzZ9Rd7y/FahX0o+nAHZCDmYi Yj+iDsV/duUeSJr8vDId7cGADF6DRVeK86+3voByUTXMPAH2r6txXF2gX TKm8MtSprom4KxKDwO1mCU1igH6xvcHhu9hlAzVanDYHIyf/lJx3nrQYm cGCQrlN1PhX5W+h/uk57n9euzlnU0s5rlDTUybnwFr5eOr+vJNfbaRCpO 1Lg7D1eu13SgqrD1YWLZU2mfNj63P4VmeOn6x7Dxcq6EEUNfPMlVMrxdd VH7/iwn4FKSv3I5luyAPr6WUNOMGlyE3lrz7fvZcUmS9WKfCDryFe7X0P g==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="376969087" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="376969087" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 06:50:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="889062962" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="889062962" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 06:49:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qiEdd-00000009Lhi-1iQG; Mon, 18 Sep 2023 16:50:09 +0300 Date: Mon, 18 Sep 2023 16:50:09 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Mark Pearson , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Pearson , Mark Gross Subject: Re: [PATCH v1 1/2] platform/x86: think-lmi: Replace kstrdup() + strreplace() with kstrdup_and_replace() Message-ID: References: <20230913092701.440959-1-andriy.shevchenko@linux.intel.com> <77bde3cf-ca94-1cdb-53d8-39df22f8c551@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77bde3cf-ca94-1cdb-53d8-39df22f8c551@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 08:40:35 -0700 (PDT) On Mon, Sep 18, 2023 at 02:30:28PM +0200, Hans de Goede wrote: > On 9/13/23 11:27, Andy Shevchenko wrote: > > Replace open coded functionalify of kstrdup_and_replace() with a call. > > > > Signed-off-by: Andy Shevchenko > > Thank you for the patches, but this one does not apply > cleanly. `git am -C1 ...` works for me. > Can you please rebase the series on top of my latest review-hans branch ? But fine, no problem, I'm about to send a v2, -- With Best Regards, Andy Shevchenko