Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp265471rdb; Mon, 18 Sep 2023 14:33:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgLKS10vKFdSXz/0JIXVoJeZKuPPEN9zZlmhDoYHhq6NScbjxe2Dj63MufUclz5Sf12VzX X-Received: by 2002:a17:903:1246:b0:1bc:3908:14d with SMTP id u6-20020a170903124600b001bc3908014dmr1004234plh.2.1695072837539; Mon, 18 Sep 2023 14:33:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695072837; cv=none; d=google.com; s=arc-20160816; b=SFVCxjWt9wjg5LVO4AbgT2cHgvBOzUzoaOb9dcv3htbgwv5sRHtxAlCdbTUJOiTbyO dwDYtWIBrOGS+s7S6XfQCrmbRPt56oYX6QFktq27GD+lqTYuLvGqYQYkC9q/wPrrys4x eGWhN3Pmolyoa6P8zszPl+bbOLsH4nhE+LWCBz9NySOXkamVlU1mFh2/Z/f38M7E/EXY 5yE2mtYqk5G4WHPvtGex1EXiTIbK15yTMljBYx7n3YI2KrPhkSAdsnxqlPqZFmHrqW44 k0+fEYkxDJ95LINFYXV36Up8vSOQEDUaHP9lk81g7eT77z1ul9fU8gD9ecvJoKzoJM+v 4+4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FZjlM/xpUzZ748krxWP8GI7hHRWPspTyoO+oZaLwlsM=; fh=j5n7Bc/ct4QuwiOycjROYqxBzM+pjpwuXXukaaxIALc=; b=K1vJDKUpFLvb58WZg4JcvR0EQFFUh361F490GPHVJyfOpMYPKbE2SGr4n+J4PsHtps FHLeIFoFmv5weu7TZnRhPPJZgYDwXRCAeJ4nKHsYOHNHHsVnGteHDb4zGomt76Dosvxx ON2j4XfrFKI5P+LBvfiW7STfifkJH/Sj0EJwkRaMgCrGMwwuzOtnZZpw+2yC0KGWX91Q rPRNwd/BlUkfYptyECSYfmUYqk54npiqFEH3z620rdjT7pfawNiJ6HnkNM9Z4TQMvHN+ 8Rlzi4cCv927N7SPDh1zwW9lLRmlfMuXgVyt2shWoVwp22xah9DHqoyUclCslMVAWqGy rkoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="o/lXBeKi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id s205-20020a632cd6000000b0054fe295d487si8374379pgs.434.2023.09.18.14.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 14:33:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="o/lXBeKi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C0629829E6FE; Mon, 18 Sep 2023 14:33:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbjIRVdx (ORCPT + 99 others); Mon, 18 Sep 2023 17:33:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjIRVdw (ORCPT ); Mon, 18 Sep 2023 17:33:52 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 507348E for ; Mon, 18 Sep 2023 14:33:47 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B348C433C8; Mon, 18 Sep 2023 21:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695072826; bh=HJnD3hDCAKtTDtsEuzBCabBIEMAOgegcnbNytmQ7rTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o/lXBeKiRldFnvNecwB87VK4iPzybzfdxFTpW7N7DEWOG0ePMwhWA1QBHQj7CZmOE rwJzCyjXxuHxmWV776xSnXJnCwS1Y0dtd49ta/JFo05fQvVVmUH9rfpcqiiHynzYD0 flE5SBBnlLaWbqmFb7RF8ps2D0Ihih5XNYo3kHtAHgWRfOaX8wu1HaIhcdh0iLlGUY KabrMyZUZcxyjJ9ucBFNbR4CiTALYZUcRIrBfnguxGFT2r2Y8y5skAJRpyLr+U9nqZ Vqe8hmZXeZDTvMroRHiK3s4IbOQCqckidhK+CPVHdLxFVrKwD6eqW0HmNH4e3LiZ6Z RVzOdVIeBJsIQ== Received: (nullmailer pid 1791762 invoked by uid 1000); Mon, 18 Sep 2023 21:33:28 -0000 Date: Mon, 18 Sep 2023 16:33:28 -0500 From: Rob Herring To: Kwanghoon Son Cc: p.zabel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jszhang@kernel.org, guoren@kernel.org, wefu@redhat.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, inki.dae@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Document th1520 reset control Message-ID: <20230918213328.GA1771303-robh@kernel.org> References: <20230918045125.4000083-1-k.son@samsung.com> <20230918045125.4000083-2-k.son@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230918045125.4000083-2-k.son@samsung.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 18 Sep 2023 14:33:54 -0700 (PDT) On Mon, Sep 18, 2023 at 04:51:23AM +0000, Kwanghoon Son wrote: > Add documentation to describe th1520 reset device > > Signed-off-by: Kwanghoon Son > --- > .../bindings/reset/thead,th1520-reset.yaml | 44 +++++++++++++++++++ > .../dt-bindings/reset/thead,th1520-reset.h | 9 ++++ > 2 files changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > create mode 100644 include/dt-bindings/reset/thead,th1520-reset.h > > diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > new file mode 100644 > index 000000000000..49ea8c6a331f > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/thead,th1520-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD th1520 SoC Reset Controller > + > +maintainers: > + - Kwanghoon Son > + > +properties: > + compatible: > + items: > + - const: thead,th1520-reset > + - const: syscon Why do you need "syscon"? Are there other functions? If so, please describe them in top-level "description". If not, drop "syscon" and use device_node_to_regmap() instead of syscon_node_to_regmap(). Rob