Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <ab54121d-04a2-497c-8c56-573608eb820e@infradead.org>
Date:   Mon, 18 Sep 2023 11:55:25 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] soundwire: bus: Make IRQ handling conditionally built
Content-Language: en-US
To:     Charles Keepax <ckeepax@opensource.cirrus.com>, vkoul@kernel.org
Cc:     yung-chuan.liao@linux.intel.com,
        pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
        linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
References: <20230918161026.472405-1-ckeepax@opensource.cirrus.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230918161026.472405-1-ckeepax@opensource.cirrus.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/18/23 09:10, Charles Keepax wrote:
> SoundWire has provisions for a simple callback for the IRQ handling so
> has no hard dependency on IRQ_DOMAIN, but the recent addition of IRQ
> handling was causing builds without IRQ_DOMAIN to fail. Resolve this by
> moving the IRQ handling into its own file and only add it to the build
> when IRQ_DOMAIN is included in the kernel.
> 
> Fixes: 12a95123bfe1 ("soundwire: bus: Allow SoundWire peripherals to register IRQ handlers")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309150522.MoKeF4jx-lkp@intel.com/
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>  drivers/soundwire/Makefile   |  4 +++
>  drivers/soundwire/bus.c      | 31 +++----------------
>  drivers/soundwire/bus_type.c | 11 +++----
>  drivers/soundwire/irq.c      | 59 ++++++++++++++++++++++++++++++++++++
>  drivers/soundwire/irq.h      | 43 ++++++++++++++++++++++++++
>  5 files changed, 115 insertions(+), 33 deletions(-)
>  create mode 100644 drivers/soundwire/irq.c
>  create mode 100644 drivers/soundwire/irq.h
> 

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

-- 
~Randy