Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp272231rdb; Mon, 18 Sep 2023 14:52:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAFBRhG3E86DLh93+bu8Kx7VDiTaxUUI1s6Hr/usD7taNszy0WMpWDhsk5OoOkFEIWfl/0 X-Received: by 2002:a05:6a21:7189:b0:157:eb32:e739 with SMTP id wq9-20020a056a21718900b00157eb32e739mr9510998pzb.32.1695073945583; Mon, 18 Sep 2023 14:52:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695073945; cv=none; d=google.com; s=arc-20160816; b=vTLDRQuCJ97gTo9G8yr4VYi3OQPH+Puew3l6Yq7Ii+Y8UWGylNAa1zpv/pX6Cn/bXK 6zN5ZUQG30lazmX1hQEKQqh6T2oQAH41ww+LqEKeMJ1m7n8oV2SStLbnh1WP4pFDU3fO qcNqiMHh7UMyTJqTAhZWkRx1Eifu5dghqPuXhZm0oq7AT1QK08Si4fUH7T66DPfJ9QnV Q5yQHIE85kfIMkRg3jkPXShkXkAoVswJKMtoAJzYerUawnQbSr2ICsThigLkj9yMpa2I J+sHOuCLF9rZIGLCoAkKgY9Oql352OJBRmtKe0bXRkPE/z6pEKInpgh308HJ/UM2mH8+ phSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=1wuXWfoShaYErwZYG6GsYlxB9uESfAN5ZYWeSZRWiFA=; fh=mxSlmeh7L5vBcfoLLoYBKYGPcfilWCF+qDcUd9iohrQ=; b=ATu838iZ+SqKhCwg5QhGPnLaRBSqZvh29qLKOZiLr7KivvG2qqNhOq6ORqJN8ACQxg PTcEDmAgoKBg0aZvVsx9yCv70fq0THQ7gCn/JTCXmRQ8mb1U5KjFmktPMJCGgfDse5TG e2VRf7WaGML31lVDBx6kfW7mjCP3KgOei6BCFOe/6rOaMzyy93OU3I9jiHic4o5xCmVz zuC6yCPBluFvKE0iN+7IZH+mUzEdz7mIoyv+qQS6dns9yR/t/n9YFYCKmp7D1lTqEJR9 tcQAndRdHyVaJZJuJXfz3UkFIVEq9R4/ZOwtdVx2ckRy9mzJOtjNSbOemkRK6qkBWEyR VpTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JVSK8J8D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id w14-20020a63b74e000000b005775a3ebf0asi8511570pgt.67.2023.09.18.14.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 14:52:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JVSK8J8D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DEF9D807329A; Mon, 18 Sep 2023 11:55:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjIRSzf (ORCPT + 99 others); Mon, 18 Sep 2023 14:55:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjIRSzf (ORCPT ); Mon, 18 Sep 2023 14:55:35 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDF02F7 for ; Mon, 18 Sep 2023 11:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=1wuXWfoShaYErwZYG6GsYlxB9uESfAN5ZYWeSZRWiFA=; b=JVSK8J8D6eDqgIonPoDJr3IfRQ 5meI3XznR0B6UCp1cO+R3TpARv3/Ug2pnPilVGQE/Vj2H3S7fz3tcjM2Ae5xn7uaHDT3+02Pg7BIc raONEFCQRd+zTfOABcLVHULWSwzxRqYnySxnfX6a4ZH8NpE9ucrp8LPDgm5bdIIQGqM2aevIwPkmS KhdAwbzKqHbrclyV21jV4fGBF68FcM21h6vIwmYwO0S4DVz6Xu++yxry2iUt4ndzZfd7OiknRP46x RQIpPisXwkz4nEubxRrbCD4Dl+IpJuPOXwdUdQzh5xet3o+BCx4nHANkE3yYKlugWD68EDzepJRAU jwrPTZew==; Received: from [2601:1c2:980:9ec0::9fed] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qiJP3-00G73e-2K; Mon, 18 Sep 2023 18:55:25 +0000 Message-ID: Date: Mon, 18 Sep 2023 11:55:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soundwire: bus: Make IRQ handling conditionally built Content-Language: en-US To: Charles Keepax , vkoul@kernel.org Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com References: <20230918161026.472405-1-ckeepax@opensource.cirrus.com> From: Randy Dunlap In-Reply-To: <20230918161026.472405-1-ckeepax@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 11:55:43 -0700 (PDT) On 9/18/23 09:10, Charles Keepax wrote: > SoundWire has provisions for a simple callback for the IRQ handling so > has no hard dependency on IRQ_DOMAIN, but the recent addition of IRQ > handling was causing builds without IRQ_DOMAIN to fail. Resolve this by > moving the IRQ handling into its own file and only add it to the build > when IRQ_DOMAIN is included in the kernel. > > Fixes: 12a95123bfe1 ("soundwire: bus: Allow SoundWire peripherals to register IRQ handlers") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202309150522.MoKeF4jx-lkp@intel.com/ > Signed-off-by: Charles Keepax > --- > drivers/soundwire/Makefile | 4 +++ > drivers/soundwire/bus.c | 31 +++---------------- > drivers/soundwire/bus_type.c | 11 +++---- > drivers/soundwire/irq.c | 59 ++++++++++++++++++++++++++++++++++++ > drivers/soundwire/irq.h | 43 ++++++++++++++++++++++++++ > 5 files changed, 115 insertions(+), 33 deletions(-) > create mode 100644 drivers/soundwire/irq.c > create mode 100644 drivers/soundwire/irq.h > Acked-by: Randy Dunlap Tested-by: Randy Dunlap Thanks. -- ~Randy