Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20230916091641.776031-1-yangjihong1@huawei.com> <CAM9d7ciuLiYRT0tyhXSrZLqe9uhLNw=zGK4Tj6-GG5WQALP3-Q@mail.gmail.com>
In-Reply-To: <CAM9d7ciuLiYRT0tyhXSrZLqe9uhLNw=zGK4Tj6-GG5WQALP3-Q@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 18 Sep 2023 15:37:01 -0700
Message-ID: <CAM9d7cjiwUPvjk=bA5Hc3HFNGKQWDrSRVrZ0FAAScfywz_2Gkw@mail.gmail.com>
Subject: Re: [PATCH] perf test: Fix test-record-dummy-C0 failure for supported
 PERF_FORMAT_LOST feature kernel
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sat, Sep 16, 2023 at 10:36 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> On Sat, Sep 16, 2023 at 2:18 AM Yang Jihong <yangjihong1@huawei.com> wrote:
> >
> > For kernel that supports PERF_FORMAT_LOST, attr->read_format has
> > PERF_FORMAT_LOST bit. Update expected value of
> > attr->read_format of test-record-dummy-C0 for this scenario.
> >
> > Before:
> >
> >   # ./perf test 17 -vv
> >    17: Setup struct perf_event_attr                                    :
> >   --- start ---
> >   test child forked, pid 1609441
> >   <SNIP>
> >   running './tests/attr/test-record-dummy-C0'
> >     'PERF_TEST_ATTR=/tmp/tmpm3s60aji ./perf record -o /tmp/tmpm3s60aji/perf.data --no-bpf-event -e dummy -C 0 kill >/dev/null 2>&1' ret '1', expected '1'
> >   expected read_format=4, got 20
> >   FAILED './tests/attr/test-record-dummy-C0' - match failure
> >   test child finished with -1
> >   ---- end ----
> >   Setup struct perf_event_attr: FAILED!
> >
> > After:
> >
> >   # ./perf test 17 -vv
> >    17: Setup struct perf_event_attr                                    :
> >   --- start ---
> >   test child forked, pid 1609441
> >   <SNIP>
> >   running './tests/attr/test-record-dummy-C0'
> >     'PERF_TEST_ATTR=/tmp/tmppa9vxcb7 ./perf record -o /tmp/tmppa9vxcb7/perf.data --no-bpf-event -e dummy -C 0 kill >/dev/null 2>&1' ret '1', expected '1'
> >   <SNIP>
> >   test child finished with 0
> >   ---- end ----
> >   Setup struct perf_event_attr: Ok
> >
> > Reported-by: Namhyung Kim <namhyung@kernel.org>
> > Closes: https://lore.kernel.org/all/CAM9d7cgNH2+zhSAmA3en_6as915UsF25MoLbfjE350tAP43Bog@mail.gmail.com/
>
> I'll change it to follow the existing style like
>
> Fixes: d50ad02cb39a ("perf test: Add perf_event_attr test for record
> dummy event")
>
> > Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
>
> Tested-by: Namhyung Kim <namhyung@kernel.org>

Applied to perf-tools-next, thanks!

Namhyung