Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <0f25cc55-b353-9bec-009f-589b04e36cb4@linaro.org>
Date:   Mon, 18 Sep 2023 22:15:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 09/12] dt-bindings: serial: snps-dw-apb-uart: Add Sophgo
 SG2042 uarts
Content-Language: en-US
To:     Chen Wang <unicorn_wang@outlook.com>,
        Wang Chen <unicornxw@gmail.com>,
        linux-riscv@lists.infradead.org, conor@kernel.org,
        aou@eecs.berkeley.edu, krzysztof.kozlowski+dt@linaro.org,
        palmer@dabbelt.com, paul.walmsley@sifive.com, robh+dt@kernel.org
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        jszhang@kernel.org, guoren@kernel.org, chao.wei@sophgo.com,
        xiaoguang.xing@sophgo.com,
        Emil Renner Berthing <emil.renner.berthing@canonical.com>
References: <20230915072517.118266-1-wangchen20@iscas.ac.cn>
 <c4aa8d45-1248-5656-a045-a475ec737c0f@linaro.org>
 <MA0P287MB033226287163E5E20485433DFEFBA@MA0P287MB0332.INDP287.PROD.OUTLOOK.COM>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <MA0P287MB033226287163E5E20485433DFEFBA@MA0P287MB0332.INDP287.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/09/2023 14:49, Chen Wang wrote:
> Hi, Krzysztof,
> 
> I see Emil has clarified in anther email, I copy it here for your quick 
> reference:
> 
>  >Sophgo and StarFive are not the same company. Sophgo are using RISC-V 
> cores from T-Head and StarFive are using cores from SiFive.
> 
> And SG2042 is chip from Sophgo, and JH7100 is chip from StarFive.
> 
> So I think it should be better to use a new entry for sg2042, what do 
> you think?

We talked about different things. Previous discussion was about
compatibility. Here, you should just not create your own enum, because
there is no single need. Just put it to previous enum.

Best regards,
Krzysztof