Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Mon, 18 Sep 2023 18:24:48 +0200
From:   David Sterba <dsterba@suse.cz>
To:     Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, Qu Wenru <wqu@suse.com>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] btrfs: fix 64bit division in
 btrfs_insert_striped_mirrored_raid_extents
Message-ID: <20230918162448.GI2747@suse.cz>
Reply-To: dsterba@suse.cz
References: <20230918-rst-updates-v1-0-17686dc06859@wdc.com>
 <20230918-rst-updates-v1-1-17686dc06859@wdc.com>
 <CAMuHMdWM3_cj4Nb96pZQfErx7n+0Cd7RUQZV+bpvr1Tz5T3sgw@mail.gmail.com>
 <e12a171e-d3b8-401e-b01a-9440f5c75293@wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e12a171e-d3b8-401e-b01a-9440f5c75293@wdc.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Precedence: bulk

On Mon, Sep 18, 2023 at 03:03:10PM +0000, Johannes Thumshirn wrote:
> On 18.09.23 16:19, Geert Uytterhoeven wrote:
> > Hi Johannes,
> > 
> > On Mon, Sep 18, 2023 at 4:14 PM Johannes Thumshirn
> > <johannes.thumshirn@wdc.com> wrote:
> >> Fix modpost error due to 64bit division on 32bit systems in
> >> btrfs_insert_striped_mirrored_raid_extents.
> >>
> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > 
> > Thanks for your patch!
> > 
> >> --- a/fs/btrfs/raid-stripe-tree.c
> >> +++ b/fs/btrfs/raid-stripe-tree.c
> >> @@ -148,10 +148,10 @@ static int btrfs_insert_striped_mirrored_raid_extents(
> >>   {
> >>          struct btrfs_io_context *bioc;
> >>          struct btrfs_io_context *rbioc;
> >> -       const int nstripes = list_count_nodes(&ordered->bioc_list);
> >> -       const int index = btrfs_bg_flags_to_raid_index(map_type);
> >> -       const int substripes = btrfs_raid_array[index].sub_stripes;
> >> -       const int max_stripes = trans->fs_info->fs_devices->rw_devices / substripes;
> >> +       const size_t nstripes = list_count_nodes(&ordered->bioc_list);
> >> +       const enum btrfs_raid_types index = btrfs_bg_flags_to_raid_index(map_type);
> >> +       const u8 substripes = btrfs_raid_array[index].sub_stripes;
> >> +       const int max_stripes = div_u64(trans->fs_info->fs_devices->rw_devices, substripes);
> > 
> > What if the quotient does not fit in a signed 32-bit value?
> 
> Then you've bought a lot of HDDs ;-)
> 
> Jokes aside, yes this is theoretically correct. Dave can you fix 
> max_stripes up to be u64 when applying?

I think we can keep it int, or unsigned int if needed, we can't hit such
huge values for rw_devices. The 'theoretically' would fit for a machine
with infinite resources, otherwise the maximum number of devices I'd
expect is a few thousand.