Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 18 Sep 2023 14:51:11 -0600
From:   Alex Williamson <alex.williamson@redhat.com>
To:     oushixiong <oushixiong@kylinos.cn>
Cc:     Jason Gunthorpe <jgg@ziepe.ca>, Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Brett Creeley <brett.creeley@amd.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/pds: Add missing PCI_IOV depends
Message-ID: <20230918145111.6473b148.alex.williamson@redhat.com>
In-Reply-To: <20230906014942.1658769-1-oushixiong@kylinos.cn>
References: <20230906014942.1658769-1-oushixiong@kylinos.cn>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed,  6 Sep 2023 09:49:42 +0800
oushixiong <oushixiong@kylinos.cn> wrote:

> From: Shixiong Ou <oushixiong@kylinos.cn>
>=20
> If PCI_ATS isn't set, then pdev->physfn is not defined.
> it causes a compilation issue:
>=20
> ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: =E2=80=98struct pci_dev=
=E2=80=99 has no member named =E2=80=98physfn=E2=80=99; did you mean =E2=80=
=98is_physfn=E2=80=99?
>   165 |   __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
>       |                              ^~~~~~
>=20
> So adding PCI_IOV depends to select PCI_ATS.
>=20
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
> ---
>  drivers/vfio/pci/pds/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to vfio for-linus branch for v6.6.  Thanks,

Alex

>=20
> diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig
> index 407b3fd32733..6eceef7b028a 100644
> --- a/drivers/vfio/pci/pds/Kconfig
> +++ b/drivers/vfio/pci/pds/Kconfig
> @@ -3,7 +3,7 @@
> =20
>  config PDS_VFIO_PCI
>  	tristate "VFIO support for PDS PCI devices"
> -	depends on PDS_CORE
> +	depends on PDS_CORE && PCI_IOV
>  	select VFIO_PCI_CORE
>  	help
>  	  This provides generic PCI support for PDS devices using the VFIO