Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Mon, 18 Sep 2023 19:18:31 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     syzbot <syzbot+c225dea486da4d5592bd@syzkaller.appspotmail.com>,
        akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        llvm@lists.linux.dev, mike.kravetz@oracle.com,
        muchun.song@linux.dev, nathan@kernel.org, ndesaulniers@google.com,
        syzkaller-bugs@googlegroups.com, trix@redhat.com
Subject: Re: [syzbot] [fs?] [mm?] WARNING in page_copy_sane
Message-ID: <ZQiUd5FAtPXP3OC8@casper.infradead.org>
References: <0000000000003a7ffb06059ac0dd@google.com>
 <d576d53b-bce4-21d3-fddd-0e26e9b44f89@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d576d53b-bce4-21d3-fddd-0e26e9b44f89@oracle.com>
Precedence: bulk

On Mon, Sep 18, 2023 at 01:10:21PM -0500, Sidhartha Kumar wrote:
> @@ -382,8 +382,8 @@ static ssize_t hugetlbfs_read_iter(struct kiocb *iocb, struct iov_iter *to)
>  			/*
>  			 * We have the page, copy it to user space buffer.
>  			 */
> -			copied = copy_page_to_iter(page, offset, want, to);
> -			put_page(page);
> +			copied = copy_page_to_iter(&folio->page, offset, want, to);

copy_folio_to_iter() please.  Yes, I know it's just a wrapper today.

> +			folio_put(folio);
>  		}
>  		offset += copied;
>  		retval += copied;
> -- 
> 2.41.0
>