Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Mon, 18 Sep 2023 18:19:20 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc:     Jay Monkman <jtm@lopingdog.com>, devicetree@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
        Arndt Schuebel <Arndt.Schuebel@onsemi.com>
Subject: Re: [PATCH 3/4] net: phy: Add GPIO and DT support to NCN26000
Message-ID: <ba9e7fb4-e19f-454c-9542-cb53b45f6b99@lunn.ch>
References: <ZQf1Nx+2amtUZulX@lopingdog.com>
 <b279bee8-1613-23ea-a339-9d3fdde9d0eb@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b279bee8-1613-23ea-a339-9d3fdde9d0eb@linux.dev>
Precedence: bulk

On Mon, Sep 18, 2023 at 11:40:36AM +0100, Vadim Fedorenko wrote:
> > +static int ncn26000_gpio_request(struct gpio_chip *gc, unsigned int offset)
> > +{
> > +	struct ncn26000_priv *priv = gpiochip_get_data(gc);
> > +
> > +	if (offset > 2)
> > +		return -ENODEV;
> > +
> > +	if (priv->gpiomask & (1 << offset))
> 
> it's better to use BIT(offset) here

Hi Vadim

When replying, please trim the email to just the relevant text.

     Thanks
	Andrew