Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
CC:     Prashant Malani <pmalani@chromium.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "chrome-platform@lists.linux.dev" <chrome-platform@lists.linux.dev>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "bleung@chromium.org" <bleung@chromium.org>
Subject: RE: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport
 Alternatemode 2.1 Support
Thread-Topic: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport
 Alternatemode 2.1 Support
Thread-Index: AQHZ5RQ8pkufV0PHy0qNPGaCC0iZ37AWY6qAgAWtvqCABDHIgIAAibbg
Date:   Mon, 18 Sep 2023 16:19:24 +0000
Message-ID: <MWHPR11MB00487D601B4CDD3A387BA0E3A9FBA@MWHPR11MB0048.namprd11.prod.outlook.com>
References: <20230912005752.1532888-1-utkarsh.h.patel@intel.com>
 <20230912005752.1532888-4-utkarsh.h.patel@intel.com>
 <CACeCKacmH19niA7gWTZCj89ZmFth0LWvkMYasYwUvVHrmFKCZw@mail.gmail.com>
 <MWHPR11MB0048848CD12DC750417E7264A9F6A@MWHPR11MB0048.namprd11.prod.outlook.com>
 <ZQgEbXDNZ+Ap/HiV@kuha.fi.intel.com>
In-Reply-To: <ZQgEbXDNZ+Ap/HiV@kuha.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/XC8B7mLpJgx2CaHaioEujyl9jZF3krORUKY3PaL0pFAyoDBJf1rdy6Z7MED?=
 =?us-ascii?Q?uXjrTLZXTUX07isAbXZiyfem94jPKQzq8LmWOKrTCfIo8xCNUobEst9xJMmq?=
 =?us-ascii?Q?bUw5maO/IGW4CDry1R8cziRG3rTe6p18dBvVgOhLcGN6/xxo/WgSDhbyb8gB?=
 =?us-ascii?Q?JIF6Wy5287rCnYMd/GQN4lpma6K7K2t6SMt9kYa5PyK0Mi23pSwbaeJ/ZAcK?=
 =?us-ascii?Q?Ck2rsUF97tG0e8YKWm83Jz9vaXXhvXYYJ7NF6qIr7bdnpIhhVaCgtelQrHGJ?=
 =?us-ascii?Q?bXvwBQ61DhWiqFrCw67yAg0ZR0XSp4rGdEsmlvijTJyeF22cdb8/zI67He8u?=
 =?us-ascii?Q?m7eP3o8k1+PT/onOJnCtweyHNIkxNEvrNIedYJtazKTGEV+wZTpOYHXCv/kG?=
 =?us-ascii?Q?JKjIQpxyLe05zYOSt8JO8aJ0N7ezQ0ZQzCN3Z96jHu38wnvlTRIxg0dA+fHX?=
 =?us-ascii?Q?5M1knn9nhpDPJNyZnIXSMnUg0xUCD1sqLv5nSLnd1KtD/iLfBz6rwqO2qPCE?=
 =?us-ascii?Q?bNHiYsCmXrn53lh4VnjqGalAVPr5IEbgle5PNwAGtbFLNGEZTcxfuc29gXAc?=
 =?us-ascii?Q?jpIxVuHlqzgkdI8nd4ij+97hAx+pln/+oMZWinnb+7Mop9zPgjnh9DOXeIWV?=
 =?us-ascii?Q?FkCLWZZ5yBVN+bB6B/ULbocrj4eP5Mca6ymkLs3SPgJfBV8snTxZz/yApfKU?=
 =?us-ascii?Q?LSNqyJ+tORKvipdpG9XBn/968hyqwrnKj2q94D5e5djoFaBXHdgLQHIdiV80?=
 =?us-ascii?Q?a335AAggNPDlZGZdYc2be8cQv6pQ5sR82pLcjldzc+36mCYDLeiffhUbLI8T?=
 =?us-ascii?Q?IjDDmieQpIjpFB9faROUA6ZmGwHtf9YiUp0dSV7ER/gcAqM5//hW0bl1WHE+?=
 =?us-ascii?Q?DJaAs4MmwP+iA40X2QR0TDVXi2RvBywC/KtjGueXsPrHexYFbs3cWbHGTZ5Q?=
 =?us-ascii?Q?BLg/yxusEYU8Fw+ZSFHi1PCgRMmed9r5vxbQ6FO8xK7xSmK4X6nUr2b+g1LU?=
 =?us-ascii?Q?yRmeFNfI16mLK7nKhC7aor4tbRZs+Vp1ozOEsk1afUf565M1O72ZDvmbWBMJ?=
 =?us-ascii?Q?YtyBxaWe49Y8GXn+QzGtdSnPjgNpgqZhC1XIbDhLtn2HlvXd+EnTCig6Rx8k?=
 =?us-ascii?Q?bUESO7m/F3SqapeeKHnhxWgDNduwd1+3n8yFL0zRhQOwid6c2J98lUVms/oA?=
 =?us-ascii?Q?5aEyepMsfl0zbg6PWmjRfy1rz5OC6FFY17Kf88dDP5mv+pjBEtrcvRqNatMb?=
 =?us-ascii?Q?GVksWA0oo6vjt2CgIZFTq3BTjs5egIFj8eeLEra76KnVXRyKF3xV1kQ1LpRx?=
 =?us-ascii?Q?zg3Ih4v0PJsjNYbWjwaJJ9nDC1RR6ujzVVL/DGbwh87LzeBgtZCSf5MvkUso?=
 =?us-ascii?Q?VIuPkr92/VXI9yRyzOVI2Jzf9nlznCvMbxY83764+q/HyrXQKMW+008nOLDa?=
 =?us-ascii?Q?KmqOg3ZBLSPCR6AKG16x1szXYkGyOGaNvvw2iZRdL01cfxKx9HH5YwNsc+wf?=
 =?us-ascii?Q?NUd254tPieBffM+nPAik3RmtmveyVnM/Pupp6Kn8A+LEDKxBxT7nfe/evljJ?=
 =?us-ascii?Q?RqFmJIQyB4qW6zOSDVcAe7j6iwqNq5TrGDpYReUA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0048.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3b09329-5b30-406c-b773-08dbb8630653
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2023 16:19:25.0118
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: m2X+r3I3v90EYMts85xCnmgS5t/nylsp49HCP4qs2+jaEQ80pFqKCwU5MpZ7r4kmFYAqTPLo9pfn10YnViR+birGgkwI4B9o8kySz31hTp8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5393
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 09:27:38 -0700 (PDT)

Hi Heikki,

Thank you for the feedback.

> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Sent: Monday, September 18, 2023 1:04 AM
> To: Patel, Utkarsh H <utkarsh.h.patel@intel.com>
> Cc: Prashant Malani <pmalani@chromium.org>; linux-kernel@vger.kernel.org;
> linux-usb@vger.kernel.org; chrome-platform@lists.linux.dev;
> andriy.shevchenko@linux.intel.com; bleung@chromium.org
> Subject: Re: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displaypo=
rt
> Alternatemode 2.1 Support
>=20
> On Fri, Sep 15, 2023 at 04:01:44PM +0000, Patel, Utkarsh H wrote:
>=20
> > > > b057250704e8..3a747938cdab 100644
> > > > --- a/include/linux/usb/pd_vdo.h
> > > > +++ b/include/linux/usb/pd_vdo.h
> > > > @@ -376,6 +376,7 @@
> > > >          | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) &=
 0x3) << 5   \
> > > >          | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7))
> > > >
> > > > +#define VDO_TYPEC_CABLE_SPEED(vdo)     ((vdo) & 0x7)
> > >
> > > I would suggest putting this header modification in a separate
> > > patch; if for some reason we have to revert the Chrome part of the
> > > change, then we won't rip this part out too (some other driver down
> > > the road may use the macro and would break if it were to be
> > > removed). But I'll leave it to Heikki to determine whether that is pr=
eferred.
> > >
> > Heikki,  What's your preference here?
>=20
> I think separate patch for this like Prashant said.

I will add and re-send the removed [PATCH v2 3/5]  in the next version. =20

Sincerely,
Utkarsh Patel.