Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp373490rdb; Mon, 18 Sep 2023 19:22:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkqI6k548ajNi1E1HwMmSAbcSqV9mZk+/fDmLYBpVeAEzGW463l+wZi56+mgP2o2RCx9Xi X-Received: by 2002:a05:6358:7f1c:b0:13a:d269:bd22 with SMTP id p28-20020a0563587f1c00b0013ad269bd22mr11867185rwn.25.1695090152226; Mon, 18 Sep 2023 19:22:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695090152; cv=none; d=google.com; s=arc-20160816; b=dERYVVNMbCl18OuF2yLOhW+gjtw+8DAZ/Y9LlTWQ6/IzjQnOoL1L5Vu7h/o2dAR5/l aH4C81wPHlEm1Y8jeFV/xN7o6YjBI2/ih4eTanOs7AGwLhnjcRofoqXM59qoii0V2V/c 8FQQ5gV2hooH17qFyJypFcOvbRKmsPPEpIgTyhil+nhSnHOmmARduoFlF7qHWRCe95Bv gj7j62X9Cctb+f4x6XvGJh4K1us7gq3yjVdsgHK/hQgdakwR4OG0rHC1VP3Am9rv4OXQ 55g9jEcZLsOvIYizcU7hOiA9XSUBoaw1Kse8qOYBZSW2UJiqzZKFwf8n6F24N8fyDoX4 3cnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=RKiCOByDL96hotvveoALRujHhJ+JRMIfwmxKHnT1o6A=; fh=8G8DDOWeXTrynpwGxRU6+UU65RCHDEs7NE1+CluhaKI=; b=Q39u/bcZHzuAO+nouAhPyXOTEn6DIjcZizKj+IYcIYE7e5fvGjy9WV+7kU68s8GXdo r6afFK4wjJxX15sehS7nnXjZ1/EU4UIM0no/bFy5hbpeq/0ldYPHcvcfr5diI64uyWyc naZlSHNM+BOnqV2NtTVOLQHQM2Wa58KUMj3vOpESYtoTouneLxl6/4QUoVbzE2HKcDuI yvJKvT4jX0B55lCBgpfeqP0/LnheLTCZbT/t5ElPE3m80zgd2ZnyhFe1jWXjW0b3vXkP zfRt9pxu6qm6siZz2e+hcwyQAKLIYQFR4Fp5wCkSKp3h1PM+v9KQ7VyLcP4szAaxz/Wu aQsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@szeredi.hu header.s=google header.b=ovYugzXq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=szeredi.hu Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id g17-20020a056a001a1100b0069023e4bca8si8968239pfv.214.2023.09.18.19.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 19:22:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@szeredi.hu header.s=google header.b=ovYugzXq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=szeredi.hu Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E59F481441A0; Mon, 18 Sep 2023 08:48:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229802AbjIRPr5 (ORCPT + 99 others); Mon, 18 Sep 2023 11:47:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbjIRPr4 (ORCPT ); Mon, 18 Sep 2023 11:47:56 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5559C1FD4 for ; Mon, 18 Sep 2023 08:47:40 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9ad8bf9bfabso612112966b.3 for ; Mon, 18 Sep 2023 08:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1695051845; x=1695656645; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RKiCOByDL96hotvveoALRujHhJ+JRMIfwmxKHnT1o6A=; b=ovYugzXqR24d+lTEOmoVDv06w5IN9NQnd8fXHzcD0FbdnlQtbzSwlWy8QU+QVzqdQZ VIi8fBlqse5eWJMmukN1knIC2V7qR/y7bKEHW3nf+m8BZixoyYJ8YVrQ6ODeZsoSw1aR 4/+7XX8wAZaCSzDt2NHY39j3u3PY+VGtxBK/4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695051845; x=1695656645; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RKiCOByDL96hotvveoALRujHhJ+JRMIfwmxKHnT1o6A=; b=CZiAQ2wfTrJdSaJydhtgSHgIhqMJzfj3wD4g0iVEgg3dusl1rYjb451xwBBmYYzPcW t9xgaL2HOmQmKWoaTVMG17QJGVnwYbhly14ABc7gW1jZUVK20lNKMQsXj45IFbJeB6XC 325h0FOfiOr9MfypTRZ7IlOfEnIJupgL9IujCYLFYlmKki3qQPj3LS3qrIsNOQSxmLVX lwK3kaVL9Q/5J45tnaD5R3kdGyLxub8mJ7Jxpwo+1x1U+5rleW3R7jjhdrDhGsChne+g 8QPMGkoxF8VzywETigZe6BknlB8/fZG68MddEudGkikXCgQY8zdpKQ3tnRVnkYreMY4K 4PYA== X-Gm-Message-State: AOJu0Yy4SsCyc0hOWT9m0pUv6YuaYXJUlCL3LeBD/2NwQfZVxmy7wMwA cVL2XmkjkXGbAbHkrBAhWNrlZAggDj0+1c4G/vIVdW09rgpHy4s+ X-Received: by 2002:a17:906:3102:b0:99c:e38d:e484 with SMTP id 2-20020a170906310200b0099ce38de484mr8115574ejx.6.1695047562459; Mon, 18 Sep 2023 07:32:42 -0700 (PDT) MIME-Version: 1.0 References: <20230913152238.905247-1-mszeredi@redhat.com> <20230913152238.905247-3-mszeredi@redhat.com> <20230914-salzig-manifest-f6c3adb1b7b4@brauner> <20230914-lockmittel-verknallen-d1a18d76ba44@brauner> <20230918-grafik-zutreffen-995b321017ae@brauner> <20230918-hierbei-erhielten-ba5ef74a5b52@brauner> In-Reply-To: <20230918-hierbei-erhielten-ba5ef74a5b52@brauner> From: Miklos Szeredi Date: Mon, 18 Sep 2023 16:32:30 +0200 Message-ID: Subject: Re: [RFC PATCH 2/3] add statmnt(2) syscall To: Christian Brauner Cc: Miklos Szeredi , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-man@vger.kernel.org, linux-security-module@vger.kernel.org, Karel Zak , Ian Kent , David Howells , Al Viro , Christian Brauner , Amir Goldstein Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 18 Sep 2023 08:48:32 -0700 (PDT) On Mon, 18 Sept 2023 at 16:25, Christian Brauner wrote: > The system call should please have a proper struct like you had in your > first proposal. This is what I'm concerned about: > > int statmount(u64 mnt_id, > struct statmnt __user *st, > size_t size, > unsigned int flags) > > instead of taking an void pointer. So you are not concerned about having ascii strings returned by the syscall? I thought that was the main complaint. Thanks, Miklos