Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Mon, 18 Sep 2023 10:31:07 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "sunfishho12@gmail.com" <sunfishho12@gmail.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
Subject: RE: [PATCH 3/3] tools/testing/cxl: Document test configurations
Message-ID: <6508895bb6e7d_3921be2943@iweiny-mobl.notmuch>
References: <20230426-cxl-fixes-v1-0-870c4c8b463a@intel.com>
 <20230426-cxl-fixes-v1-3-870c4c8b463a@intel.com>
 <650553545372e_d7cc829461@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <650553545372e_d7cc829461@dwillia2-xfh.jf.intel.com.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZTXNfy5/evSgcjLo4X9sUiKyz0WJ/NFbGzg+DCeVeJfct4bUTfbvxpDSytoA?=
 =?us-ascii?Q?NqoCYE3f7j6gOEr4y9C7WPLB2wbg6YXoNTnYhjWwM68SQ20HaSDdAijE7XcR?=
 =?us-ascii?Q?E99LUSQmYzmN3MIBl9kiKN47VDN4zV26p+Yf5IpKf9CYhEDYvjBoUCLAK+od?=
 =?us-ascii?Q?XxNxm7FmFpBQt3KtWhAnMeUUMAppncW6aeCaNFy5AaiBh++WZAYXjpAFF8Zr?=
 =?us-ascii?Q?OsAr2y2UuMllgknITuR2cXhMso/tZduujRctu7tQ5Kn49ITVQMPnlj2j7lqh?=
 =?us-ascii?Q?8uIupVBzvQV4eS6OCi2J72w+18ELIh2BhOSaXB/FXCtfcxkLKLaRo83zU0hX?=
 =?us-ascii?Q?Q3dYWAGAwSGGP2hDxMTMfcRdeHRMSYHUi2YsVHK94RVOqPTWkVfy7cS3pfUK?=
 =?us-ascii?Q?O6Bm/v2pKsGkHtZJ6onyb4FkrQBfjBjGC1bHFgO8xGjo/Y9npqxnt1B8+N5K?=
 =?us-ascii?Q?pB0zQQg0YCiS9DOGLB5S4FvcNgx3nqMqK8L/Yx8gE62Y78nAmf+yWG2QXHQZ?=
 =?us-ascii?Q?ft3d/aSP80qHzmIG6vT8JjQADdglAKWIFFzLHHziRC6nnMDf1wmAjb3IXw84?=
 =?us-ascii?Q?8V8TJvXf8w1q1E6rBh54xYxRNKvb8hdtMCstXNXqyrKEMY+gT1to54Ih0Eex?=
 =?us-ascii?Q?1cgT1AwF1SLMDNIG4R70BqNW/U+FiosreyzPKz9Y43PqMikQHukjFHWhmDFF?=
 =?us-ascii?Q?SyrbfFkpE+XbbOTmKXDrBo/QqHGfOEB54sHSDy8F0j64ZQpUR0m69laz8+h7?=
 =?us-ascii?Q?jJ5i5c5gkqMnMnLJ+D3MnOe7ugzNP6lDMI1vjIlL/8Th7CEheDqZqW8b4mnZ?=
 =?us-ascii?Q?DKjZVlcjkyteUXprDRTzJXpmPAHoWlXcdY2G6MD+hQB7+R3LpUZ2PCrjxTrK?=
 =?us-ascii?Q?v6FcXGcceQu8Mn/otVppFoFcHDwG2c2XPxJ1yEWPcv8gXOSbEu5bh1SlVblb?=
 =?us-ascii?Q?CvK+WOSquUf4WYdIh7TSbik0krERmlUXfZg0VY4Qlee48nUwqjloPw+h/RJV?=
 =?us-ascii?Q?5/8CMDwVvvkypy5tQUBKEXJiHohGWsgeqLd+fwBzhl7SiTZkQCZca+mCbF5z?=
 =?us-ascii?Q?+zVbuWqTxfCNlBCtJvJVGre0O2Ugdk4SfAKemtecA/LMO+0gY7B0QD8BMeBn?=
 =?us-ascii?Q?vDgqa/qya3hgiNDSVv1lMOEspCmmR2JvCJ/XlPf+b26sEJOPSX1xEhJqyzrt?=
 =?us-ascii?Q?vT5uX20p1WkfJaCseIuUi4D9K396khNVY7aqJrFf2ngmIjrjwWcWVStIViP/?=
 =?us-ascii?Q?oARO44uUW8ygCN/vmFQ6pq2/1Gd7xzqoGqE/buvPIrkzOEzzKbmewYle8Dqj?=
 =?us-ascii?Q?gK20GYvwscMpwHGJbXYovX0/HRQs9LMzF4bqOHRKroIFbgpqDcO8vd0kPIvB?=
 =?us-ascii?Q?9Dh1oOc+GNq3gcQidYz5XlDYJmPaiyLq6+9gU2lzFTkB3Eq8huqfjZF0JkT+?=
 =?us-ascii?Q?uVRMUi7ySGPppvEeBQumfGysTOj9Z9vcfxFPOHP9fsOmcCRILX7Uu3NEdflo?=
 =?us-ascii?Q?cw5Rg/y/hTKRlr8Vvs01XgmneJxTq+3hpZii6twNGIv8PQaqkVWzI0pihcaC?=
 =?us-ascii?Q?BYFOF+QU/MZ0DcP3WFOmCjOoCiU+C50oxYjc9K19?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec276137-c982-4678-f94d-08dbb86d0c8f
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 17:31:10.7176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QugAd7lETBqUJLTnsUUJW3mI9leSqIo029ai3CM7kh+5JKMnGZKlrCuBCZvAXkpwY+p4Wiv/SI/Fm2BMb49hQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5406
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 18 Sep 2023 10:32:21 -0700 (PDT)

+Matthew Ho

Dan Williams wrote:
> Ira Weiny wrote:
> > The devices created, their relationship, and intended testing purpose is
> > not extremely clear, especially for those unfamiliar with cxl-test.
> > 
> > Document the purpose of each hierarchy.  Add ASCII art to show the
> > relationship of devices.  Group the device declarations together based
> > on the hierarchies.
> > 
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > ---
> >  tools/testing/cxl/test/cxl.c | 75 ++++++++++++++++++++++++++++++++++++++++++--
> >  1 file changed, 73 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> > index bf00dc52fe96..bd38a5fb60ae 100644
> > --- a/tools/testing/cxl/test/cxl.c
> > +++ b/tools/testing/cxl/test/cxl.c
> > @@ -23,6 +23,31 @@ static int interleave_arithmetic;
> >  #define NR_CXL_PORT_DECODERS 8
> >  #define NR_BRIDGES (NR_CXL_HOST_BRIDGES + NR_CXL_SINGLE_HOST + NR_CXL_RCH)
> >  
> > +/*
> > + * Interleave testing
> > + *
> > + *             +---------------+                            +---------------+
> > + *             | host_bridge[0]|                            | host_bridge[1]|
> > + *             +-/---------\---+                            +--/---------\--+
> > + *             /-           -\                               /-           -\
> > + *           /-               -\                           /-               -\
> > + *   +-------------+         +-------------+       +-------------+      +-------------+
> > + *   |root_port[0] |         |root_port[1] |       |root_port[2] |      |root_port[3] |
> > + *   +------|------+         +------|------+       +------|------+      +------|------+
> > + *          |                       |                     |                    |
> > + *  +-------|-------+       +-------|-------+     +-------|-------+    +-------|-------+
> > + *  |switch_uport[0]|       |switch_uport[1]|     |switch_uport[2]|    |switch_uport[3]|
> > + *  +---|-------|---+       +---/-------|---+     +---/-------|---+    +---|-------\---+
> > + *      |       \              /        \            /        \            /        \
> > + * +----|----++--|------++---------++----|----++---------++----|----++----|----++---------+
> > + * |switch   ||switch   ||switch   ||switch   ||switch   ||switch   ||switch   ||switch   |
> > + * |_dport[0]||_dport[1]||_dport[2]||_dport[3]||_dport[4]||_dport[5]||_dport[6]||_dport[7]|
> > + * +----|----++--|------++----|----++----|----++----|----++----|----++----|----++----|----+
> > + *      |        |            |          |          |          |          |          |
> > + *  +---|--+   +-|----+   +---|--+   +---|--+    +--|---+  +---|--+   +---|--+   +---|--+
> > + *  |mem[0]|   |mem[1]|   |mem[2]|   |mem[3]|    |mem[4]|  |mem[5]|   |mem[6]|   |mem[7]|
> > + *  +------+   +------+   +------+   +------+    +------+  +------+   +------+   +------+
> > + */
> 
> Circling back to merge this I realize that the numbering is off. For
> example a snippet from "cxl list -BPT -b cxl_test"
> 
>     "ports:root3":[
>       {
>         "port":"port5",
>         "host":"cxl_host_bridge.1",
>         "depth":1,
>         "nr_dports":2,
>         "dports":[
>           {
>             "dport":"cxl_root_port.1",
>             "id":1
>           },
>           {
>             "dport":"cxl_root_port.3",
>             "id":3
>           }
>         ],
> 
> This is due to the modulo math at setup time. I only noticed this
> because I wanted a diagram to refer to when doing some recent
> extensions.

:-(  I did not realize this detail.

> 
> I wonder if we could just use "cxl list" to maintain this diagram, or
> maybe circle back and use this to keep an image up to date on a web page
> somewhere:
> 
> https://lore.kernel.org/linux-cxl/cover.1660895649.git.sunfishho12@gmail.com/

I forgot about this and this is a nice idea.  Did that support land?

Ira