Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp379098rdb; Mon, 18 Sep 2023 19:42:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0EBc++/9+ThwYwp/rqm1N6Z1OzCrx5ONwn2l3EQa96LEkQDpmTx+VJarCy5DOYehK+gL4 X-Received: by 2002:a17:902:ce82:b0:1c3:6163:210a with SMTP id f2-20020a170902ce8200b001c36163210amr10915388plg.60.1695091331383; Mon, 18 Sep 2023 19:42:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695091331; cv=none; d=google.com; s=arc-20160816; b=1ACdWhOMHHw4254VKaaWLOGuWw+Xrex+NXTQ/YL5VrAx+rKjlV1E3U6O4Ju2/9RDKB jpJYGoOABCaET2BQCQr1Bc7dD3ust5EquHbDii/5HUQnrg0W0QfQabSoIs7R+vn8ArBw ubrJfSU/Y3hFiBJnkwtOPLNDgpL+o4gHNg3JnVwZzUZXpQ1kMHZS5rZYz3iIGJZbYYq4 UDjhzJahdxp5Vcfb7/rj9vlMREOAm/2h27N2gvgbNP/7TiaPiMSVTTUtw8mE0EAQ+gVT s2Ykh7oMQyV2iHDXihAVi5F1LBrXJuySi1vqXE0U9+qEj/rBl4xEWsdgGI5fXWantQNI xWQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Cp66IhSBrYmkHbt50HzaqJU73kMgi/EP93b/VBNooM4=; fh=Udcd0rjT89+L6AAzaeQcnCfOqz+M2QXMGeGvfI1Me40=; b=ogf6DeB+gKctk0jT2sbzA6kvXP2Yf1ZX7F8D9k/TqHlxq/uIdIofrday5anjo7QUF0 a3wUiDruCcXVFd7CAkynPWRbOs1CsvpEBGDzTsRO913NdeIhnfJNs7O7d1hYNSW1XzKY wLZEh6l+N9QKCuZgeYj5dxsKlhgU6KTlKDUEVaNAwc2pRJKImg2brWQxjCkJrRVll+Ws 81qdxkUMH+11sakLGxnmnTtmKUB6wgE7GcEsbJW+PP32g2hL1XvGsF9teLRMj9mAYRJE ExEOt0XnqLD1F4b15mSVBVGTa/5aMiPWERkLrgcmmmMc4JTgGVKnr3WfQiz4CI3qaq4p HV5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MWT622GW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id b12-20020a170902650c00b001c3e8a6748asi8576985plk.644.2023.09.18.19.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 19:42:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MWT622GW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id CB87F8201B37; Mon, 18 Sep 2023 19:42:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231138AbjISCl5 (ORCPT + 99 others); Mon, 18 Sep 2023 22:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbjISCl4 (ORCPT ); Mon, 18 Sep 2023 22:41:56 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB30A103; Mon, 18 Sep 2023 19:41:49 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16387C433C8; Tue, 19 Sep 2023 02:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695091309; bh=d1IZx8UK1CDA7AVvxc1IXofSfVgZ8uZQf8/yrQRmxbA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MWT622GWcY9r6x1FJ2GheJkLYRFmgwwRJITIDdq8UR4RVyvM3VZOb6bBofZ3GN6ve I1S/q5jVet3xq8YtjU6aFO+kr4UmEZx4Y8HnVh5NajsfACC0BTo5p0n0IsejcOPqgv qr1F0aK6rBimeOSvIejw+FBy1Z7kUeKddvwHEpDUgHalZNfcXH+j81XXym8pT3nP0v jzQ31/sbQU+xZ5I0G8RmieIDo9rYO4NnxFYokaG2NQQ5GqF33nCrx9clze8JnW9cu+ aiU2qXdVh7Y3z+mCG6LiaDrbopvnlv1iCiZK14PDQX9U2Uo8/Z7Hch6/gTnmXoRku2 u1dzec9rfOs3g== Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-52e5900cf77so6371391a12.2; Mon, 18 Sep 2023 19:41:48 -0700 (PDT) X-Gm-Message-State: AOJu0YzJtv2nlHeUVHhidsQaohZDcdWg90g1rdksu+04zr3Wpm5tbYM5 oQrRPt+VEa0f+DubX7mvHgsD15kCFEeWqRpNZL8= X-Received: by 2002:a50:fe92:0:b0:530:46c:8e36 with SMTP id d18-20020a50fe92000000b00530046c8e36mr8341093edt.17.1695091307442; Mon, 18 Sep 2023 19:41:47 -0700 (PDT) MIME-Version: 1.0 References: <20230915014949.1222777-1-zhaotianrui@loongson.cn> <20230915014949.1222777-3-zhaotianrui@loongson.cn> In-Reply-To: From: Huacai Chen Date: Tue, 19 Sep 2023 10:41:35 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v21 02/29] LoongArch: KVM: Implement kvm module related interface To: zhaotianrui Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , WANG Xuerui , Greg Kroah-Hartman , loongarch@lists.linux.dev, Jens Axboe , Mark Brown , Alex Deucher , Oliver Upton , maobibo@loongson.cn, Xi Ruoyao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 18 Sep 2023 19:42:07 -0700 (PDT) On Tue, Sep 19, 2023 at 10:38=E2=80=AFAM zhaotianrui wrote: > > > =E5=9C=A8 2023/9/17 =E4=B8=8B=E5=8D=8812:21, Huacai Chen =E5=86=99=E9=81= =93: > > Hi, Tianrui, > > > > On Fri, Sep 15, 2023 at 9:50=E2=80=AFAM Tianrui Zhao wrote: > >> Implement LoongArch kvm module init, module exit interface, > >> using kvm context to save the vpid info and vcpu world switch > >> interface pointer. > >> > >> Reviewed-by: Bibo Mao > >> Signed-off-by: Tianrui Zhao > >> --- > >> arch/loongarch/kvm/main.c | 367 ++++++++++++++++++++++++++++++++++++= ++ > >> 1 file changed, 367 insertions(+) > >> create mode 100644 arch/loongarch/kvm/main.c > >> > >> diff --git a/arch/loongarch/kvm/main.c b/arch/loongarch/kvm/main.c > >> new file mode 100644 > >> index 0000000000..0deb9273d8 > >> --- /dev/null > >> +++ b/arch/loongarch/kvm/main.c > >> @@ -0,0 +1,367 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Copyright (C) 2020-2023 Loongson Technology Corporation Limited > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include "trace.h" > >> + > >> +static struct kvm_context __percpu *vmcs; > >> +struct kvm_world_switch *kvm_loongarch_ops; > >> +unsigned long vpid_mask; > >> +static int gcsr_flag[CSR_MAX_NUMS]; > >> + > >> +int get_gcsr_flag(int csr) > >> +{ > >> + if (csr < CSR_MAX_NUMS) > >> + return gcsr_flag[csr]; > >> + > >> + return INVALID_GCSR; > >> +} > >> + > >> +static inline void set_gcsr_sw_flag(int csr) > >> +{ > >> + if (csr < CSR_MAX_NUMS) > >> + gcsr_flag[csr] |=3D SW_GCSR; > >> +} > >> + > >> +static inline void set_gcsr_hw_flag(int csr) > >> +{ > >> + if (csr < CSR_MAX_NUMS) > >> + gcsr_flag[csr] |=3D HW_GCSR; > >> +} > >> + > >> +/* > >> + * The default value of gcsr_flag[CSR] is 0, and we use this > >> + * function to set the flag to 1(SW_GCSR) or 2(HW_GCSR) if the > >> + * gcsr is software or hardware. It will be used by get/set_gcsr, > >> + * if gcsr_flag is HW we should use gcsrrd/gcsrwr to access it, > >> + * else use sw csr to emulate it. > >> + */ > >> +static void kvm_init_gcsr_flag(void) > >> +{ > >> + set_gcsr_hw_flag(LOONGARCH_CSR_CRMD); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_PRMD); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_EUEN); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_MISC); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_ECFG); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_ESTAT); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_ERA); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_BADV); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_BADI); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_EENTRY); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBIDX); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBEHI); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBELO0); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBELO1); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_ASID); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_PGDL); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_PGDH); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_PWCTL0); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_PWCTL1); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_STLBPGSIZE); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_RVACFG); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_CPUID); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_PRCFG1); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_PRCFG2); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_PRCFG3); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_KS0); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_KS1); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_KS2); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_KS3); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_KS4); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_KS5); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_KS6); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_KS7); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TMID); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TCFG); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TVAL); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_CNTC); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_LLBCTL); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBRENTRY); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBRBADV); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBRERA); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBRSAVE); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBRELO0); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBRELO1); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBREHI); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_TLBRPRMD); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_DMWIN0); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_DMWIN1); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_DMWIN2); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_DMWIN3); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_MWPS); > >> + set_gcsr_hw_flag(LOONGARCH_CSR_FWPS); > >> + > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IMPCTL1); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IMPCTL2); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_MERRCTL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_MERRINFO1); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_MERRINFO2); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_MERRENTRY); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_MERRERA); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_MERRSAVE); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_CTAG); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DEBUG); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DERA); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DESAVE); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PRCFG1); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PRCFG2); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PRCFG3); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PGD); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_TINTCLR); > >> + > >> + set_gcsr_sw_flag(LOONGARCH_CSR_FWPS); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_FWPC); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_MWPS); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_MWPC); > >> + > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB0ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB0MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB0CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB0ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB1ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB1MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB1CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB1ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB2ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB2MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB2CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB2ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB3ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB3MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB3CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB3ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB4ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB4MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB4CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB4ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB5ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB5MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB5CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB5ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB6ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB6MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB6CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB6ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB7ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB7MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB7CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_DB7ASID); > >> + > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB0ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB0MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB0CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB0ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB1ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB1MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB1CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB1ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB2ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB2MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB2CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB2ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB3ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB3MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB3CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB3ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB4ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB4MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB4CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB4ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB5ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB5MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB5CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB5ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB6ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB6MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB6CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB6ASID); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB7ADDR); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB7MASK); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB7CTRL); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_IB7ASID); > >> + > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PERFCTRL0); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PERFCNTR0); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PERFCTRL1); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PERFCNTR1); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PERFCTRL2); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PERFCNTR2); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PERFCTRL3); > >> + set_gcsr_sw_flag(LOONGARCH_CSR_PERFCNTR3); > >> +} > >> + > >> +static void kvm_update_vpid(struct kvm_vcpu *vcpu, int cpu) > >> +{ > >> + struct kvm_context *context; > >> + unsigned long vpid; > >> + > >> + context =3D per_cpu_ptr(vcpu->kvm->arch.vmcs, cpu); > >> + vpid =3D context->vpid_cache + 1; > >> + if (!(vpid & vpid_mask)) { > >> + /* finish round of 64 bit loop */ > >> + if (unlikely(!vpid)) > >> + vpid =3D vpid_mask + 1; > >> + > >> + /* vpid 0 reserved for root */ > >> + ++vpid; > >> + > >> + /* start new vpid cycle */ > >> + kvm_flush_tlb_all(); > >> + } > >> + > >> + context->vpid_cache =3D vpid; > >> + vcpu->arch.vpid =3D vpid; > >> +} > >> + > >> +void kvm_check_vpid(struct kvm_vcpu *vcpu) > >> +{ > >> + struct kvm_context *context; > >> + bool migrated; > >> + unsigned long ver, old, vpid; > >> + int cpu; > >> + > >> + cpu =3D smp_processor_id(); > >> + /* > >> + * Are we entering guest context on a different CPU to last ti= me? > >> + * If so, the vCPU's guest TLB state on this CPU may be stale. > >> + */ > >> + context =3D per_cpu_ptr(vcpu->kvm->arch.vmcs, cpu); > >> + migrated =3D (vcpu->cpu !=3D cpu); > >> + > >> + /* > >> + * Check if our vpid is of an older version > >> + * > >> + * We also discard the stored vpid if we've executed on > >> + * another CPU, as the guest mappings may have changed without > >> + * hypervisor knowledge. > >> + */ > >> + ver =3D vcpu->arch.vpid & ~vpid_mask; > >> + old =3D context->vpid_cache & ~vpid_mask; > >> + if (migrated || (ver !=3D old)) { > >> + kvm_update_vpid(vcpu, cpu); > >> + trace_kvm_vpid_change(vcpu, vcpu->arch.vpid); > >> + vcpu->cpu =3D cpu; > >> + } > >> + > >> + /* Restore GSTAT(0x50).vpid */ > >> + vpid =3D (vcpu->arch.vpid & vpid_mask) << CSR_GSTAT_GID_SHIFT; > >> + change_csr_gstat(vpid_mask << CSR_GSTAT_GID_SHIFT, vpid); > >> +} > >> + > >> +static int kvm_loongarch_env_init(void) > >> +{ > >> + struct kvm_context *context; > >> + int cpu, order; > >> + void *addr; > >> + > >> + vmcs =3D alloc_percpu(struct kvm_context); > >> + if (!vmcs) { > >> + pr_err("kvm: failed to allocate percpu kvm_context\n")= ; > >> + return -ENOMEM; > >> + } > >> + > >> + kvm_loongarch_ops =3D kzalloc(sizeof(*kvm_loongarch_ops), GFP_= KERNEL); > >> + if (!kvm_loongarch_ops) { > >> + free_percpu(vmcs); > >> + vmcs =3D NULL; > >> + return -ENOMEM; > >> + } > >> + /* > >> + * There will be problem in world switch code if there > >> + * is page fault reenter, since pgd register is shared > >> + * between root kernel and kvm hypervisor. World switch > >> + * entry need be unmapped area, cannot be tlb mapped area. > >> + * In future if hw pagetable walking is supported, or there > >> + * is separate pgd registers between root kernel and kvm > >> + * hypervisor, copying about world switch code will not be use= d. > >> + */ > >> + > >> + order =3D get_order(kvm_vector_size + kvm_enter_guest_size); > >> + addr =3D (void *)__get_free_pages(GFP_KERNEL, order); > >> + if (!addr) { > >> + free_percpu(vmcs); > >> + vmcs =3D NULL; > >> + kfree(kvm_loongarch_ops); > >> + kvm_loongarch_ops =3D NULL; > >> + return -ENOMEM; > >> + } > >> + > >> + memcpy(addr, kvm_vector_entry, kvm_vector_size); > >> + memcpy(addr + kvm_vector_size, kvm_enter_guest, kvm_enter_gues= t_size); > > Why memcpy? In our internal repo, we use kvm_vector_entry and > > kvm_enter_guest directly. The long comments above make me nervous > > because Loongson-3A6000 already supports hardware pagetable walker. > > > > Huacai > As mentioned in the comments, it need not this memcpy if hardware page > walk is supported in 3A6000. But why in our internal repo we don't use memcpy() but kvm can still work on Loongson-3A5000? Huacai > > Thanks > Tianrui Zhao > > > >> + flush_icache_range((unsigned long)addr, (unsigned long)addr + > >> + kvm_vector_size + kvm_enter_guest_size= ); > >> + kvm_loongarch_ops->guest_eentry =3D addr; > >> + kvm_loongarch_ops->enter_guest =3D addr + kvm_vector_size; > >> + kvm_loongarch_ops->page_order =3D order; > >> + > >> + vpid_mask =3D read_csr_gstat(); > >> + vpid_mask =3D (vpid_mask & CSR_GSTAT_GIDBIT) >> CSR_GSTAT_GIDB= IT_SHIFT; > >> + if (vpid_mask) > >> + vpid_mask =3D GENMASK(vpid_mask - 1, 0); > >> + > >> + for_each_possible_cpu(cpu) { > >> + context =3D per_cpu_ptr(vmcs, cpu); > >> + context->vpid_cache =3D vpid_mask + 1; > >> + context->last_vcpu =3D NULL; > >> + } > >> + > >> + kvm_init_fault(); > >> + kvm_init_gcsr_flag(); > >> + > >> + return 0; > >> +} > >> + > >> +static void kvm_loongarch_env_exit(void) > >> +{ > >> + unsigned long addr; > >> + > >> + if (vmcs) > >> + free_percpu(vmcs); > >> + > >> + if (kvm_loongarch_ops) { > >> + if (kvm_loongarch_ops->guest_eentry) { > >> + addr =3D (unsigned long)kvm_loongarch_ops->gue= st_eentry; > >> + free_pages(addr, kvm_loongarch_ops->page_order= ); > >> + } > >> + kfree(kvm_loongarch_ops); > >> + } > >> +} > >> + > >> +static int kvm_loongarch_init(void) > >> +{ > >> + int r; > >> + > >> + if (!cpu_has_lvz) { > >> + kvm_info("hardware virtualization not available\n"); > >> + return -ENODEV; > >> + } > >> + r =3D kvm_loongarch_env_init(); > >> + if (r) > >> + return r; > >> + > >> + return kvm_init(sizeof(struct kvm_vcpu), 0, THIS_MODULE); > >> +} > >> + > >> +static void kvm_loongarch_exit(void) > >> +{ > >> + kvm_exit(); > >> + kvm_loongarch_env_exit(); > >> +} > >> + > >> +module_init(kvm_loongarch_init); > >> +module_exit(kvm_loongarch_exit); > >> + > >> +#ifdef MODULE > >> +static const struct cpu_feature loongarch_kvm_feature[] =3D { > >> + { .feature =3D cpu_feature(LOONGARCH_LVZ) }, > >> + {}, > >> +}; > >> +MODULE_DEVICE_TABLE(cpu, loongarch_kvm_feature); > >> +#endif > >> -- > >> 2.39.1 > >> > >