Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <73a90202-1127-4469-a46d-7986343c51b1@quicinc.com>
Date:   Tue, 19 Sep 2023 09:59:54 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add SM4450 interconnect
 provider driver
To:     Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <djakov@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_tsoni@quicinc.com>, <quic_shashim@quicinc.com>,
        <quic_kaushalk@quicinc.com>, <quic_tdas@quicinc.com>,
        <quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>,
        <kernel@quicinc.com>
References: <20230915020129.19611-1-quic_tengfan@quicinc.com>
 <20230915020129.19611-3-quic_tengfan@quicinc.com>
 <dc209ac7-7a06-449b-a198-ce6fb3ba7ff7@linaro.org>
From:   Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <dc209ac7-7a06-449b-a198-ce6fb3ba7ff7@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 9/15/2023 8:43 PM, Konrad Dybcio 写道:
> On 15.09.2023 04:01, Tengfei Fan wrote:
>> Add driver for the Qualcomm interconnect buses found in SM4450 based
>> platforms. The topology consists of several NoCs that are controlled
>> by a remote processor that collects the aggregated bandwidth for each
>> master-slave pairs.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
> [...]
> 
>> +static struct qcom_icc_bcm bcm_acv_disp = {
>> +	.name = "ACV",
>> +	.num_nodes = 1,
>> +	.nodes = { &ebi_disp },
>> +};
>> +
>> +static struct qcom_icc_bcm bcm_mc0_disp = {
>> +	.name = "MC0",
>> +	.num_nodes = 1,
>> +	.nodes = { &ebi_disp },
>> +};
>> +
>> +static struct qcom_icc_bcm bcm_mm0_disp = {
>> +	.name = "MM0",
>> +	.num_nodes = 1,
>> +	.nodes = { &qns_mem_noc_hf_disp },
>> +};
>> +
>> +static struct qcom_icc_bcm bcm_sh0_disp = {
>> +	.name = "SH0",
>> +	.num_nodes = 1,
>> +	.nodes = { &qns_llcc_disp },
>> +};
>> +
>> +static struct qcom_icc_bcm bcm_sh1_disp = {
>> +	.name = "SH1",
>> +	.num_nodes = 1,
>> +	.nodes = { &qnm_pcie_disp },
>> +};
> """
> v1 -> v2:
>    - remove DISP related paths
> """
> 
> you sure?
> 
> + I still see _disp nodes..
> 
> Konrad

Hi Konrad,
only removed SLAVE_MNOC_HF_MEM_NOC_DISP related code actually as V1 comment.

-- 
Thx and BRs,
Tengfei Fan