Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp411620rdb; Mon, 18 Sep 2023 21:30:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOnOKqSlIQqk0uE0W7RDws1g8uaV0J1VMHbE9n0+FJFgetdT/Yd7KHOjuVmT1l99OXxIfj X-Received: by 2002:a05:6870:468e:b0:1bb:90c3:bb09 with SMTP id a14-20020a056870468e00b001bb90c3bb09mr12742295oap.9.1695097853446; Mon, 18 Sep 2023 21:30:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695097853; cv=none; d=google.com; s=arc-20160816; b=PbSPatQOpiRig33+Ds/1HLcJsPS4WnVlzH9628yQsKrF7o17cqnHEWeGLWaRCTXMzf LuF9seQSVxxUH/KrPRNZk2DcMB8emekbchNhPTBnzZ14jLZm0xWFfwGt7m586ErQUVGF wO0QGU3ZJWQU17j9iDFwItNwdJtH4xcMPhmxIZCH2Y1LtqVt0A44UEqtZzmLSBKqT61M 55yyzMSL2F2o3I3bvFEAIqHq2MUgnvajEylcfmvdPB3ucv9EqHf1C4ESnIW8orz4VvBC 9F7c0ZOfWt50dtGMR1rjTNCMZcpCcfnoYPH32S2Rhx72oc1PWEftisgLIB63BMXXA6xb AJoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=E+y6i7Uy3ptI05N3BdEAal9Zna1e1py5vdDPokjWDf0=; fh=Dv0G23nNIENCUFCTcIRIyajz90+iEXC6BU2lsg0dJwk=; b=zp1DKdxfPCH5kKHLhdx3Y1ry1Y37Tj4CTG9ARZrPR/WIyHAa5FrO89rdpKL/ku3r2M O0LHtB3LmOLHaFOMty1qOMN8Q/uWymhGRqf3KLWE9mBAsiX52lbqzFCbbCKF6rjQO24o eae8fHOgxmhftAGXsYs/Q6EA1v8riQ+ddCe5e4V5xkybYCc9FLq/r7zRyUMccqMo5sIX mSAtVn8pP9QkfR58fb75WRZHtNUbzHr8lA+cIEraJkV/1xVC4M7Od9GY/4jUgYTu7fXz NHijFsAYeXfDqNtoqjfqIkvNqgqfeulK1NDIMxAbqIAwFt43UkEQQxS2CGqJyMDtqvUH Ajmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=MPSRdH5c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id i66-20020a636d45000000b00577f4d85fd7si8786374pgc.316.2023.09.18.21.30.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 21:30:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=MPSRdH5c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A12F480B79D2; Mon, 18 Sep 2023 13:58:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbjIRU6t (ORCPT + 99 others); Mon, 18 Sep 2023 16:58:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbjIRU6i (ORCPT ); Mon, 18 Sep 2023 16:58:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27741126; Mon, 18 Sep 2023 13:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=E+y6i7Uy3ptI05N3BdEAal9Zna1e1py5vdDPokjWDf0=; b=MPSRdH5cuQwBb2HKMH1EW3ROFG DiEUEwpKkRIDsszmJCSZxx+BVpQkkbks8NhPN3rLQFjk3kHI7n0G0Ug4kRXIdtsSFgs71YWYwdjm6 +KeUOpbEoxE4Ny9Addv56f7H/vGLxCLPnxuJCusBgMQFsHDrpTt0h/qRxhZLnVgkkakkWw242mdYC ieLV3HTX8iTkm0c4aC4jC4uism9GuXJcmLkt3O+hZe9tNwLv0lDeV5Gg8Wj0hokYcdvA0vdufXjiM Q1iSeEW+EkZnKZ9nOiCM/JJeSvoR2JT1xTy1W1d2EajQI3vWFhX1YRCHum7GHiEGKRQkBgZ1Pz8il EMI6ncVw==; Received: from [2601:1c2:980:9ec0::9fed] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qiLK6-00GLLs-0j; Mon, 18 Sep 2023 20:58:26 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Nikita Travkin , Sebastian Reichel , linux-pm@vger.kernel.org Subject: [PATCH] power: supply: pm8916_lbc: observe EXTCON config setting Date: Mon, 18 Sep 2023 13:58:25 -0700 Message-ID: <20230918205825.25864-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 18 Sep 2023 13:58:51 -0700 (PDT) When CONFIG_EXTCON=m and CONFIG_CHARGER_PM8916_LBC=y, there are build errors. Fix them by having CHARGER_PM8916_LBC depend on the setting of EXTCON. aarch64-linux-ld: drivers/power/supply/pm8916_lbc.o: in function `pm8916_lbc_charger_state_changed_irq': pm8916_lbc.c:(.text+0xe8): undefined reference to `extcon_set_state_sync' aarch64-linux-ld: drivers/power/supply/pm8916_lbc.o: in function `pm8916_lbc_charger_probe': pm8916_lbc.c:(.text+0x638): undefined reference to `devm_extcon_dev_allocate' aarch64-linux-ld: pm8916_lbc.c:(.text+0x650): undefined reference to `devm_extcon_dev_register' aarch64-linux-ld: pm8916_lbc.c:(.text+0x688): undefined reference to `extcon_set_state_sync' Fixes: f8d7a3d21160 ("power: supply: Add driver for pm8916 lbc") Signed-off-by: Randy Dunlap Cc: Nikita Travkin Cc: Sebastian Reichel Cc: linux-pm@vger.kernel.org --- drivers/power/supply/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -643,6 +643,7 @@ config BATTERY_PM8916_BMS_VM config CHARGER_PM8916_LBC tristate "Qualcomm PM8916 Linear Battery Charger support" depends on MFD_SPMI_PMIC || COMPILE_TEST + depends on EXTCON || !EXTCON help Say Y here to add support for Linear Battery Charger block found in some Qualcomm PMICs such as PM8916. This hardware