Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 19 Sep 2023 14:19:04 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Li zeming <zeming@nfschina.com>
Cc:     naveen.n.rao@linux.ibm.com, anil.s.keshavamurthy@intel.com,
        davem@davemloft.net, linux-kernel@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] kprobes: Remove unnecessary initial values of variables
Message-Id: <20230919141904.ef53e6663e4c5400ae913622@kernel.org>
In-Reply-To: <20230919012823.7815-1-zeming@nfschina.com>
References: <20230919012823.7815-1-zeming@nfschina.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 19 Sep 2023 09:28:23 +0800
Li zeming <zeming@nfschina.com> wrote:

> ri and sym is assigned first, so it does not need to initialize the
> assignment.
> 

Yes, thanks for fixing!

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  kernel/kprobes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index ca385b61d546..82b2a366d496 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1990,7 +1990,7 @@ NOKPROBE_SYMBOL(__kretprobe_find_ret_addr);
>  unsigned long kretprobe_find_ret_addr(struct task_struct *tsk, void *fp,
>  				      struct llist_node **cur)
>  {
> -	struct kretprobe_instance *ri = NULL;
> +	struct kretprobe_instance *ri;
>  	kprobe_opcode_t *ret;
>  
>  	if (WARN_ON_ONCE(!cur))
> @@ -2817,7 +2817,7 @@ static int show_kprobe_addr(struct seq_file *pi, void *v)
>  {
>  	struct hlist_head *head;
>  	struct kprobe *p, *kp;
> -	const char *sym = NULL;
> +	const char *sym;
>  	unsigned int i = *(loff_t *) v;
>  	unsigned long offset = 0;
>  	char *modname, namebuf[KSYM_NAME_LEN];
> -- 
> 2.18.2
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>