Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Huan Yang <link@vivo.com>
To:     SeongJae Park <sj@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        damon@lists.linux.dev (open list:DATA ACCESS MONITOR),
        linux-mm@kvack.org (open list:DATA ACCESS MONITOR),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Huan Yang <link@vivo.com>
Subject: [PATCH v2] mm/damon/core: remove unnecessary si_meminfo invoke.
Date:   Tue, 19 Sep 2023 10:00:57 +0800
Message-Id: <20230919020057.29388-1-link@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1pIhWYvW0rX73qCfvWiMBEE8udJsaSh6a+e5BUd3Xn8M90EFZuoVVLFW+cDi?=
 =?us-ascii?Q?cEncqtn6ZhZVcP2NyHRHvEobDO6PQb1WswQzUJV6eXmo8MTez9ZyEQ5D7Bgr?=
 =?us-ascii?Q?60N7JSiho0pk1SRUz8HmyYKCE+MByANJUZtKo0XMn2gCl2XzDG9azarsIVuY?=
 =?us-ascii?Q?wPAetCWfTo9fNCX46x57hkIDOGtqqMBRcbgQLe+EyagRs26/wdNLmCzVVntQ?=
 =?us-ascii?Q?hSX+2zmO9BlBSVEnBjcy12jcHHVe8fc1/pyQJyKp/j5CxCudpEHoG3xKp94t?=
 =?us-ascii?Q?afsN7h/QlTxoddp9iiajW6R+Ojb/EFzfeXexM+FyylxHjkmVcHcI1e8Nz7Ty?=
 =?us-ascii?Q?YhocJN3ao3JNd+KUazHHx13m1k5NQQzbqMMYOVGgqd/FjAIZlRXAG2RFELjB?=
 =?us-ascii?Q?JA5hbx/eia/U3V0JoN0ErcmiX+j191yh4dJLExceM1EB3mZGcEyLuJu5XzTW?=
 =?us-ascii?Q?/Zf3myvBLZol52Itqbub5tEr0wrMpjo1eTk62I3Gtm5vl/QoIP5HNYu3Y0vR?=
 =?us-ascii?Q?nMTJjC7awSCd70yYtrkqvr2rtV9etObRG+Jww+xwIm7gV3ao7yHxk1v1MHhQ?=
 =?us-ascii?Q?SlGgirhz8X3WRpiofpbey+iqhTqnYvkXxffBL2Dshh4fVT4t2Y4o3LBAYvGf?=
 =?us-ascii?Q?QwVLVkPp5/21bVkLRwohjddZXUgLcXmwpgEIe5hEa6poWmk3tCW4lCuxlqPu?=
 =?us-ascii?Q?ZPJQXzNcfpizI3EF6FXaHW+hgBh3i2Yy+N0ewoS3N/GjJP/Brm56K5C4PcR3?=
 =?us-ascii?Q?UdkzUe2bza+OP5JSDxKYQ1pNPxYZehQDteSlLDWl/Ut19s11e743h/uXgzAY?=
 =?us-ascii?Q?JvapCC9pO9v5l5Wtzr4M0R92pqP6NMbQ3RfB2/BMIx/bqIM9vzrMDcRrbZaA?=
 =?us-ascii?Q?6DZ2oI6wWY9G/kigSu380d6DGjvVd2nSbk9duvqXKwxHjQo7jQYZcLRpDA8f?=
 =?us-ascii?Q?NkEKE3+lyDDx4E2FOFidG5n21/t7PeJ1DBBcPKxF0Wmqf/r05gFv3t4OKVNP?=
 =?us-ascii?Q?pCmE8Q5wyt+dfj0Cyx7SATVMt7b2LrCZa0O2N6B6ufGy/Ybt5VwgqHin+XoU?=
 =?us-ascii?Q?vvJVo/ibXcHQgPNiNVeLneKrTrrdWK2Fx5kJ8udUm0RMKgUq8ND7/rSBmGnu?=
 =?us-ascii?Q?6OYAkq5O4LqU/xo6F9hFqaPjE3+Fws7g59LFzpfo+/hq1ugTemUcHsaEaGIc?=
 =?us-ascii?Q?T78NiI/8VZhzlnJx9uWK10svWBrgFmQsQPfqwunoRiNxJ/em0qpR5422Lx2C?=
 =?us-ascii?Q?6EHGHVExjUGVh4WtDFLvkZMI0+ZjN4+64X+u6l1TDrUEUWw8pLFEPCF1+tI3?=
 =?us-ascii?Q?yoomRLSQTpk8dOETWt3g7AJJ5tTT469Mc4wmP265yuVqfjo7AwIIkEVUOCvy?=
 =?us-ascii?Q?wG+fkRstcbPkYJnTUd/aM3FOC+gjirCsTfbSVuqtonYIfOe4sk78FvEKF34L?=
 =?us-ascii?Q?m8TSfhjg4wNkM6h9ojoaCib50kiPhe2Iu4ON2BekQ8lTMKnCmThH0yI1q8Ch?=
 =?us-ascii?Q?AoPZVG9bEmw0fLnbXOzzTDrToe0M/RZlNI5sFBYulbzvTHF+kE1hdG+iWN6b?=
 =?us-ascii?Q?0PV+DTRux+0jc0O7QPQFdh2agl/UIXEbW2pK9O1I?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eebe33fe-a60a-4006-7c7d-08dbb8b45435
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 02:01:25.1678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3zfCZ3BOXHdFudFmEW8HJ7W8RaUU/8EiJl2C4UkWhj6LCwzeZawDtkWC7FrRhk48r8V6pamIRbSiwgk5p1USKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB6478
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 19:01:42 -0700 (PDT)

si_meminfo() will read and assign more info not just free/ram pages.
For just DAMOS_WMARK_FREE_MEM_RATE use, only get free and ram pages
is ok to save cpu.

Change from v1:
v1 fold free mem rate logic into __damos_get_wmark_free_mem_rate and not
invoke si_meminfo, just get free/ram_pages in global.
v2 cancel this __damos_get_wmark_free_mem_rate and just calculate rate
in damos_wmark_metric_value to keep it simple.

Signed-off-by: Huan Yang <link@vivo.com>
---
 mm/damon/core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index bcd2bd9d6c10..a3f812d78267 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1280,12 +1280,9 @@ static bool kdamond_need_stop(struct damon_ctx *ctx)
 
 static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric)
 {
-	struct sysinfo i;
-
 	switch (metric) {
 	case DAMOS_WMARK_FREE_MEM_RATE:
-		si_meminfo(&i);
-		return i.freeram * 1000 / i.totalram;
+		return global_zone_page_state(NR_FREE_PAGES) * 1000 / totalram_pages();
 	default:
 		break;
 	}
-- 
2.34.1