Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
References: <63b3742c-0efe-c096-c737-a0e0419480bd@outlook.com>
 <59dd15dd-5b35-871d-6d3a-ec779975b089@outlook.com>
 <0a72f462-8b8e-4dec-6ce4-f52e33423957@outlook.com>
 <CY8PR05MB9378441D3F6430D1A414142BCDFAA@CY8PR05MB9378.namprd05.prod.outlook.com>
 <20230919032138.GC348037@frogsfrogsfrogs>
User-agent: mu4e 1.8.10; emacs 27.1
From:   Chandan Babu R <chandanbabu@kernel.org>
To:     "Darrick J. Wong" <djwong@kernel.org>
Cc:     Wang Jianchao <jianchwa@outlook.com>,
        Chandan Babu R <chandanrlinux@gmail.com>,
        linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] xfs: use roundup_pow_of_two instead of ffs during
 xlog_find_tail
Date:   Tue, 19 Sep 2023 12:04:44 +0530
In-reply-to: <20230919032138.GC348037@frogsfrogsfrogs>
Message-ID: <874jjqk6t2.fsf@debian-BULLSEYE-live-builder-AMD64>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Mon, Sep 18, 2023 at 08:21:38 PM -0700, Darrick J. Wong wrote:
> On Tue, Sep 19, 2023 at 10:06:56AM +0800, Wang Jianchao wrote:
>> Ping ? Do I need other update on this patch ?
>
> Nope, I think this is ok...
>
>> Thanks
>> Jianchao
>> 
>> On 2023/9/13 09:38, Wang Jianchao wrote:
>> > 
>> > In our production environment, we find that mounting a 500M /boot
>> > which is umount cleanly needs ~6s. One cause is that ffs() is
>> > used by xlog_write_log_records() to decide the buffer size. It
>> > can cause a lot of small IO easily when xlog_clear_stale_blocks()
>> > needs to wrap around the end of log area and log head block is
>> > not power of two. Things are similar in xlog_find_verify_cycle().
>> > 
>> > The code is able to handed bigger buffer very well, we can use
>> > roundup_pow_of_two() to replace ffs() directly to avoid small
>> > and sychronous IOs.
>> > 
>> > Reviewed-by: Dave Chinner <dchinner@redhat.com>
>> > Signed-off-by: Wang Jianchao <wangjc136@midea.com>
>
> ...so let's see if the release manager will take this patch.
>
> Chandan?  Could you pull in the various one-off patches floating around
> on the list that have passed review?  ;)

I had picked this patch along with others sometime last week.

I have pushed the new set of commits to official xfs-linux git repository and
sent the announcement mail around 30 mins ago.

>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> PS: If you'd like to send a pull request to push things along, please do
>

-- 
Chandan