Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
References: <20230912082101.342002-1-ying.huang@intel.com>
 <20230912082101.342002-5-ying.huang@intel.com>
User-agent: mu4e 1.8.13; emacs 28.2
From:   Alistair Popple <apopple@nvidia.com>
To:     Huang Ying <ying.huang@intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Bharata B Rao <bharata@amd.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
        Wei Xu <weixugc@google.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Michal Hocko <mhocko@kernel.org>,
        Yang Shi <shy828301@gmail.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Rafael J Wysocki <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH -V3 4/4] dax, kmem: calculate abstract distance with
 general interface
Date:   Tue, 19 Sep 2023 15:31:29 +1000
In-reply-to: <20230912082101.342002-5-ying.huang@intel.com>
Message-ID: <87y1h24tft.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k2G8y6VlnY0jRcBZiXKOmy0qPnWrjoUg13ZTkXI7E/uehubDplItgsEf8nq2?=
 =?us-ascii?Q?YRaIFkhUwW+JiiTamtoL532e4EZQCQZOhX0rtgK+FggIlg5FjQYMr9xz4gq1?=
 =?us-ascii?Q?f6c+Dx4cTARi4p34cb1C8l/faCKdrb2Fr0ZXwNIaKqZ598ubpPbZFqqcx+k4?=
 =?us-ascii?Q?vkQZ4GkDmv3lS2AD+f0J3fXPbPkQ66jjsD+Ghsq4DohjBF9svBwCOJdvI6LE?=
 =?us-ascii?Q?Rvvk0NYVJIEGdtSaLD1kuvlV1TM6oh5EplKeZhbLk6avWtYoCjsKVpMk/3BR?=
 =?us-ascii?Q?/QC+Ewp7nHfllkfKSMzRsnMJg8tU+pe4i3fyXxNFWxe4LgLrBL/KOrgA7LWe?=
 =?us-ascii?Q?HgYiXVi/lHry7szqFN04SUHCrUDUyaJN1sF2Hf/znoRbLWOuOAAG1RpVinR9?=
 =?us-ascii?Q?HcK8vBcgpmp1N00GMYvGB5JfE8cPoTakPxnAxNpjsuNuV3KGY4MD2RTX7lzT?=
 =?us-ascii?Q?xNRGqidP5Js+myuOneRxBpup16vyzH1V0aOs6DNTDZDzE53oSgoeEZ8d5hwH?=
 =?us-ascii?Q?jljEIEf6/S2uSytaEU9vt4tVo5N0WUgk0NRQoqEQEeP8y/fshdSGVryp78jN?=
 =?us-ascii?Q?j6Ubjcr0fYY8XXtvubdU9d608T11tb15ptBokgANh46rduKQh3SBE0U1Fjq2?=
 =?us-ascii?Q?W8GWniKvKAJI3FL3koE+Mvx8Nmcfs+vxrxxKz4Qz3l332Akzx49y9HPjNIQ2?=
 =?us-ascii?Q?j+tZJQxCUa80fnIC47HMRsihus76mRJ7G1VIIGAgTbJ7tEqzzA0Lvf1BSEs/?=
 =?us-ascii?Q?be84D9/WkBl98L9qi4qFtFKuWKY6Xr02CNZjPd5u7D91hRrypuk87jukifuT?=
 =?us-ascii?Q?czqGg2Ny17+DIoOIUVUaCk58mZYE5Wjx6HbbNhEnIi7rBoCaByogxzx3sPx9?=
 =?us-ascii?Q?rtm8kmRuTB3T7ufwMrtLq5I6oACHTvykGEaCDBqm0Moa9XJYpzHLo6nrvG76?=
 =?us-ascii?Q?yMuXw7L36eeaL864viRcws1mdNKO6//qNSdvDofgdgUhYweI8+4j6SNe8Q4Q?=
 =?us-ascii?Q?429dU9v5hGTM1oUcjey0euEbTxXUMwMbEsBuZg6sGWKkTJBjbPLcaqyKHqSD?=
 =?us-ascii?Q?4+DhztLTLigZC1wg9UATnS63CwBe23Lh8s4q30lEtbkn08HiTMH5B4cckSHY?=
 =?us-ascii?Q?CRJB7kHVObwu8XKIFCG9aJqP6rm1OEV2gYo6O6NICvWR2H8wUFCAVmq+HClB?=
 =?us-ascii?Q?2pOisocCGBgBw7jWpiVHHNgcihjrfUNM2hBUaptHFGzSoXmqWx7Qj7WCe7KY?=
 =?us-ascii?Q?w46iNnY03+HOMrBve3rawEd5FjXsMxdfb6Mhw7eyTnEI2xBoqU8hokYU5lVa?=
 =?us-ascii?Q?KbbIYlTrtSI8ZvQEGDedwaenBoh363c484PCCBT08MfW9mkPLvzPFoBnMdRu?=
 =?us-ascii?Q?vVskQ8hKKmhX3wLzVH42BSNCSNw58sHSQDPm2p7qjjSRSFl/jOZp8IL+By3S?=
 =?us-ascii?Q?pfCWSst7z8qXoeEmW7PEzUND3RnkXjQjLEdUjYpcKzrVP79BUWCU0WHJ0q7F?=
 =?us-ascii?Q?ig6o5Ylbc2b+NxP4QJgyClPmJQ4LOdkXhGrPBdnmEep+09oZUOtqnl3JqKt1?=
 =?us-ascii?Q?p4gvg/jFHO2Dsj5ujCNRsbqppfn2zqfB9t1GEQPP?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0c77615-a920-46fa-88b0-08dbb8d2263f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 05:34:52.9127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KIG610Jlu8BAQJCSPAvIO+zACFqnEg7AH791BAlfrxgQPV14bFFyx8w3cKpYf+EU6WqJzy3ov0hnmvW6C1dgqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5504
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 18 Sep 2023 22:35:11 -0700 (PDT)


Huang Ying <ying.huang@intel.com> writes:

> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index fa1a8b418f9a..ca68ef17554b 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -586,7 +586,7 @@ EXPORT_SYMBOL_GPL(init_node_memory_type);
>  void clear_node_memory_type(int node, struct memory_dev_type *memtype)
>  {
>  	mutex_lock(&memory_tier_lock);
> -	if (node_memory_types[node].memtype == memtype)
> +	if (node_memory_types[node].memtype == memtype || !memtype)
>  		node_memory_types[node].map_count--;
>
>  	/*
>  	 * If we umapped all the attached devices to this node,

This implies it's possible memtype == NULL. Yet we have this:

	 * clear the node memory type.
	 */
	if (!node_memory_types[node].map_count) {
		node_memory_types[node].memtype = NULL;
		put_memory_type(memtype);
	}

It's not safe to call put_memory_type(NULL), so what condition guarantees
map_count > 1 when called with memtype == NULL? Thanks.

 - Alistair