Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <f4989b6e49323e501cce1597f73ab024498ab7e7.camel@linux.intel.com>
Subject: Re: [PATCH v3] tools/power/x86/intel_pstate_tracer: python minimum
 version
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Doug Smythies <dsmythies@telus.net>, rafael.j.wysocki@intel.com
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mario.Limonciello@amd.com,
        'Swapnil Sapkal' <swapnil.sapkal@amd.com>, Ray.Huang@amd.com
Date:   Mon, 18 Sep 2023 10:25:15 -0700
In-Reply-To: <002401d9e9e5$248f3d50$6dadb7f0$@telus.net>
References: <001701d9e9ae$02438120$06ca8360$@telus.net>
         <002301d9e9e2$13424090$39c6c1b0$@telus.net>
         <002401d9e9e5$248f3d50$6dadb7f0$@telus.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2023-09-17 at 21:03 -0700, Doug Smythies wrote:
>=20
Think somehow one extra new line in email.

> From: Doug Smythies <dsmythies@telus.net>
>=20
> Change the minimum python version from 2.7 to 3.6.
> Remove a 2.X backwards compatibility line.
>=20
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
Acked-by: Srinivas Pandruvada<srinivas.pandruvada@linux.intel.com>

> ---
>=20
> v2 -> v3: Try to fix mess that was v2.
> v1 -> v2: Fix careless typos.
>=20
> ---
> .../x86/intel_pstate_tracer/intel_pstate_tracer.py=C2=A0=C2=A0 | 12 +++++=
+-----
> -
> =C2=A01 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git
> a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> index ec3323100e1a..38cfbdcdedb7 100755
> --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
> =C2=A0# SPDX-License-Identifier: GPL-2.0-only
> =C2=A0# -*- coding: utf-8 -*-
> =C2=A0#
> @@ -11,11 +11,11 @@ then this utility enables and collects trace data
> for a user specified interval
> =C2=A0and generates performance plots.
>=20
> =C2=A0Prerequisites:
> -=C2=A0=C2=A0=C2=A0 Python version 2.7.x or higher
> +=C2=A0=C2=A0=C2=A0 Python version 3.6.x or higher
> =C2=A0=C2=A0=C2=A0=C2=A0 gnuplot 5.0 or higher
> -=C2=A0=C2=A0=C2=A0 gnuplot-py 1.8 or higher
> +=C2=A0=C2=A0=C2=A0 python3-gnuplot 1.8 or higher
> =C2=A0=C2=A0=C2=A0=C2=A0 (Most of the distributions have these required p=
ackages. They
> may be called
> -=C2=A0=C2=A0=C2=A0=C2=A0 gnuplot-py, phython-gnuplot or phython3-gnuplot=
, gnuplot-nox,
> ... )
> +=C2=A0=C2=A0=C2=A0=C2=A0 gnuplot-py, python-gnuplot or python3-gnuplot, =
gnuplot-nox, ...
> )
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0 HWP (Hardware P-States are disabled)
> =C2=A0=C2=A0=C2=A0=C2=A0 Kernel config for Linux trace is enabled
> @@ -23,7 +23,7 @@ Prerequisites:
> =C2=A0=C2=A0=C2=A0=C2=A0 see print_help(): for Usage and Output details
>=20
> =C2=A0"""
> -from __future__ import print_function
> +
> =C2=A0from datetime import datetime
> =C2=A0import subprocess
> =C2=A0import os
> @@ -562,7 +562,7 @@ if __name__ =3D=3D "__main__":
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0 # Temporary (or perhaps not)
> =C2=A0=C2=A0=C2=A0=C2=A0 cur_version =3D sys.version_info
> -=C2=A0=C2=A0=C2=A0 print('python version (should be >=3D 2.7):')
> +=C2=A0=C2=A0=C2=A0 print('python version (should be >=3D 3.6):')
> =C2=A0=C2=A0=C2=A0=C2=A0 print(cur_version)
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0 # Left as "cleanup" for potential future re-run =
ability.
> --
> 2.25.1
>=20
>=20