Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <8ce3f7e172a747100366ebd14d3bd74fe549ae10.camel@pengutronix.de>
Subject: Re: [PATCH] arm64: dts: imx8mp: assign parent clock and rate for
 audio clocks
From:   Lucas Stach <l.stach@pengutronix.de>
To:     Shengjiu Wang <shengjiu.wang@nxp.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, marex@denx.de,
        peng.fan@nxp.com, alexander.stein@ew.tq-group.com,
        laurent.pinchart@ideasonboard.com, aford173@gmail.com,
        Frank.Li@nxp.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        shengjiu.wang@gmail.com
Date:   Tue, 19 Sep 2023 10:19:57 +0200
In-Reply-To: <1695108775-22924-1-git-send-email-shengjiu.wang@nxp.com>
References: <1695108775-22924-1-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

Hi Shengjiu,

Am Dienstag, dem 19.09.2023 um 15:32 +0800 schrieb Shengjiu Wang:
> Assign parent clock for audio AHB and AXI clocks, and assign
> clock rate for audio PLL1 and PLL2.
> 
Please don't do this. Configuring all those clocks in the clock
controller is a pain to override if the board uses the PLLs in any
other way than the reference design.

The audio AXI and AHB clocks are already properly configured with Adams
patch [1], so there is no need for the changes in this patch.

Please set up the audio PLLs in the board DT in peripheral nodes that
are actually using those clocks.

Regards,
Lucas

[1] https://lore.kernel.org/all/20230819105002.132750-1-aford173@gmail.com/

> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 6f2f50e1639c..8a8a2c4aff9f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -734,16 +734,26 @@ clk: clock-controller@30380000 {
>  						  <&clk IMX8MP_CLK_A53_CORE>,
>  						  <&clk IMX8MP_CLK_NOC>,
>  						  <&clk IMX8MP_CLK_NOC_IO>,
> -						  <&clk IMX8MP_CLK_GIC>;
> +						  <&clk IMX8MP_CLK_GIC>,
> +						  <&clk IMX8MP_CLK_AUDIO_AHB>,
> +						  <&clk IMX8MP_CLK_AUDIO_AXI_SRC>,
> +						  <&clk IMX8MP_AUDIO_PLL1>,
> +						  <&clk IMX8MP_AUDIO_PLL2>;
>  				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
>  							 <&clk IMX8MP_ARM_PLL_OUT>,
>  							 <&clk IMX8MP_SYS_PLL2_1000M>,
>  							 <&clk IMX8MP_SYS_PLL1_800M>,
> -							 <&clk IMX8MP_SYS_PLL2_500M>;
> +							 <&clk IMX8MP_SYS_PLL2_500M>,
> +							 <&clk IMX8MP_SYS_PLL1_800M>,
> +							 <&clk IMX8MP_SYS_PLL1_800M>;
>  				assigned-clock-rates = <0>, <0>,
>  						       <1000000000>,
>  						       <800000000>,
> -						       <500000000>;
> +						       <500000000>,
> +						       <400000000>,
> +						       <800000000>,
> +						       <393216000>,
> +						       <361267200>;
>  			};
>  
>  			src: reset-controller@30390000 {