Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp505033rdb; Tue, 19 Sep 2023 01:50:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsSYRzix6c3sctGIlybM8Douff2A0erJI9gwcWJwIy/8J0CpoGEvTedypG084Ckv8SSuUB X-Received: by 2002:a05:620a:394c:b0:76e:ef12:2063 with SMTP id qs12-20020a05620a394c00b0076eef122063mr13374965qkn.10.1695113450303; Tue, 19 Sep 2023 01:50:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695113450; cv=none; d=google.com; s=arc-20160816; b=Zfla0Xd0gDLS9pAM8RX9VWam+/oVwCKOx1xc1ECMq4vZkO/hr7cP51+w783TPjtsz0 1GeBtPSi4CSGtHAddX2nJ+srHruBR84Pe+ZU6WT8+hmmoVT8Fyj3lNeH5u+cqB22grvh mcVj4LfOwQLbW2Nl1D2TWsawIrXQoN5LgqIwCE1lwk+0th3p4ZWCKRbVgeTWKbZgdb/N wlRpuMDH0HkkZ+nWd0VwdyDg+wF6C+tbQvksfLjTfFO65/n6fpo/NiLdfnIcfCrfoXkU kXUZpq2/mx1zKEOufaCqltFT9UrUQzz3X7JmrMKoo+TyWKNfTC1hUELCZyhRg9TVxM+2 fVTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=d+QN0U5RBvPB+LQBKT54TBbLW6jvJ5von4IO9caoPP4=; fh=wnRLHTfX4Tmv9pnqbI3jqJQ47HBNrD2OoY4V+DP1io0=; b=WSu5zf3zBAS8fgYfynxR9Gnx6KSgpCik7GuXY2UDZ++H3AsY0uFZUwK1SFwMj/WFM8 XFs06Ebl6gGx6hlXefQLpPJVK9dSlFwGCiqxC7YW4/25KY/A0XbG7m4K9BBUO43taMfW wYQrwkNKReOGTLej47F9N2JfkZoGnw97IycuV86Xzv1FuTQda3RfNu1XThw2gkxZOL0V 6aJdrdHaNK8+7V+fySaiNfbj1mlOkSt9Q5Zq8HHpVp5Vy6rrokdWPDSoIQJE9JtsFhCF DqoRprWwA+rysXK2eu0ojPHy4Hs0mwj6O+mXhCqTaDd2Sb6A3dkrXRfCyfKLTDjjVSVd dL7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NabwgZal; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id q80-20020a632a53000000b0057404ce2fc8si9151937pgq.529.2023.09.19.01.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 01:50:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NabwgZal; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A23ED802A6C9; Tue, 19 Sep 2023 01:40:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230371AbjISIkb (ORCPT + 99 others); Tue, 19 Sep 2023 04:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229641AbjISIk3 (ORCPT ); Tue, 19 Sep 2023 04:40:29 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE547E6 for ; Tue, 19 Sep 2023 01:40:22 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPS id 55EA9C433CA; Tue, 19 Sep 2023 08:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695112822; bh=Omy2LUg3uWH1pkOVY4vjdkn5QW6igyJTSPgKd0JcqqA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=NabwgZalixdVnMCJQGMY5fHyowm94ENXgA9GQpnn0eqYrBXHp6meiXaFdiCMtU6RL hawFjKZelXREnGLpBm4SZbXxfUQ2sMN6hUzm6VrVSLkhCTwAszul/hkmO1KbwZzuYj N1ElyvnGX0zBi5rKztKHmx84J+zdfVp7QtMPCuhxEInF7eREv0BIiKNXND1q4aWFrG 1glOcYf/PvfxBSATEKH5el1w/fF5aWx/FIx47KIFLo4MBY/h43dQrmP/J08KFdOlRt 3TT/pcuia0tmo4gvhDinLFfTAi9ZKKv1VYthquugVRHFLce5HLQjMz6cohfSdzvEk3 cKrY0d1Omp21w== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 3955FE11F4A; Tue, 19 Sep 2023 08:40:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] net: stmmac: fix incorrect rxq|txq_stats reference From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169511282223.26432.8274174696059034896.git-patchwork-notify@kernel.org> Date: Tue, 19 Sep 2023 08:40:22 +0000 References: <20230917165328.3403-1-jszhang@kernel.org> In-Reply-To: <20230917165328.3403-1-jszhang@kernel.org> To: Jisheng Zhang Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, johannes@sipsolutions.net, u.kleine-koenig@pengutronix.de X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 19 Sep 2023 01:40:31 -0700 (PDT) Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Mon, 18 Sep 2023 00:53:28 +0800 you wrote: > commit 133466c3bbe1 ("net: stmmac: use per-queue 64 bit statistics > where necessary") caused one regression as found by Uwe, the backtrace > looks like: > > INFO: trying to register non-static key. > The code is fine but needs lockdep annotation, or maybe > you didn't initialize this object before use? > turning off the locking correctness validator. > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc1-00449-g133466c3bbe1-dirty #21 > Hardware name: STM32 (Device Tree Support) > unwind_backtrace from show_stack+0x18/0x1c > show_stack from dump_stack_lvl+0x60/0x90 > dump_stack_lvl from register_lock_class+0x98c/0x99c > register_lock_class from __lock_acquire+0x74/0x293c > __lock_acquire from lock_acquire+0x134/0x398 > lock_acquire from stmmac_get_stats64+0x2ac/0x2fc > stmmac_get_stats64 from dev_get_stats+0x44/0x130 > dev_get_stats from rtnl_fill_stats+0x38/0x120 > rtnl_fill_stats from rtnl_fill_ifinfo+0x834/0x17f4 > rtnl_fill_ifinfo from rtmsg_ifinfo_build_skb+0xc0/0x144 > rtmsg_ifinfo_build_skb from rtmsg_ifinfo+0x50/0x88 > rtmsg_ifinfo from __dev_notify_flags+0xc0/0xec > __dev_notify_flags from dev_change_flags+0x50/0x5c > dev_change_flags from ip_auto_config+0x2f4/0x1260 > ip_auto_config from do_one_initcall+0x70/0x35c > do_one_initcall from kernel_init_freeable+0x2ac/0x308 > kernel_init_freeable from kernel_init+0x1c/0x138 > kernel_init from ret_from_fork+0x14/0x2c > > [...] Here is the summary with links: - [v2] net: stmmac: fix incorrect rxq|txq_stats reference https://git.kernel.org/netdev/net/c/8070274b472e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html