Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761442AbXKHRAc (ORCPT ); Thu, 8 Nov 2007 12:00:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760066AbXKHRAX (ORCPT ); Thu, 8 Nov 2007 12:00:23 -0500 Received: from saeurebad.de ([85.214.36.134]:38693 "EHLO saeurebad.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755186AbXKHRAW (ORCPT ); Thu, 8 Nov 2007 12:00:22 -0500 Date: Thu, 8 Nov 2007 17:58:59 +0100 From: Johannes Weiner To: Alexey Starikovskiy Cc: "Rafael J. Wysocki" , "Michael (rabenkind) Brandstetter" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: 2.6.24-rc1: OOPS at acpi_battery_update Message-ID: <20071108165859.GC12231@cataract> Mail-Followup-To: Alexey Starikovskiy , "Rafael J. Wysocki" , "Michael (rabenkind) Brandstetter" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org References: <1193652664.22149.4.camel@localhost> <200711050118.34610.rjw@sisk.pl> <20071108155344.GA12231@cataract> <200711081717.00421.rjw@sisk.pl> <47333ACB.6070408@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47333ACB.6070408@suse.de> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 26 Hi Alex, On Thu, Nov 08, 2007 at 07:35:23PM +0300, Alexey Starikovskiy wrote: > Rafael J. Wysocki wrote: > >On Thursday, 8 of November 2007, Johannes Weiner wrote: > >>Hi, > >> > >>is there any reason, why acpi_battery_get_property() should call > >>acpi_battery_update() at all? > > > >Alex? > Do you mean "why should it call _whole_ battery update?" ? > get_state should be sufficient in order to not get stale data. Okay, than I understood it correct. Acked-by: Johannes Weiner Thanks! Hannes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/