Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp507328rdb; Tue, 19 Sep 2023 01:57:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSWCFnLcMNruFi0Fqyf9Pf3mLc/ttq4cYFlbxbd7ehUAI7h9pQa+iKKd6tHFpAPTIO09uc X-Received: by 2002:a17:902:da8e:b0:1c0:c640:3f3e with SMTP id j14-20020a170902da8e00b001c0c6403f3emr11583104plx.42.1695113846140; Tue, 19 Sep 2023 01:57:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695113846; cv=none; d=google.com; s=arc-20160816; b=ySy/yg56vkEf0XWQl2QRnfNgaaLCly0K5zKY2/bLbtaVTn+SO7eYR1HwbaExKMfHcG nS94i/lO3DPijWzsgeDC//urK3IUTvnp1RY0ZCK8T0SU+V6lJvhQOjdqgkZJdMRZPhvK MWpTIXZval0rrvDb67Y0bQT83kr55t/z+BvXgH5L3rg8BEMU36mGXmK74lyThQALe5aV 9Dx690ZWWlqIuU7/VJpMKtx0lIkE9QwJocGkr+NHLFwcv+hlLFxLzUGj0xgjknfdU7FV pX3xawHyxEb+rNYBRZJpFCYILeIs24aQWn+0dVPo2cMna9RccQ5Ia9OmdnDKzhHKuU86 ALPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tAfEmd/npIF2gBkYBMSwJ92upyIDAhErFXilxRY8Mi0=; fh=1YNwm5KBWetjB3qGkhgLqh/dZnCTsWuqRk83JW6hjgE=; b=UJhVa51G/iMfa2Zw18mi+Oksan+UOXfOpgBc9xof1dwKBn37zdYPKqZ0vvDcGm0YSK OzydbMaHUbnNDSs1Aj7T8XkrnSEcC4qVQLclseJNoLjS3uLlQcR1mohJdzThi00iPxdU 3DJLXiSGWaQpksXvp3GAKPdgvP7UWfP7zhFx656ZE/xR/k++7sILhji7QALpgyQCnxtf uG0HK2yByUSzlnxdgfZu5NmthEo463t3QXQvXfvpuKcmJPNgq//ft1L5horeeYZ5ZIyF dr1ab64ivqldYnY3U/fzQ1OYbcBbcL8t3G6JCSTVkVB9SSM6qnqk7c7O8R/JZbn5w/8+ BB8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c0wCqTQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id u3-20020a170902e5c300b001bf5753e0ccsi9958058plf.119.2023.09.19.01.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 01:57:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c0wCqTQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E4FF88045967; Tue, 19 Sep 2023 01:52:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231183AbjISIwl (ORCPT + 99 others); Tue, 19 Sep 2023 04:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230527AbjISIw3 (ORCPT ); Tue, 19 Sep 2023 04:52:29 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 728D518D; Tue, 19 Sep 2023 01:52:13 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FB71C433CC; Tue, 19 Sep 2023 08:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695113533; bh=HwGEKdiyV/VIwXG51/5quMq97DbDp7dqdnUhrgn3UpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c0wCqTQMRaotoCVvUT+lI7QbMcheeX375KMBnNiFEqJs8XfM3M8qiElu2G/v/b+is srykVE+g0QFcTjUKraW9k8yx9xFJNrryXCWNLzDrI9MAdToZwp/Cc9AQ9Xt9Ig5G64 8UMDj1cRvu8/iq4ofU+tjgk5m+kNqSVWPCJc4eiZgaL3A7HzfVAJp9pmF5ag+qQl4T S7y+ek6km5tTgFSJB1241xmw+W0NoDHiOy681JTZbG8o3a9uZlYUO8nGQilTvQ2xh3 ar+XKlxRL09z/6o1FsZv69diz3SRl8zgAher4O/jc8SxLxoPQilTP18jvQiW0WMdO6 twBuq0psUf1xA== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 09/15] tty: fix kernel-doc for functions in tty.h Date: Tue, 19 Sep 2023 10:51:50 +0200 Message-ID: <20230919085156.1578-10-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230919085156.1578-1-jirislaby@kernel.org> References: <20230919085156.1578-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 19 Sep 2023 01:52:48 -0700 (PDT) tty_kref_get() is already included in Documentation, but is not properly formatted. Fix this. tty_get_baud_rate() is neither properly formatted, nor is included. Fix both. Signed-off-by: Jiri Slaby (SUSE) --- Documentation/driver-api/tty/tty_ioctl.rst | 3 +++ include/linux/tty.h | 21 +++++++++------------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Documentation/driver-api/tty/tty_ioctl.rst b/Documentation/driver-api/tty/tty_ioctl.rst index 9b0be79fc15e..3ff1ac5e07f1 100644 --- a/Documentation/driver-api/tty/tty_ioctl.rst +++ b/Documentation/driver-api/tty/tty_ioctl.rst @@ -5,3 +5,6 @@ TTY IOCTL Helpers ================= .. kernel-doc:: drivers/tty/tty_ioctl.c + +.. kernel-doc:: include/linux/tty.h + :identifiers: tty_get_baud_rate diff --git a/include/linux/tty.h b/include/linux/tty.h index 59d675f345e9..4b6340ac2af2 100644 --- a/include/linux/tty.h +++ b/include/linux/tty.h @@ -390,14 +390,12 @@ int vcs_init(void); extern const struct class tty_class; /** - * tty_kref_get - get a tty reference - * @tty: tty device + * tty_kref_get - get a tty reference + * @tty: tty device * - * Return a new reference to a tty object. The caller must hold - * sufficient locks/counts to ensure that their existing reference cannot - * go away + * Returns: a new reference to a tty object. The caller must hold sufficient + * locks/counts to ensure that their existing reference cannot go away */ - static inline struct tty_struct *tty_kref_get(struct tty_struct *tty) { if (tty) @@ -435,14 +433,13 @@ void tty_encode_baud_rate(struct tty_struct *tty, speed_t ibaud, speed_t obaud); /** - * tty_get_baud_rate - get tty bit rates - * @tty: tty to query + * tty_get_baud_rate - get tty bit rates + * @tty: tty to query * - * Returns the baud rate as an integer for this terminal. The - * termios lock must be held by the caller and the terminal bit - * flags may be updated. + * Returns: the baud rate as an integer for this terminal. The termios lock + * must be held by the caller and the terminal bit flags may be updated. * - * Locking: none + * Locking: none */ static inline speed_t tty_get_baud_rate(struct tty_struct *tty) { -- 2.42.0