Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp508426rdb; Tue, 19 Sep 2023 02:00:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExqwWZvlzaYuO6CF8tZx2OESZRsQwQ1K4kvlfEIoPYtjUBeS6VRU5mF7THCtD09WBkas13 X-Received: by 2002:a05:6a00:2d11:b0:690:41a1:9b64 with SMTP id fa17-20020a056a002d1100b0069041a19b64mr11295628pfb.1.1695114025005; Tue, 19 Sep 2023 02:00:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695114024; cv=none; d=google.com; s=arc-20160816; b=wba9bonmO/VLl0KLCSdhB88+Y6PARKOVxzkjCr+9ut5ba4swNIyEp7d2gTssGXTtD+ 9s44kbfCW1NT88w96D6jgVpyVpi8twbP4UoWQ8ReRECEy6WkAZWJqt0go3pIZ+R50eCB +fSdxgXA/M1lbtcBvDWNCTiW6hJZ2C1tpjE09uv62sv+neAckDxhtFCBuuzGTeY8TZ9y +ncD4MuKt50EvxkYlq76tvcXKk5VK9TaodQBL3dCM8CsJdMXvcZ23b9oS+rM6xvVsI6v TY/L8XbCXhVjtOLLHsfI27pKwjSifyuIUhkZX+8CsmazjWFQOyJz6rr79uF5Dxi5nkm+ djyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fyiVatDowg3jVgZ+89vsnvtgbp1qtreiS/a1DPBlfkM=; fh=1YNwm5KBWetjB3qGkhgLqh/dZnCTsWuqRk83JW6hjgE=; b=u8SnGJlAJK3RxLp8jkpmzX+tjfMPuHBI6Uj84ovXyq9ccw0WePnElcbKqyXcND8Ess wuPn/MaCE6293BblN7GfxitnCBhia72q8mXBeGRyoEqj9yqLqRuvhgjVi3w2VwbCrout tL1o3/cMZGFrZDueR22vrF1hcd6qFp6tyK7J1lCLL5I/UYzeqj2a06GLDhdo/jxKRyjI qobYXTaAB1Trg52qchiN7391vhyk2nQ4cHG9mWjCXSwyhu5rbvkSI2N7HHzfLi0/P5h8 P/c57hr9+RKTbVxec4WyGKYHSEjeOwIdqPAgDYanhp74e4mCNi7sMw8CgSh8yaT5C8C9 cwlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BQn08LAl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id l69-20020a638848000000b00578c9144910si61770pgd.410.2023.09.19.02.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 02:00:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BQn08LAl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3F109828E85B; Tue, 19 Sep 2023 01:53:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbjISIx0 (ORCPT + 99 others); Tue, 19 Sep 2023 04:53:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231439AbjISIwn (ORCPT ); Tue, 19 Sep 2023 04:52:43 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63D26102; Tue, 19 Sep 2023 01:52:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B557C433C8; Tue, 19 Sep 2023 08:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695113540; bh=DHSUENlyJd4uiUZGKQE8nkqG9haGv3P+QdL7CmU1Hf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BQn08LAlbbz6RAgVL829tUjtjxoeZzG+Lm2yVb1SKAWDqex4ewLDs9jHvVcIgAvai 1cSpctU0XnIcwe2Ait94+n/9AVqmkLDh33EsLGJrXwxzWuDGxgtb3/L3mkFWI1OFPC VWU1KisqRD9ycP3D8G/HD+FXNcH8ozkTqMM5YBN/asOz7cOtwHIoiNfMmHKhqk4CY5 IuKEbjLBjtILUuU+KWNfqduu1F44MweAupMkNnJ+9ZhcKgkUXijkjKkyk1DsHclNuI lbTmkiO07wnH5+9nrFU8rGWixSvKflIzn4bux8W6CKqV+D6arvV0pqpnESUuNs0eF3 6PJM5Pd7mo2Lg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 14/15] tty: don't check for signal_pending() in send_break() Date: Tue, 19 Sep 2023 10:51:55 +0200 Message-ID: <20230919085156.1578-15-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230919085156.1578-1-jirislaby@kernel.org> References: <20230919085156.1578-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 19 Sep 2023 01:53:31 -0700 (PDT) msleep_interruptible() will check on its own. So no need to do the check in send_break() before calling the above. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/tty_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 87bb5094e0bb..24833b31b81c 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -2484,8 +2484,7 @@ static int send_break(struct tty_struct *tty, unsigned int duration) retval = tty->ops->break_ctl(tty, -1); if (retval) goto out; - if (!signal_pending(current)) - msleep_interruptible(duration); + msleep_interruptible(duration); retval = tty->ops->break_ctl(tty, 0); out: tty_write_unlock(tty); -- 2.42.0